database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-04-25 21:42:33 +03:00
Code

Avoid installcheck failure in TAP tests using injection_points

Browse Source 
These tests depend on the test module injection_points to be installed,
but it may not be available as the contents of src/test/modules/ are not
installed by default.

This commit adds a workaround based on a scan of pg_available_extensions
to check if the extension is available, skipping the test if it is not.
This allows installcheck to work transparently.

There are more tests impacted by this problem on HEAD, but for now this
addresses only the tests that exist on HEAD and v17 as the release is
close by.

Reported-by: Maxim Orlov
Discussion: https://postgr.es/m/CACG=ezZkoT-pFz6a9XnyToiuR-Wg8fGELqHLoyBodr+2h-77qA@mail.gmail.com
Backpatch-through: 17
This commit is contained in:
Michael Paquier 2024-09-04 08:56:23 +09:00
parent 12d3345c0d
commit 2cdcae9da6
2 changed files with 23 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/test/modules/test_misc/t/005_timeouts.pl
View File

@ -24,6 +24,18 @@ if ($ENV{enable_injection_points} ne 'yes')
my $node = PostgreSQL::Test::Cluster->new('master');
$node->init();
$node->start;
# Check if the extension injection_points is available, as it may be
# possible that this script is run with installcheck, where the module
# would not be installed by default.
my $result = $node->safe_psql('postgres',
"SELECT count(*) > 0 FROM pg_available_extensions WHERE name = 'injection_points';"
);
if ($result eq 'f')
{
plan skip_all => 'Extension injection_points not installed';
}
$node->safe_psql('postgres', 'CREATE EXTENSION injection_points;');
#

11
src/test/recovery/t/041_checkpoint_at_promote.pl
View File

@ -35,6 +35,17 @@ restart_after_crash = on
]);
$node_primary->start;
# Check if the extension injection_points is available, as it may be
# possible that this script is run with installcheck, where the module
# would not be installed by default.
my $result = $node_primary->safe_psql('postgres',
"SELECT count(*) > 0 FROM pg_available_extensions WHERE name = 'injection_points';"
);
if ($result eq 'f')
{
plan skip_all => 'Extension injection_points not installed';
}
my $backup_name = 'my_backup';
$node_primary->backup($backup_name);