database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2026-10-23 13:29:09 +03:00
Code Activity

Tolerate partial pgstats entries in pgstat_gc_entry_refs()

Browse Source 
pgstat_get_entry_ref_cached() inserts a local entry_ref with
shmem-related fields set to NULL, expecting pgstat_get_entry_ref() (its
sole caller) to fill them up before returning.  If an ERROR happens
while pgstat_get_entry_ref() runs, it could be possible to finish with a
local pgstats entry partially filled.

This could lead to a crash of pgstat_gc_entry_refs(), which tolerates a
NULL shared_stats in an assertion but unconditionally dereferenced its
"dropped" and "generation" fields.

This extends 4069df21be, being a cheap insurance against NULL pointer
dereference, if some code paths of pgstat_get_entry_ref() are not able
to perform any cleanup actions (for example after a dsm_create()
throwing an ERROR).

Reviewed-by: Grigorev Jurij <ju.grigorev@ftdata.ru>
Discussion: https://postgr.es/m/aqtiKTvl519bu8-V@paquier.xyz
Backpatch-through: 15
This commit is contained in:
Michael Paquier
2026-09-17 19:25:12 +09:00
parent 16735af3e3
commit 16706f1f4d
1 changed files with 9 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/backend/utils/activity/pgstat_shmem.c
View File

@@ -828,6 +828,15 @@ pgstat_gc_entry_refs(void)
Assert(!entry_ref->shared_stats ||
entry_ref->shared_stats->magic == 0xdeadbeef);
/* A NULL shared_entry marks a partial reference. */
if (entry_ref->shared_entry == NULL)
{
Assert(entry_ref->shared_stats == NULL);
Assert(entry_ref->pending == NULL);
pgstat_release_entry_ref(ent->key, entry_ref, false);
continue;
}
/*
* "generation" checks for the case of entries being reinitialized,
* and "dropped" for the case where these are.. dropped.