database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2026-10-23 13:29:09 +03:00
Code Activity

Don't attempt to upgrade bpchar indexes from versions before 14.

Browse Source 
As of a32b8dc98 and friends, amcheck will complain about bpchar
indexes that claim to allow de-duplication.  This causes our
cross-version-upgrade tests to fail when upgrading from a version
that lacks those commits, since there are some such indexes in the
core regression tests.  Drop such indexes from the upgrade source
database.  (oidvector indexes would be problematic too, but
there aren't any user-defined indexes on oidvector in our tests.)

Author: Peter Geoghegan <pg@bowt.ie>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/CAH2-Wzk-oO3HjLaByo8Vpse6Tpha1mqAW8DFShh-kS-Wo59ugA@mail.gmail.com
Backpatch-through: 14
This commit is contained in:
Tom Lane
2026-10-06 21:16:52 -04:00
parent 74f26a1934
commit 0fc4077f7f
1 changed files with 19 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/test/perl/PostgreSQL/Test/AdjustUpgrade.pm
View File

@@ -112,6 +112,25 @@ sub adjust_database_contents
'drop extension if exists test_ext7');
}
# We can no longer upgrade bpchar indexes that claim deduplication ability
# (amcheck will complain about them), so drop them if source is pre-v14.
if ($old_version < 14)
{
if ($dbnames{"regression"})
{
_add_st($result, 'regression',
'drop index if exists public.hslot_hubname',
'drop index if exists public.hslot_name',
'drop index if exists public.hub_name',
'drop index if exists public.iface_name',
'drop index if exists public.phone_name',
'drop index if exists public.pline_name',
'drop index if exists public.pslot_name',
'drop index if exists public.room_rno',
'drop index if exists public.wslot_name');
}
}
# we removed this test-support function in v17
if ($old_version >= 15 && $old_version < 17)
{