database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2026-10-23 13:29:09 +03:00
Code Activity

psql: Improve tab completion for GRANT/REVOKE CREATE

Browse Source 
Complete GRANT CREATE, REVOKE CREATE, and REVOKE GRANT OPTION FOR CREATE
with ON. Previously, the generic CREATE completion rule took precedence
and suggested object types such as TABLE.

Exclude these cases from the CREATE completion rule so that the existing
GRANT/REVOKE rules can handle them.

Author: Haruna Miwa <miwa@sraoss.co.jp>
Reviewed-by: Sho Ito <i.sho.0628@gmail.com>
Reviewed-by: Fujii Masao <masao.fujii@gmail.com>
Discussion: https://postgr.es/m/OSOP286MB78539E88C47403451BFFF140F18A2@OSOP286MB7853.JPNP286.PROD.OUTLOOK.COM
This commit is contained in:
Fujii Masao
2026-10-07 20:53:53 +09:00
parent cc33773482
commit 00e917ef65
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/bin/psql/tab-complete.in.c
View File

@@ -2185,8 +2185,14 @@ match_previous_words(int pattern_id,
/* BEGIN GEN_TABCOMPLETE */
/* CREATE */
/* complete with something you can create */
else if (TailMatches("CREATE"))
/*
* Complete with something you can create. If CREATE is a privilege name,
* leave it to the GRANT/REVOKE rules below.
*/
else if (TailMatches("CREATE") &&
!TailMatches("GRANT|REVOKE", "CREATE") &&
!TailMatches("REVOKE", "GRANT", "OPTION", "FOR", "CREATE"))
{
/* only some object types can be created as part of CREATE SCHEMA */
if (HeadMatches("CREATE", "SCHEMA"))