Fix archive-copy throwing "path not found" error for incr/diff backups.

Reported by yummyliu, Vitaliy Kukharik.

doc/xml/release.xml

@@ -22,6 +22,15 @@
 
                         <p>Fix directory syncs running recursively when only the specified directory should be synced.</p>
                     </release-item>
+
+                    <release-item>
+                        <release-item-contributor-list>
+                            <release-item-ideator id="yummyliu"/>
+                            <release-item-ideator id="kukharik.vitaliy"/>
+                        </release-item-contributor-list>
+
+                        <p>Fix <br-option>archive-copy</br-option> throwing <quote>path not found</quote> error for incr/diff backups.</p>
+                    </release-item>
                 </release-bug-list>
 
                 <release-feature-list>
@@ -4544,6 +4553,11 @@
             <contributor-id type="github">cjames53</contributor-id>
         </contributor>
 
+        <contributor id="kukharik.vitaliy">
+            <contributor-name-display>Vitaliy Kukharik</contributor-name-display>
+            <contributor-id type="github">vitabaks</contributor-id>
+        </contributor>
+
         <contributor id="kulkarni.nikhilchandra">
             <contributor-name-display>Nikhilchandra Kulkarni</contributor-name-display>
             <contributor-id type="github">nikhilchandra-kulkarni</contributor-id>
@@ -4685,5 +4699,10 @@
             <contributor-name-display>David Youatt</contributor-name-display>
             <contributor-id type="github">youattd</contributor-id>
         </contributor>
+
+        <contributor id="yummyliu">
+            <contributor-name-display>yummyliu</contributor-name-display>
+            <contributor-id type="github">yummyliu</contributor-id>
+        </contributor>
     </contributor-list>
 </doc>

lib/pgBackRest/Backup/Backup.pm

@@ -920,7 +920,7 @@ sub process
                         {strCipherPass => $oArchiveInfo->cipherPassSub()}),
                     $oStorageRepo->openWrite(STORAGE_REPO_BACKUP . "/${strBackupLabel}/" . MANIFEST_TARGET_PGDATA . qw{/} .
                         $oBackupManifest->walPath() . "/${strArchive}" . ($bCompress ? qw{.} . COMPRESS_EXT : ''),
-                        {strCipherPass => $strCipherPassBackupSet})
+                        {bPathCreate => true, strCipherPass => $strCipherPassBackupSet})
                     );
 
                 # Add the archive file to the manifest so it can be part of the restore and checked in validation

test/expect/real-all-001.log

@@ -126,7 +126,7 @@ incr backup - fail on archive_mode=always (db-master host)
 ------------------------------------------------------------------------------------------------------------------------------------
 
 incr backup - update during backup (db-master host)
-> [CONTAINER-EXEC] db-master [BACKREST-BIN] --config=[TEST_PATH]/db-master/pgbackrest.conf --stop-auto --no-archive-check --buffer-size=32768 --stanza=db backup --test --test-delay=1 --test-point=manifest-build=y
+> [CONTAINER-EXEC] db-master [BACKREST-BIN] --config=[TEST_PATH]/db-master/pgbackrest.conf --stop-auto --buffer-size=32768 --stanza=db backup --test --test-delay=1 --test-point=manifest-build=y
 ------------------------------------------------------------------------------------------------------------------------------------
 
 + supplemental file: [TEST_PATH]/db-master/pgbackrest.conf

test/expect/real-all-002.log

@@ -153,7 +153,7 @@ check db - verify check command on standby (db-standby host)
 ------------------------------------------------------------------------------------------------------------------------------------
 
 incr backup - update during backup (db-master host)
-> [CONTAINER-EXEC] db-master [BACKREST-BIN] --config=[TEST_PATH]/db-master/pgbackrest.conf --stop-auto --no-archive-check --buffer-size=32768 --stanza=db backup --test --test-delay=1 --test-point=manifest-build=y
+> [CONTAINER-EXEC] db-master [BACKREST-BIN] --config=[TEST_PATH]/db-master/pgbackrest.conf --stop-auto --buffer-size=32768 --stanza=db backup --test --test-delay=1 --test-point=manifest-build=y
 ------------------------------------------------------------------------------------------------------------------------------------
 
 + supplemental file: [TEST_PATH]/db-master/pgbackrest.conf

test/expect/real-all-003.log

@@ -153,7 +153,7 @@ check db - confirm standby manifest->build executed (db-standby host)
 ------------------------------------------------------------------------------------------------------------------------------------
 
 incr backup - update during backup (db-standby host)
-> [CONTAINER-EXEC] db-standby [BACKREST-BIN] --config=[TEST_PATH]/db-standby/pgbackrest.conf --stop-auto --no-archive-check --buffer-size=32768 --stanza=db backup --test --test-delay=1 --test-point=manifest-build=y
+> [CONTAINER-EXEC] db-standby [BACKREST-BIN] --config=[TEST_PATH]/db-standby/pgbackrest.conf --stop-auto --buffer-size=32768 --stanza=db backup --test --test-delay=1 --test-point=manifest-build=y
 ------------------------------------------------------------------------------------------------------------------------------------
 
 + supplemental file: [TEST_PATH]/db-master/pgbackrest.conf

test/expect/real-all-004.log

@@ -165,7 +165,7 @@ start all stanzas (db-master host)
 ------------------------------------------------------------------------------------------------------------------------------------
 
 incr backup - update during backup (backup host)
-> [CONTAINER-EXEC] backup [BACKREST-BIN] --config=[TEST_PATH]/backup/pgbackrest.conf --stop-auto --no-archive-check --buffer-size=32768 --stanza=db backup --test --test-delay=1 --test-point=manifest-build=y
+> [CONTAINER-EXEC] backup [BACKREST-BIN] --config=[TEST_PATH]/backup/pgbackrest.conf --stop-auto --buffer-size=32768 --stanza=db backup --test --test-delay=1 --test-point=manifest-build=y
 ------------------------------------------------------------------------------------------------------------------------------------
 
 + supplemental file: [TEST_PATH]/db-master/pgbackrest.conf

test/expect/real-all-005.log

@@ -211,7 +211,7 @@ check db - verify check command on standby (db-standby host)
 ------------------------------------------------------------------------------------------------------------------------------------
 
 incr backup - update during backup (backup host)
-> [CONTAINER-EXEC] backup [BACKREST-BIN] --config=[TEST_PATH]/backup/pgbackrest.conf --stop-auto --no-archive-check --buffer-size=32768 --stanza=db backup --test --test-delay=1 --test-point=manifest-build=y
+> [CONTAINER-EXEC] backup [BACKREST-BIN] --config=[TEST_PATH]/backup/pgbackrest.conf --stop-auto --buffer-size=32768 --stanza=db backup --test --test-delay=1 --test-point=manifest-build=y
 ------------------------------------------------------------------------------------------------------------------------------------
 
 + supplemental file: [TEST_PATH]/db-master/pgbackrest.conf

test/expect/real-all-006.log

@@ -164,7 +164,7 @@ archive-copy=y
 start-fast=y
 
 incr backup - update during backup (backup host)
-> [CONTAINER-EXEC] backup [BACKREST-BIN] --config=[TEST_PATH]/backup/pgbackrest.conf --stop-auto --no-archive-check --buffer-size=32768 --stanza=db backup --test --test-delay=1 --test-point=manifest-build=y
+> [CONTAINER-EXEC] backup [BACKREST-BIN] --config=[TEST_PATH]/backup/pgbackrest.conf --stop-auto --buffer-size=32768 --stanza=db backup --test --test-delay=1 --test-point=manifest-build=y
 ------------------------------------------------------------------------------------------------------------------------------------
 
 + supplemental file: [TEST_PATH]/db-master/pgbackrest.conf

test/lib/pgBackRestTest/Module/Real/RealAllTest.pm

@@ -621,8 +621,7 @@ sub run
         $oExecuteBackup = $oHostBackup->backupBegin(
             CFGOPTVAL_BACKUP_TYPE_INCR, 'update during backup',
             {strTest => TEST_MANIFEST_BUILD, fTestDelay => $fTestDelay,
-                strOptionalParam => '--' . cfgOptionName(CFGOPT_STOP_AUTO) .  ' --no-' . cfgOptionName(CFGOPT_ARCHIVE_CHECK) .
-                ' --' . cfgOptionName(CFGOPT_BUFFER_SIZE) . '=32768'});
+                strOptionalParam => '--' . cfgOptionName(CFGOPT_STOP_AUTO) . ' --' . cfgOptionName(CFGOPT_BUFFER_SIZE) . '=32768'});
 
         # Drop a table
         $oHostDbMaster->sqlExecute('drop table test_remove');