Daniel Black 39bb34b9c5 MDEV-36765: JSON Histogram cannot handle >1 byte characters ...

When json_escape changed[1] to return a -1 in the case of
a character that didn't match the character set, json_unescape_to_string
assumed the -1 meant out of memory and just looped with more
memory.

Problem 1 - json_escape needs to return a different code
so that the different between charset incompatibility and out
of memory needs to occur. This enables json_escape_to_string
to handle the it correctly (ignore and fail seems the best
option).

Problem 2 - JSON histograms need to support character with
where the column json min/maximum value aren't a character
set represented by a single byte.

Problem 2 was previously hidden as ? was a result of the conversion.

As JSON histograms can relate to columns when have an explict
character set, use that and fall back to bin which was the
previous default for non-string columns.

Replaces -1/-2 constants and handling with JSON_ERROR_ILLEGAL_SYMBOL /
JSON_ERROR_OUT_OF_SPACE defines.

[1] regression from: f699010c0f

2025-06-09 21:15:30 +03:00

31 KiB

Raw Blame History

View Raw