mirror of
https://github.com/MariaDB/server.git
synced 2025-12-03 05:41:09 +03:00
cf552f5886
A consistency check for fil_space_t::name is causing recovery failures
in MDEV-25180 (Atomic ALTER TABLE). So, we'd better remove that field
altogether.
fil_space_t::name was more or less a copy of dict_table_t::name
(except for some special cases), and it was not being used for
anything useful.
There used to be a name_hash, but it had been removed already in
commit a75dbfd718 (MDEV-12266).
We will also remove os_normalize_path(), OS_PATH_SEPARATOR,
OS_PATH_SEPATOR_ALT. On Microsoft Windows, we will treat \ and /
roughly in the same way. The intention is that for per-table
tablespaces, the filenames will always follow the pattern
prefix/databasename/tablename.ibd. (Any \ in the prefix must not
be converted.)
ut_basename_noext(): Remove (unused function).
read_link_file(): Replaces RemoteDatafile::read_link_file().
We will ensure that the last two path component separators are
forward slashes (converting up to 2 trailing backslashes on
Microsoft Windows), so that everywhere else we can
assume that data file names end in "/databasename/tablename.ibd".
Note: On Microsoft Windows, path names that start with \\?\ must
not contain / as path component separators. Previously, such paths
did work in the DATA DIRECTORY argument of InnoDB tables.
Reviewed by: Vladislav Vaintroub
89 lines
3.1 KiB
Plaintext
89 lines
3.1 KiB
Plaintext
--source include/innodb_page_size.inc
|
|
--source include/not_embedded.inc
|
|
|
|
let datadir= `select @@datadir`;
|
|
let page_size= `select @@innodb_page_size`;
|
|
|
|
--echo #
|
|
--echo # MDEV-15333 MariaDB (still) slow start
|
|
--echo #
|
|
|
|
# Ensure that on normal startup, no data files are read.
|
|
# Note: just like in MySQL, all .ibd files will still be
|
|
# opened at least once.
|
|
|
|
--echo # FIXME: Unlike MySQL, maybe MariaDB should not read the .ibd files
|
|
--echo # of tables with .isl file or DATA DIRECTORY attribute.
|
|
--echo # FIXME: This is much more noisy than MariaDB 10.1!
|
|
call mtr.add_suppression("\\[ERROR\\] InnoDB: Tablespace flags are invalid in datafile: .*test.t[rcd]\\.ibd");
|
|
call mtr.add_suppression("\\[ERROR\\] InnoDB: Operating system error number .* in a file operation\\.");
|
|
call mtr.add_suppression("\\[ERROR\\] InnoDB: The error means the system cannot find the path specified\\.");
|
|
call mtr.add_suppression("\\[ERROR\\] InnoDB: If you are installing InnoDB, remember that you must create directories yourself, InnoDB does not create them\\.");
|
|
call mtr.add_suppression("\\[Warning\\] InnoDB: Ignoring tablespace for `test`\\.`td` because it could not be opened\\.");
|
|
|
|
CREATE TABLE tr(a INT)ENGINE=InnoDB ROW_FORMAT=REDUNDANT;
|
|
CREATE TABLE tc(a INT)ENGINE=InnoDB ROW_FORMAT=COMPACT
|
|
PAGE_COMPRESSED=1 PAGE_COMPRESSION_LEVEL=9;
|
|
--replace_result $MYSQL_TMP_DIR MYSQL_TMP_DIR
|
|
eval CREATE TABLE td(a INT)ENGINE=InnoDB ROW_FORMAT=DYNAMIC
|
|
STATS_PERSISTENT=0 DATA DIRECTORY='$MYSQL_TMP_DIR';
|
|
|
|
--source include/shutdown_mysqld.inc
|
|
|
|
--move_file $datadir/test/tr.ibd $datadir/test/tr0.ibd
|
|
--move_file $datadir/test/tc.ibd $datadir/test/tc0.ibd
|
|
--move_file $MYSQL_TMP_DIR/test/td.ibd $datadir/test/td0.ibd
|
|
# TODO: test that MariaDB does not even attempt to open the files
|
|
#--mkdir $datadir/test/tr.ibd
|
|
#--mkdir $datadir/test/tc.ibd
|
|
#--mkdir $MYSQL_TMP_DIR/test/td.ibd
|
|
|
|
perl;
|
|
die unless open OUT, ">", "$ENV{datadir}/test/tr.ibd";
|
|
print OUT "foo " x $ENV{page_size};
|
|
close OUT or die;
|
|
die unless open OUT, ">", "$ENV{datadir}/test/tc.ibd";
|
|
print OUT "bar " x $ENV{page_size};
|
|
close OUT or die;
|
|
die unless open OUT, ">", "$ENV{MYSQL_TMP_DIR}/test/td.ibd";
|
|
print OUT "xyz " x $ENV{page_size};
|
|
close OUT or die;
|
|
die unless open ISL, "+<", "$ENV{datadir}/test/td.isl";
|
|
$_=<ISL>;
|
|
if (m|^[a-zA-Z]:|)
|
|
{
|
|
tr|/|\\|;
|
|
seek(ISL, 0, SEEK_SET) or die;
|
|
print ISL or die;
|
|
}
|
|
close ISL or die;
|
|
EOF
|
|
|
|
--let $restart_parameters= --skip-innodb-buffer-pool-load-at-startup
|
|
--source include/start_mysqld.inc
|
|
--let $restart_parameters=
|
|
|
|
SELECT COUNT(*) FROM INFORMATION_SCHEMA.ENGINES
|
|
WHERE engine = 'innodb'
|
|
AND support IN ('YES', 'DEFAULT', 'ENABLED');
|
|
|
|
--source include/shutdown_mysqld.inc
|
|
|
|
# TODO: test that MariaDB does not even attempt to open the files
|
|
#--rmdir $datadir/test/tr.ibd
|
|
#--rmdir $datadir/test/tc.ibd
|
|
#--rmdir $MYSQL_TMP_DIR/test/td.ibd
|
|
--remove_file $datadir/test/tr.ibd
|
|
--remove_file $datadir/test/tc.ibd
|
|
--remove_file $MYSQL_TMP_DIR/test/td.ibd
|
|
|
|
--move_file $datadir/test/tr0.ibd $datadir/test/tr.ibd
|
|
--move_file $datadir/test/tc0.ibd $datadir/test/tc.ibd
|
|
--move_file $datadir/test/td0.ibd $MYSQL_TMP_DIR/test/td.ibd
|
|
|
|
--source include/start_mysqld.inc
|
|
SELECT * FROM tr;
|
|
SELECT * FROM tc;
|
|
SELECT * FROM td;
|
|
DROP TABLE tr,tc,td;
|