cmiller@zippy.cornsilk.net 4c9af55908 Bug#28984: crasher on connect with out of range password length in \ ...

protocol

Fixed duplicated code, same as last commit.

One could send a malformed packet that caused the server to SEGV.  In 
recent versions of the password protocol, the client tells the server 
what length the ciphertext is (almost always 20).  If that length was
large enough to overflow a signed char, then the number would jump to 
very large after being casted to unsigned int.

Instead, cast the *passwd char to uchar.

2007-06-12 08:47:36 -04:00

172 KiB

Raw Blame History

View Raw