mirror of
https://github.com/MariaDB/server.git
synced 2025-11-12 10:22:39 +03:00
5d142f9958
When MySQL 5.7 introduced indexed virtual columns, it introduced several bugs into the online table-rebuilding ALTER, that is, the row_log_table_apply() family of functions. The online_log format that was introduced for online table-rebuilding ALTER in MySQL 5.6 should be sufficient. Ideally, any indexed virtual column values would be evaluated based on the log records in the temporary file. There is no need to log virtual column values. (For ADD INDEX, that is row_log_apply(), we always must log the values of the keys, no matter if the columns are virtual.) Because omitting the virtual column values removes any chance of row_log_table_apply() working with indexed virtual columns, we will for now refuse LOCK=NONE in table-rebuilding ALTER operations when indexes on virtual columns exist. This restriction would be lifted in MDEV-14341. innobase_indexed_virtual_exist(): New predicate, to determine if indexed virtual columns exist in a table definition. ha_innobase::check_if_supported_inplace_alter(): Refuse online rebuild if indexed virtual columns exist. rec_get_converted_size_temp_v(), rec_convert_dtuple_to_temp_v(): Remove. row_log_table_delete(), row_log_table_update(, row_log_table_insert(): Remove parameters for virtual columns. trx_undo_read_v_rows(): Remove the col_map parameter. row_log_table_apply(): Do not deal with virtual columns.
53 lines
1.3 KiB
Plaintext
53 lines
1.3 KiB
Plaintext
--source include/have_innodb.inc
|
|
--source include/have_debug.inc
|
|
--source include/have_debug_sync.inc
|
|
|
|
CREATE TABLE t1 (j SERIAL, i INT, v INT AS (i) VIRTUAL) ENGINE=InnoDB;
|
|
CREATE TABLE t2 (j SERIAL, i INT, v INT AS (i) VIRTUAL) ENGINE=InnoDB
|
|
ROW_FORMAT=REDUNDANT;
|
|
CREATE TABLE t3 (i INT, v INT AS (i) VIRTUAL) ENGINE=InnoDB;
|
|
CREATE TABLE t4 (i INT, v INT AS (i) VIRTUAL) ENGINE=InnoDB
|
|
ROW_FORMAT=REDUNDANT;
|
|
|
|
let $n=4;
|
|
while ($n)
|
|
{
|
|
eval INSERT INTO t$n SET i=1;
|
|
eval ALTER TABLE t$n ADD INDEX(v), LOCK=NONE;
|
|
--error ER_ALTER_OPERATION_NOT_SUPPORTED_REASON
|
|
eval ALTER TABLE t$n ADD COLUMN k INT, LOCK=NONE;
|
|
eval ALTER TABLE t$n ADD COLUMN k INT;
|
|
--error ER_ALTER_OPERATION_NOT_SUPPORTED_REASON
|
|
eval ALTER TABLE t$n DROP k, LOCK=NONE;
|
|
eval ALTER TABLE t$n DROP INDEX v, LOCK=NONE;
|
|
eval ALTER TABLE t$n DROP k, LOCK=NONE;
|
|
dec $n;
|
|
}
|
|
|
|
connect (ddl,localhost,root,,test);
|
|
connection default;
|
|
|
|
let $n=4;
|
|
while ($n)
|
|
{
|
|
connection ddl;
|
|
SET DEBUG_SYNC = 'row_log_table_apply1_before SIGNAL copied WAIT_FOR dml';
|
|
send_eval ALTER TABLE t$n FORCE;
|
|
|
|
connection default;
|
|
SET DEBUG_SYNC = 'now WAIT_FOR copied';
|
|
BEGIN;
|
|
eval UPDATE t$n SET i = 0;
|
|
ROLLBACK;
|
|
SET DEBUG_SYNC = 'now SIGNAL dml';
|
|
|
|
connection ddl;
|
|
reap;
|
|
connection default;
|
|
eval SELECT * FROM t$n;
|
|
eval DROP TABLE t$n;
|
|
dec $n;
|
|
}
|
|
disconnect ddl;
|
|
SET DEBUG_SYNC = 'RESET';
|