96aee50cfb
Problem: ======== OPTIMIZE TABLE on a FULLTEXT index crashes when the aux tables hold two spellings of a word that are equal under the index collation. The index lookup in fts_index_fetch_nodes() and the DELETE in fts_optimize_write_word() both compare words by collation, but fts_optimize_index_fetch_node() compares the bytes, so each spelling becomes a separate fts_word_t. fts_optimize_compact() then optimizes and writes back each of them separately. Writing one deletes the rows of the other, including the rows that were just written, so index entries can be lost. If all the documents were deleted, the first write removes both words. The next word that fts_optimize_words() reads from the zip buffer is the other spelling, the fetch finds nothing, and the server aborts Solution: ======== fts_optimize_collation_fetch_node(): New callback used only by OPTIMIZE. It adds the fetched records whose words are equal under the index collation to the same fts_word_t, so the spellings are optimized and written back as one word. The records arrive ordered by first_doc_id, so the nodes stay in order. fts_optimize_fetch_node(): The helper of the fetch callbacks, which compares the words either by bytes or by the given collation. fts_optimize_index_fetch_node() still compares by bytes, which is what the information_schema code expects. fts_optimize_words(): Use fts_optimize_collation_fetch_node(). The word read from the zip buffer can already have been optimized together with an earlier spelling, so an empty fetch is not an error. Skip the word instead of asserting.
Code status:
ci.appveyor.com
MariaDB: The innovative open source database
MariaDB was designed as a drop-in replacement of MySQL(R) with more features, new storage engines, fewer bugs, and better performance.
MariaDB is brought to you by the MariaDB Foundation and the MariaDB Corporation. Please read the CREDITS file for details about the MariaDB Foundation, and who is developing MariaDB.
MariaDB is developed by many of the original developers of MySQL who now work for the MariaDB Corporation, the MariaDB Foundation and by many people in the community.
MySQL, which is the base of MariaDB, is a product and trademark of Oracle Corporation, Inc. For a list of developers and other contributors, see the Credits appendix. You can also run 'SHOW authors' to get a list of active contributors.
A description of the MariaDB project and a manual can be found at:
https://mariadb.com/docs/release-notes
Getting the code, building it and testing it
Refer to the following guide: https://mariadb.org/get-involved/getting-started-for-developers/get-code-build-test/ which outlines how to build the source code correctly and run the MariaDB testing framework, as well as which branch to target for your contributions.
Help
More help is available from the Maria Discuss mailing list https://lists.mariadb.org/postorius/lists/discuss.lists.mariadb.org/ and MariaDB's Zulip instance, https://mariadb.zulipchat.com/
Licensing
MariaDB is specifically available only under version 2 of the GNU General Public License (GPLv2). (I.e. Without the "any later version" clause.) This is inherited from MySQL. Please see the README file in the MySQL distribution for more information.
License information can be found in the COPYING file. Third party license information can be found in the THIRDPARTY file.
Bug Reports
Bug and/or error reports regarding MariaDB should be submitted at: https://jira.mariadb.org
For reporting security vulnerabilities see: https://mariadb.org/about/security-policy/
The code for MariaDB, including all revision history, can be found at: https://github.com/MariaDB/server