60c1218344
at SERIALIZABLE with innodb_snapshot_isolation=ON
Since commit 7fbbbc983f (MDEV-36330), ha_innobase::store_lock() starts
the transaction and opens a read view at the SERIALIZABLE isolation
level when innodb_snapshot_isolation=ON. The transaction is registered
with the server only in ha_innobase::external_lock(), which normally
follows store_lock().
HANDLER OPEN invokes store_lock() through get_lock_data() but never
invokes external_lock(). The transaction started by store_lock() was
therefore never registered with the server, and nothing committed it:
neither the end of the statement nor a subsequent implicit commit. The
next statement on the connection would execute inside that stale
transaction, with its old read view and its READ ONLY attribute.
If the stale transaction was read-only, a subsequent write would be
executed in it without a transaction identifier, and a debug assertion
on trx->id would fail in row_ins_index_entry() or
row_ins_sec_index_entry(). This could happen, for example, when the
session default was READ ONLY and the write was in an explicit
START TRANSACTION READ WRITE, or when ALTER TABLE...ALGORITHM=COPY
copied the rows without undo log.
Changes:
- ha_innobase::store_lock(): Do not start a transaction or open a read
view. Only set the isolation level.
- ha_innobase::external_lock(): At the SERIALIZABLE isolation level with
innodb_snapshot_isolation=ON, start the transaction and open the read
view right before the transaction is registered with
innobase_register_trx(). A transaction that is started here is always
registered with the server. Like before, the read view is created at
the start of the statement, before any rows are accessed.
Code status:
ci.appveyor.com
MariaDB: The innovative open source database
MariaDB was designed as a drop-in replacement of MySQL(R) with more features, new storage engines, fewer bugs, and better performance.
MariaDB is brought to you by the MariaDB Foundation and the MariaDB Corporation. Please read the CREDITS file for details about the MariaDB Foundation, and who is developing MariaDB.
MariaDB is developed by many of the original developers of MySQL who now work for the MariaDB Corporation, the MariaDB Foundation and by many people in the community.
MySQL, which is the base of MariaDB, is a product and trademark of Oracle Corporation, Inc. For a list of developers and other contributors, see the Credits appendix. You can also run 'SHOW authors' to get a list of active contributors.
A description of the MariaDB project and a manual can be found at:
https://mariadb.com/docs/release-notes
Getting the code, building it and testing it
Refer to the following guide: https://mariadb.org/get-involved/getting-started-for-developers/get-code-build-test/ which outlines how to build the source code correctly and run the MariaDB testing framework, as well as which branch to target for your contributions.
Help
More help is available from the Maria Discuss mailing list https://lists.mariadb.org/postorius/lists/discuss.lists.mariadb.org/ and MariaDB's Zulip instance, https://mariadb.zulipchat.com/
Licensing
MariaDB is specifically available only under version 2 of the GNU General Public License (GPLv2). (I.e. Without the "any later version" clause.) This is inherited from MySQL. Please see the README file in the MySQL distribution for more information.
License information can be found in the COPYING file. Third party license information can be found in the THIRDPARTY file.
Bug Reports
Bug and/or error reports regarding MariaDB should be submitted at: https://jira.mariadb.org
For reporting security vulnerabilities, see our security-policy.
The code for MariaDB, including all revision history, can be found at: https://github.com/MariaDB/server