65f524d81d
Fix for MDEV-38218 changed MDL conflict handling to allow high priority cluster threads to BF abort any conflicting MDL lock holder. With this, the InnoDB purge coordinator became also potential target for BF aborts. However, InnoDB purge thread has no statement boundary and could never reset THD::killed state, after the BF abort. Purge THDs are taken from a pool of innodb_purge_threads_MAX THDs, so about 32 purge runs later the killed THD coordinates purge again. From then on every open_purge_table() for a table with an indexed virtual column fails, and purge_sys_t::close_and_reopen() retries forever. Purge stops and server shutdown hangs. Separately, open_purge_table() allocates a TABLE_LIST on thd->mem_root and the coordinator THD never freed its mem_root, so it grew with every purge batch and every close_and_reopen() retry. Fix: - wsrep_handle_mdl_conflict(): when the granted thread is a SYSTEM_THREAD_GENERIC THD holding explicit MDL, make the BF requestor wait instead of aborting it. In practice this covers the InnoDB background threads (purge, statistics, FTS optimizer), which release their locks on their own. This restores the pre-MDEV-38218 behaviour for these threads only. - open_purge_table(): open with MYSQL_OPEN_IGNORE_KILLED so that a stale kill flag cannot block purge. - trx_purge_close_tables(): call reset_thd() instead of close_thread_tables() to free the coordinator's mem_root per batch. This commit has a new mtr test galera.MDEV-41450 This work is based on pull request https://github.com/MariaDB/server/pull/5854 by David Schilling, which is now rebased to MariaDB 10.11 and extended to have a mtr test. Assisted-by: https://mariadb.org/governance/governance-ai-policy/
Code status:
ci.appveyor.com
MariaDB: The innovative open source database
MariaDB was designed as a drop-in replacement of MySQL(R) with more features, new storage engines, fewer bugs, and better performance.
MariaDB is brought to you by the MariaDB Foundation and the MariaDB Corporation. Please read the CREDITS file for details about the MariaDB Foundation, and who is developing MariaDB.
MariaDB is developed by many of the original developers of MySQL who now work for the MariaDB Corporation, the MariaDB Foundation and by many people in the community.
MySQL, which is the base of MariaDB, is a product and trademark of Oracle Corporation, Inc. For a list of developers and other contributors, see the Credits appendix. You can also run 'SHOW authors' to get a list of active contributors.
A description of the MariaDB project and a manual can be found at:
https://mariadb.com/docs/release-notes
Getting the code, building it and testing it
Refer to the following guide: https://mariadb.org/get-involved/getting-started-for-developers/get-code-build-test/ which outlines how to build the source code correctly and run the MariaDB testing framework, as well as which branch to target for your contributions.
Help
More help is available from the Maria Discuss mailing list https://lists.mariadb.org/postorius/lists/discuss.lists.mariadb.org/ and MariaDB's Zulip instance, https://mariadb.zulipchat.com/
Licensing
MariaDB is specifically available only under version 2 of the GNU General Public License (GPLv2). (I.e. Without the "any later version" clause.) This is inherited from MySQL. Please see the README file in the MySQL distribution for more information.
License information can be found in the COPYING file. Third party license information can be found in the THIRDPARTY file.
Bug Reports
Bug and/or error reports regarding MariaDB should be submitted at: https://jira.mariadb.org
For reporting security vulnerabilities see: https://mariadb.org/about/security-policy/
The code for MariaDB, including all revision history, can be found at: https://github.com/MariaDB/server