1
0
mirror of https://github.com/MariaDB/server.git synced 2026-10-23 18:49:29 +03:00

MDEV-20022 sql_mode="oracle" does not support TO_NUMBER() function

This patch implements an Oracle style function to_number()
with the following signatures:

- to_number(number_or_string_subject)
- to_number(string_subject, string_format)

The function is implemented in sql/item_numconvfunc.cc.

The function returns the DOUBLE data type for
all signatures and input data types.

The format parser understands the following components:

- Digits: 0, 9
- Hex digits: X
- Group separators: comma (,) and G
- Decimal delimiers: period (.) and D
- Approximate number signature: EEEE
- Currency/numeric flags: $ and B
- Currency signatures: C, L, U
- Sign signatures: S, MI, PR
- Special format signatures: V, TM, TM9, TME
- Format flag: FM

Note, the parser was implemented assuming that we'll also have the
oppostite function to_char() soon for numeric input.
So it parser all known components.
However, the function to_number() does not support:
- Formats V, TM, TM9, TME. to_number() returns NULL if the format
  string has these components.
  These componens are supported only by to_char() in Oracle.

Features not inclided into this patch:
- The ON CONVERSION ERROR clause
- The third parameter (nlsparam)
- Internationalized components: G, D, C, L, U.
These features will be implemented later, under terms of MDEV-36978.

Notable changes in the other files:

- item_func.h: adding Item_handled_func::Handler_double

- simple_parser.h: adding a number of *CONTAINER* templates
  They help to save on duplicate code when creating classes
  suitable for passing into parsing templates such as OPT, OR2C, OR3C, etc

- simple_parser.h: Adding parsing templates OR4C and OR5C

- simple_parser.h: Moving the template "OPT" towars the beginning of the file
  Rule parsing templates TOKEN, TokenChoice, AND2, OR2C, OR3C, OR4C, OR5C, LIST
  now provide a sub-class Opt, to parse its optional rule.

- simple_parser.h: Adding "explicit" to all "operator bool" definitions

- Renaming Parser_templates::TOKEN to Parser_templates::TokenParser

- Adding "explicit" to all "operator bool()" templates/classes,
  to avoid hidden implicit conversion (to int, void*, etc).

- Renaming the LIST template parameter ELEMENT to ELEMENT_PARSER,
  to make it clearer what it is for.

- Renaming the OPT template parameter RULE to RULE_PARSER,
  to make it clearer what it is for.
This commit is contained in:
Alexander Barkov
2025-05-21 14:55:55 +04:00
parent 5f616f48bc
commit b10e209d16
18 changed files with 7192 additions and 210 deletions

View File

@@ -64,6 +64,7 @@ SET(SQL_EMBEDDED_SOURCES emb_qcache.cc libmysqld.c lib_sql.cc
../sql/item.cc ../sql/item_create.cc ../sql/item_func.cc
../sql/item_geofunc.cc ../sql/item_row.cc ../sql/item_strfunc.cc
../sql/item_subselect.cc ../sql/item_sum.cc ../sql/item_timefunc.cc
../sql/item_numconvfunc.cc
../sql/item_xmlfunc.cc ../sql/item_jsonfunc.cc
../sql/json_schema.cc ../sql/json_schema_helper.cc
../sql/key.cc ../sql/lock.cc ../sql/log.cc ../sql/log_cache.cc

File diff suppressed because it is too large Load Diff

View File

@@ -0,0 +1,953 @@
--echo #
--echo # MDEV-20022 sql_mode="oracle" does not support TO_NUMBER() function
--echo #
--echo #
--echo # to_number() with one argument
--echo #
--error ER_OPERAND_COLUMNS
SELECT to_number(ROW(1,1));
--error ER_ILLEGAL_PARAMETER_DATA_TYPE_FOR_OPERATION
SELECT to_number(point(1,1));
--echo # With one arg, to_number() works similarly CAST(expr AS DOUBLE)
CREATE TABLE t1 AS SELECT
to_number('123') AS c1,
to_number(123) AS c2,
to_number(123e0) AS c3,
to_number(123.0) AS c4;
SHOW COLUMNS IN t1;
SELECT * FROM t1;
DROP TABLE t1;
# However, it returns NULL in case of
# empty input, out of range values, trailing garbage
SELECT to_number('') AS c1;
SELECT to_number('1E+400') AS c1;
SELECT to_number('123x') AS c1;
--echo #
--echo # With two args only string+string are allowed
--echo #
--error ER_ILLEGAL_PARAMETER_DATA_TYPES2_FOR_OPERATION
SELECT to_number(point(1,1), '');
--error ER_ILLEGAL_PARAMETER_DATA_TYPES2_FOR_OPERATION
SELECT to_number('',point(1,1));
--error ER_ILLEGAL_PARAMETER_DATA_TYPES2_FOR_OPERATION
SELECT to_number(1,'');
--error ER_ILLEGAL_PARAMETER_DATA_TYPES2_FOR_OPERATION
SELECT to_number('',1);
--error ER_ILLEGAL_PARAMETER_DATA_TYPES2_FOR_OPERATION
SELECT to_number(1e0,'');
--error ER_ILLEGAL_PARAMETER_DATA_TYPES2_FOR_OPERATION
SELECT to_number('',1e0);
--echo #
--echo # Multiple dollar or B signs are not allowed
--echo #
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('0', '99$99$');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('0', '$9999$');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('0', '$9.99$');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('0', '9$9.9$99EEEE');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('0', '99B99B');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('0', 'B99B99B');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('0', 'B999B');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('0', 'B9.99B');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('0', '9B9.9B99EEEE');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('0', '.9$9BB$0B');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('0', '.0$0BB$9B');
--echo # Comma and G cannot co-exist
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('1', '9G9,9G9');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('1', '9,9G9,9');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('1', '0G0,0G0');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('1', '0,0G0,0');
--echo #
--echo # Dollar and C,L,U cannot co-exist
--echo #
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('1', '$C');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('1', '$L');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('1', '$U');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('1', '$C99');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('1', '$L99');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('1', '$U99');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('1', '0$C');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('1', '0$L');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('1', '0$U');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('1', '9$C');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('1', '9$L');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('1', '9$U');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('1', 'C0$');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('1', 'L0$');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('1', 'U0$');
--error ER_WRONG_VALUE_FOR_TYPE
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('1', '.$C');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('1', '.$L');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('1', '.$U');
--error ER_WRONG_VALUE_FOR_TYPE
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('1', 'D$C');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('1', 'D$L');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('1', 'D$U');
--error ER_WRONG_VALUE_FOR_TYPE
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('1', 'V$C');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('1', 'V$L');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('1', 'V$U');
--error ER_WRONG_VALUE_FOR_TYPE
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('1', '$.C');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('1', '$.L');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('1', '$.U');
--error ER_WRONG_VALUE_FOR_TYPE
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('1', '$DC');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('1', '$DL');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('1', '$DU');
--error ER_WRONG_VALUE_FOR_TYPE
--echo #
--echo # Test that non-constant wrong formats raise a warning (not an error)
--echo #
CREATE TABLE t1 (fmt VARCHAR(32));
INSERT INTO t1 VALUES ('$999$'),('C999');
SELECT to_number('9999', fmt) FROM t1;
DROP TABLE t1;
--echo #
--echo # An empty format is allowed and returns NULL
--echo #
SELECT to_number('', '');
SELECT to_number('1', '');
--echo #
--echo # B/dollar can go alone, in combination, with FM, and return NULL
--echo #
SELECT to_number('1', 'B');
SELECT to_number('1', '$');
SELECT to_number('1', 'B$');
SELECT to_number('1', '$B');
SELECT to_number('$', '$');
SELECT to_number('$', 'B$');
SELECT to_number('$', '$B');
SELECT to_number('1', 'FMB');
SELECT to_number('1', 'FM$');
SELECT to_number('1', 'FMB$');
SELECT to_number('1', 'FM$B');
SELECT to_number('$', 'FM$');
SELECT to_number('$', 'FMB$');
SELECT to_number('$', 'FM$B');
--echo #
--echo # . can go alone
--echo #
SELECT to_number('.', '.');
SELECT to_number('1', '.');
--echo #
--echo # 'S', 'MI', 'PR' alone are allowed (optionally with FM), NULL returned
--echo #
SELECT to_number('-', 'S');
SELECT to_number('-', 'MI');
SELECT to_number('<>', 'PR');
SELECT to_number('-', 'FMS');
SELECT to_number('-', 'SFM');
SELECT to_number('-', 'FMMI');
SELECT to_number('<>', 'FMPR');
SELECT to_number('1', 'S');
SELECT to_number('1', 'MI');
SELECT to_number('1', 'PR');
SELECT to_number('1', 'FMMI');
SELECT to_number('1', 'FMPR');
--echo #
--echo # Integer
--echo #
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('1', 'x999');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('1', '999x');
--echo # Correct formats
SELECT to_number('1', '999');
SELECT to_number('$12', '$99');
SELECT to_number('$12', '9$9');
SELECT to_number('$12', '99$');
SELECT to_number('1', 'B99');
SELECT to_number('1', '9B9');
SELECT to_number('1', '99B');
SELECT to_number('$1', 'B$9');
SELECT to_number('$1', '9B$');
SELECT to_number('$1', '$B9');
SELECT to_number('$1', '9$B');
SELECT to_number('1', '9,9,9,9');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', '9G9G9G9');
SELECT to_number('1', '0000');
SELECT to_number('1', '0,0,0,0');
SELECT to_number('1', '9999');
SELECT to_number('1', '9,9,9,9');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', '0G0G0G0');
SELECT to_number('1', '00009999');
SELECT to_number('1', '99999999');
SELECT to_number('1', '0,0,0,0,9,9,9,9');
SELECT to_number('1', '9,9,9,9,9,9,9,9');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', '0G0G0G0G9G9G9G9');
SELECT to_number('1', '99990000');
SELECT to_number('1', '99999999');
SELECT to_number('1', '9,9,9,9,0,0,0,0');
SELECT to_number('1', '9,9,9,9,9,9,9,9');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', '9G9G9G9G0G0G0G0');
SELECT to_number('123456.123456', '999999.999999') AS c1;
SELECT to_number('123,456.123456', '999,999.999999') AS c1;
SELECT to_number('1,2,3,4,5,6.123456', '9,9,9,9,9,9.999999') AS c1;
--echo #
--echo # Integer: 0 vs 9
--echo #
CREATE TABLE t1 (fmt VARCHAR(32));
INSERT INTO t1 VALUES
('0'),('9'),
('00'),('09'),('90'),('99'),
('000'),('009'),('090'),('099'), ('900'),('909'),('990'),('999');
CREATE TABLE t2 (sbj VARCHAR(32));
INSERT INTO t2 VALUES ('0'),('00'),('000'),('0000');
--echo # Expect NULL if
--echo # - the subject is shorter than the format, or
--echo # - if there's a format 0 outside of the subject length
SELECT
fmt, sbj, to_number(sbj,fmt),
IF(length(fmt)<length(sbj) OR
(fmt LIKE '0_' AND sbj LIKE '_') OR
(fmt LIKE '0__' AND sbj LIKE '__') OR
(fmt LIKE '0__' AND sbj LIKE '_') OR
(fmt LIKE '_0_' AND sbj LIKE '_'),
'Expect NULL','') AS comment
FROM t1, t2
WHERE length(fmt)>=length(sbj)
ORDER BY length(fmt),fmt,sbj;
DROP TABLE t1, t2;
--echo #
--echo # Fraction
--echo #
SELECT to_number('.', '.');
SELECT to_number('.', 'B.');
SELECT to_number('.', 'B.9');
SELECT to_number('.1', 'B.9');
SELECT to_number('1', 'B.');
SELECT to_number('1', 'B.9');
--echo #
--echo # Fraction + dollar
--echo #
SELECT to_number('$.', '$.');
SELECT to_number('1', '$.');
SELECT to_number('.1', '.9999');
SELECT to_number('.1', '.99990000');
SELECT to_number('$.1', '.9$9B');
SELECT to_number('.1', '.0000');
SELECT to_number('.1', '.00009999');
SELECT to_number('$.1', '.0$0B');
SELECT to_number('1', '$.9');
SELECT to_number('1', '$.9');
--echo #
--echo # Decimal
--echo #
SELECT to_number('1', '9999.');
SELECT to_number('1', '9999.9999');
SELECT to_number('1', '9999.99990000');
SELECT to_number('1', '9999.00009999');
SELECT to_number('1', '9999.');
SELECT to_number('1', '9999.9999');
SELECT to_number('1', '9999.99990000');
SELECT to_number('1', '9999.00009999');
--echo # The subject has more integer digits than the format
SELECT to_number('111.1','9.9');
--echo # The subject has more fractional digits than the format
SELECT to_number('1.111','9.9');
--echo # Multiple dollar and B prefix flags are not allowed
--error ER_WRONG_VALUE_FOR_TYPE
select to_number('$1','$$9.9');
--error ER_WRONG_VALUE_FOR_TYPE
select to_number('11','BB9.9');
--echo #
--echo # Decimal starting with zeros
--echo #
CREATE TABLE t1 (num VARCHAR(32), fmt VARCHAR(64));
INSERT INTO t1 VALUES
('1', '0.999'),
('111', '000.999'),
('111111','000999.999'),
('11111111','00090909.999');
SELECT to_number(num, fmt), fmt FROM t1;
SELECT to_number(num, @fmt:=REPLACE(fmt,'.','D')), @fmt FROM t1;
SELECT to_number(num, @fmt:=REPLACE(fmt,'.','V')), @fmt FROM t1;
SELECT to_number(num, @fmt:=REPLACE(fmt,'.','C')), @fmt FROM t1;
SELECT to_number(num, @fmt:=REPLACE(fmt,'.','L')), @fmt FROM t1;
DROP TABLE t1;
--echo #
--echo # Decimal + flags B/dollar + signs
--echo #
# B/$ can follow a leading sign
SELECT to_number('-1', 'SB');
SELECT to_number('-$1', 'S$');
SELECT to_number('-$1', 'SB$');
SELECT to_number('-$1', 'S$B');
# B/$ can be followed by a trailing sign
SELECT to_number('1', 'BS');
SELECT to_number('1', 'BMI');
SELECT to_number('1', 'BPR');
SELECT to_number('1', '$S');
SELECT to_number('1', '$MI');
SELECT to_number('1', '$PR');
# B/$ can be followed a currency
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'BC');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'BL');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'BU');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'BC99');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'BL99');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'BU99');
# B/$ can be followed a V
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'BV');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'BV99');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', '$V');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', '$V99');
# B/$ can be followed a decimal point
SELECT to_number('1', 'B.');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'BD');
SELECT to_number('1', 'B.99');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'BD99');
SELECT to_number('1', '$.');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', '$D');
SELECT to_number('1', '$.99');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', '$D99');
--echo #
--echo # Number1 (i.e. not starting with zeros)
--echo #
# Positional_currency+B cannot be followed by ,G
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('1', 'CB,999');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('1', 'CBG999');
# Correct formats
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'C999');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'C000');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'CB999');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'CB000');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'C');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'C.');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'CD');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'CV');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'C.99');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'CD99');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'CV99');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'CB.999');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'CBD999');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'CB');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'L999');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'L000');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'LB999');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'LB000');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'L');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'L.');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'LD');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'LV');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'L.99');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'LD99');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'LV99');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'LB.999');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'LBD999');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'LB');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'U999');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'U000');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'UB999');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'UB000');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'U');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'U.');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'UD');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'UV');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'U.99');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'UD99');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'UV99');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'UB.999');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'UBD999');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'UB');
--echo #
--echo # Number0: zeros + postfix sign
--echo #
SELECT to_number('12-', '00S');
SELECT to_number('12+', '00S');
SELECT to_number('12-', '00MI');
SELECT to_number('12 ', '00MI');
SELECT to_number('<12>', '00PR');
SELECT to_number(' 12 ', '00PR');
SELECT to_number('[12]', '00PR');
SELECT to_number('<1234>', '999999PR') AS c1;
SELECT to_number(' 1234 ', '999999PR') AS c1;
--echo #
--echo # Postfix sign
--echo #
SELECT to_number('12-', '99S');
SELECT to_number('12+', '99S');
SELECT to_number('12-', '99MI');
SELECT to_number('12 ', '99MI');
SELECT to_number('<12>', '99PR');
SELECT to_number(' 12 ', '99PR');
--echo #
--echo # Prefix sign
--echo #
SELECT to_number('-1', 'S');
SELECT to_number('-1', 'S00');
SELECT to_number('-12', 'S00');
SELECT to_number('-1', 'S99');
SELECT to_number('1', 'FMS');
SELECT to_number('-12', 'FMS00');
SELECT to_number('-12', 'FMS99');
SELECT to_number('1', 'SFM');
SELECT to_number('-12', 'SFM00');
SELECT to_number('-12', 'SFM99');
--echo #
--echo # Prefix-signed currency
--echo #
--echo # CLU are not supported yet
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'S00.99C');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'S99.99L');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'S99.99U');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'S00D99C');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'S99D99L');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'S99D99U');
SELECT to_number('-$12,345.67', 'S$999,099.99') AS c1;
SELECT to_number('+$12,345.67', 'S$999,099.99') AS c1;
SELECT to_number('-$12,345.67', 'S$999,999.99') AS c1;
SELECT to_number('+$12,345.67', 'S$999,999.99') AS c1;
SELECT to_number('$12,345.67', 'S$999,099.99') AS c1, 'Missing sign' AS comment;
SELECT to_number('-$45', 'S$999,099.99') AS c1;
SELECT to_number('+$45', 'S$999,099.99') AS c1;
SELECT to_number('$45', 'S$999,099.99') AS c1, 'Missing sign' AS comment;
SELECT to_number('-$45', 'S$999,999.99') AS c1;
SELECT to_number('+$45', 'S$999,999.99') AS c1;
SELECT to_number('$45', 'S$999,999.99') AS c1, 'Missing sign' AS comment;
SELECT to_number('+$5', 'S$999,099.99') AS c1;
SELECT to_number('+$45', 'S$999,099.99') AS c1;
SELECT to_number('+$045', 'S$999,099.99') AS c1;
SELECT to_number('+$0,045', 'S$999,099.99') AS c1;
SELECT to_number('+$00,045', 'S$999,099.99') AS c1;
SELECT to_number('+$000,045', 'S$999,099.99') AS c1;
SELECT to_number('+$0000,045', 'S$999,099.99') AS c1;
--echo #
--echo # FM
--echo #
SELECT to_number('1', 'FM');
SELECT to_number('1', 'FM9');
SELECT to_number('1,2', 'FM9,9');
SELECT to_number('1.2', 'FM9.9');
SELECT to_number('1-', 'FM9S');
SELECT to_number('-1', 'FMS9');
SELECT to_number('12-', 'FM00S');
SELECT to_number('12-', 'FM99S');
SELECT to_number('12-', 'FM99S');
SELECT to_number('12-', 'FM00.99S');
SELECT to_number('12-', 'FM99.99S');
SELECT to_number('12-', 'FM99.99S');
SELECT to_number('12.34-', 'FM00.99S');
SELECT to_number('12.34-', 'FM99.99S');
SELECT to_number('12.34-', 'FM99.99S');
--echo #
--echo # Long examples
--echo #
SELECT to_number('123,456,789','999,999,999') AS c1;
SELECT to_number('111,222,333,444,555','999,999,999,999,999') AS c1;
SELECT to_number('111,222,333,444,555,666,777,888,999',
'999,999,999,999,999,999,999,999,999') AS c1;
--echo #
--echo # EEEE specific tests
--echo #
--echo # EEEE cannot go without any integer digits
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('', 'EEEE');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('', '.EEEE');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('', '.9EEEE');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('1', '.999EEEE');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('1', '.9$9EEEE');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('1', '.9B9EEEE');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('1', '$EEEE');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('1', 'BEEEE');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('', 'S.9EEEE');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('', 'S.9EEEES');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('', 'FM.EEEE');
--echo #
--echo # EEEE correct formats
--echo #
--echo # Currency CLU is not supported yet
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'C0EEEE');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'L0EEEE');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'U0EEEE');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'C9EEEE');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'L9EEEE');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'U9EEEE');
--echo #
--echo # The following formats are not supported in Oracle.
--echo # However, it works if change C/L/U to dollar sign.
--echo # Looks like a bug in Oracle.
--echo # Anyway, CLU is not supported yet.
--echo #
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'S00.99CEEEE');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'S99.99LEEEE');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'S99.99UEEEE');
--echo # Trailing gargabe:
SELECT to_number('1E+3x', '99EEEE');
SELECT to_number('$1E+3x', '$99EEEE');
--echo #
--echo # Simple examples with EEEE
--echo #
SELECT to_number('1', '9EEEE');
SELECT to_number('1', '9.9EEEE');
SELECT to_number('1.2', '9.9EEEE');
--echo #
--echo # EEEE formats starting with zeros
--echo #
SELECT to_number('1', '00EEEE');
CREATE TABLE t1 (num VARCHAR(32), fmt VARCHAR(64));
INSERT INTO t1 VALUES
('1', '0.999'),
('111', '000.999'),
('111111','000999.999'),
('11111111','00090909.999');
SELECT to_number(num, @fmt:=CONCAT(fmt,'EEEE')), @fmt FROM t1;
SELECT to_number(num, @fmt:=CONCAT(REPLACE(fmt,'.','D'),'EEEE')), @fmt FROM t1;
SELECT to_number(num, @fmt:=CONCAT(REPLACE(fmt,'.','V'),'EEEE')), @fmt FROM t1;
SELECT to_number(num, @fmt:=CONCAT(REPLACE(fmt,'.','C'),'EEEE')), @fmt FROM t1;
SELECT to_number(num, @fmt:=CONCAT(REPLACE(fmt,'.','L'),'EEEE')), @fmt FROM t1;
DROP TABLE t1;
--echo #
--echo # B and dollar inside a EEEE format
--echo #
SELECT to_number('1', 'B0EEEE');
SELECT to_number('1', 'B9EEEE');
SELECT to_number('1', 'B0.EEEE');
SELECT to_number('1', 'B9.EEEE');
SELECT to_number('1', 'B0.9EEEE');
SELECT to_number('1', 'B9.9EEEE');
SELECT to_number('$1E+1', '$0EEEE');
SELECT to_number('$1E+1', '$9EEEE');
SELECT to_number('$1E+1', '$0.EEEE');
SELECT to_number('$1E+1', '$9.EEEE');
SELECT to_number('$1.E+1', '$0.EEEE');
SELECT to_number('$1.E+1', '$9.EEEE');
SELECT to_number('$1.2E+1', '$0.EEEE');
SELECT to_number('$1.2E+1', '$9.EEEE');
SELECT to_number('$1.2E+1', '$0.9EEEE');
SELECT to_number('$1.2E+1', '$9.9EEEE');
SELECT to_number('1', '999EEEE');
SELECT to_number('1', '999.EEEE');
SELECT to_number('1', '999.9999EEEE');
SELECT to_number ('$1', '9$9EEEE');
SELECT to_number ('$1', '9$9.EEEE');
SELECT to_number('1', '9B9EEEE');
SELECT to_number('1', '9B9.EEEE');
--echo #
--echo # EEEE formats with prefix and postfix signs and FM
--echo #
SELECT to_number('1.2E+1-', '99EEEES');
SELECT to_number('1.2E+1+', '99EEEES');
SELECT to_number('1.2E+1-', '99EEEEMI');
SELECT to_number('1.2E+1 ', '99EEEEMI');
SELECT to_number('<1.2E+1>', '99EEEEPR');
SELECT to_number(' 1.2E+1 ', '99EEEEPR');
SELECT to_number('-12.34E+2', 'S00.99EEEE');
SELECT to_number('-12.34E+2', 'S99.99EEEE');
SELECT to_number('$1.2E+1-', '$9.9EEEES');
SELECT to_number('$1.2E+1+', '$9.9EEEES');
SELECT to_number('$1.2E+1-', '$9.9EEEEMI');
SELECT to_number('$1.2E+1 ', '$9.9EEEEMI');
SELECT to_number('<$1.2E+1>', '$9.9EEEEPR');
# Oracle returns an error on ' $1.2E+1 '
# but works with ' $1.2E+1' in the next
# Looks like a bug in Oracle:
SELECT to_number(' $1.2E+1 ', '$9.9EEEEPR');
SELECT to_number('12.34E+2-', 'FM00.99EEEES');
SELECT to_number('12.34E+2-', 'FM99.99EEEES');
--echo #
--echo # X formats (hexadecimal)
--echo #
--echo # X cannot co-exist with dollar, B, dec, group, signs, currency
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('0', '$X');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('0', 'BX');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('0', 'X,X');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('0', 'XGX');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('0', 'X.X');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('0', 'XCX');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('0', 'XLX');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('0', 'XUX');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('0', 'SX');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('0', '$X');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('0', 'CX');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('0', 'LX');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('0', 'UX');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('0', 'X$');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('0', 'XC');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('0', 'XL');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('0', 'XU');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('0', 'XMI');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('0', 'XPR');
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('0', 'XS');
--echo #
--echo # FM and X can co-exist
--echo #
SELECT to_number('F', 'FMXXXX');
SELECT to_number('FF', 'FMXXXX');
SELECT to_number('FFF', 'FMXXXX');
SELECT to_number('FFFF', 'FMXXXX');
--echo #
--echo # X simple exaples
--echo #
SELECT to_number('0', 'X');
SELECT to_number('20', 'XX');
SELECT to_number('020', 'XXX');
SELECT to_number('2020', 'XXXX');
SELECT to_number('02020', 'XXXXX');
SELECT to_number('202020', 'XXXXXX');
SELECT to_number('202020', 'XXXXX');
--echo #
--echo # Zeros + xchain
--echo #
SELECT to_number('061', '00X');
SELECT to_number('0061', '00XX');
SELECT to_number('00061', '00XXX');
SELECT to_number('000061', '00XXXX');
SELECT to_number('0000061', '00XXXXX');
SELECT to_number('00000061', '00XXXXXX');
--echo #
--echo # 0 vs X
--echo #
CREATE TABLE t1 (fmt VARCHAR(32));
CREATE TABLE t2 (sbj VARCHAR(32));
DELIMITER $$;
FOR i IN 0..3 DO
INSERT INTO t1 VALUES (CONCAT(REPEAT('0',i), REPEAT('X',4-i)));
END FOR;
$$
FOR i IN 0..4 DO
INSERT INTO t2 VALUES (REPEAT('1',i));
END FOR;
$$
DELIMITER ;$$
--disable_warnings
SELECT fmt, sbj, to_number(sbj, fmt) AS c1 FROM t1, t2 ORDER BY fmt, sbj;
--enable_warnings
DROP TABLE t1, t2;
--echo #
--echo # Format TM is not supported by to_number(), only supported by to_char()
--echo #
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'TM');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'TM9');
--error ER_NOT_SUPPORTED_YET
SELECT to_number('1', 'TME');

View File

@@ -0,0 +1,125 @@
#
# MDEV-20022 sql_mode="oracle" does not support TO_NUMBER() function
#
SET debug_dbug='+d,numconv_format';
SELECT to_number('', '9') AS c;
c
0
Warnings:
Note 1105 A='9'
SELECT to_number('', '0') AS c;
c
0
Warnings:
Note 1105 A='0'
SELECT to_number('', '9.9') AS c;
c
0
Warnings:
Note 1105 A='9[.]9'
SELECT to_number('', '0.0') AS c;
c
0
Warnings:
Note 1105 A='0[.]0'
SELECT to_number('', '.9') AS c;
c
0
Warnings:
Note 1105 A='[.]9'
SELECT to_number('', '.0') AS c;
c
0
Warnings:
Note 1105 A='[.]0'
SELECT to_number('', '9$9') AS c;
c
0
Warnings:
Note 1105 A='9$9'
SELECT to_number('', '0$0') AS c;
c
0
Warnings:
Note 1105 A='0$0'
SELECT to_number('', '9B9') AS c;
c
0
Warnings:
Note 1105 A='9B9'
SELECT to_number('', '0B0') AS c;
c
0
Warnings:
Note 1105 A='0B0'
SELECT to_number('', '9.9$') AS c;
c
0
Warnings:
Note 1105 A='9[.]9$'
SELECT to_number('', '9.9B') AS c;
c
0
Warnings:
Note 1105 A='9[.]9B'
SELECT to_number('', '9C9') AS c;
ERROR 42000: This version of MariaDB doesn't yet support '<number format>='9C9''
SHOW WARNINGS;
Level Code Message
Note 1105 A='9[C]9'
Error 1235 This version of MariaDB doesn't yet support '<number format>='9C9''
SELECT to_number('', '9.9C') AS c;
ERROR 42000: This version of MariaDB doesn't yet support '<number format>='9.9C''
SHOW WARNINGS;
Level Code Message
Note 1105 A='9[.]9'RC='C'
Error 1235 This version of MariaDB doesn't yet support '<number format>='9.9C''
SELECT to_number('', '$9') AS c;
c
0
Warnings:
Note 1105 CFl='$'A='9'
SELECT to_number('', '$0') AS c;
c
0
Warnings:
Note 1105 CFl='$'A='0'
SELECT to_number('', 'B9') AS c;
c
0
Warnings:
Note 1105 CFl='B'A='9'
SELECT to_number('', 'B0') AS c;
c
0
Warnings:
Note 1105 CFl='B'A='0'
SELECT to_number('', 'C9') AS c;
ERROR 42000: This version of MariaDB doesn't yet support '<number format>='C9''
SHOW WARNINGS;
Level Code Message
Note 1105 LC='C'A='9'
Error 1235 This version of MariaDB doesn't yet support '<number format>='C9''
SELECT to_number('', 'L0') AS c;
ERROR 42000: This version of MariaDB doesn't yet support '<number format>='L0''
SHOW WARNINGS;
Level Code Message
Note 1105 LC='L'A='0'
Error 1235 This version of MariaDB doesn't yet support '<number format>='L0''
SELECT to_number('', '9PR') AS c;
c
0
Warnings:
Note 1105 A='9'RS='PR'
SELECT to_number('', 'FMS9') AS c;
c
0
Warnings:
Note 1105 FFl='FM'LS='S'A='9'
SELECT to_number('', 'FMTM') AS c;
ERROR 42000: This version of MariaDB doesn't yet support '<number format>='FMTM''
SHOW WARNINGS;
Level Code Message
Note 1105 FFl='FM'A=''TM='TM'
Error 1235 This version of MariaDB doesn't yet support '<number format>='FMTM''
SET debug_dbug=DEFAULT;

View File

@@ -0,0 +1,67 @@
--source include/have_debug.inc
--echo #
--echo # MDEV-20022 sql_mode="oracle" does not support TO_NUMBER() function
--echo #
SET debug_dbug='+d,numconv_format';
#
# Approximate::print
#
SELECT to_number('', '9') AS c;
SELECT to_number('', '0') AS c;
SELECT to_number('', '9.9') AS c;
SELECT to_number('', '0.0') AS c;
SELECT to_number('', '.9') AS c;
SELECT to_number('', '.0') AS c;
SELECT to_number('', '9$9') AS c;
SELECT to_number('', '0$0') AS c;
SELECT to_number('', '9B9') AS c;
SELECT to_number('', '0B0') AS c;
SELECT to_number('', '9.9$') AS c;
SELECT to_number('', '9.9B') AS c;
--error ER_NOT_SUPPORTED_YET
SELECT to_number('', '9C9') AS c;
SHOW WARNINGS;
--error ER_NOT_SUPPORTED_YET
SELECT to_number('', '9.9C') AS c;
SHOW WARNINGS;
#
# Unsigned_currency::print
#
SELECT to_number('', '$9') AS c;
SELECT to_number('', '$0') AS c;
SELECT to_number('', 'B9') AS c;
SELECT to_number('', 'B0') AS c;
--error ER_NOT_SUPPORTED_YET
SELECT to_number('', 'C9') AS c;
SHOW WARNINGS;
--error ER_NOT_SUPPORTED_YET
SELECT to_number('', 'L0') AS c;
SHOW WARNINGS;
#
# Currency_with_postfix_sign::print
#
SELECT to_number('', '9PR') AS c;
#
# Format::print
#
SELECT to_number('', 'FMS9') AS c;
--error ER_NOT_SUPPORTED_YET
SELECT to_number('', 'FMTM') AS c;
SHOW WARNINGS;
SET debug_dbug=DEFAULT;

View File

@@ -0,0 +1,100 @@
SET @saved_debug_dbug= @@debug_dbug;
SET @@debug_dbug='+d,numconv_format';
#
# MDEV-20022 sql_mode="oracle" does not support TO_NUMBER() function
#
CREATE FUNCTION bad(fmt VARCHAR(128)) RETURNS VARCHAR(128)
BEGIN
IF fmt RLIKE '(FM.*FM|B.*B|EEEE.*EEEE|[CLU$].*[CLU$]|[.VD].*[.VD]|(S|MI|PR).*(S|MI|PR))'
THEN
RETURN 'FM/B/currency/dec/sign cannot repeat';
END IF;
IF fmt RLIKE '[09XBCDLUV,G.$].*FM' THEN RETURN 'Unexpected + FM'; END IF;
IF fmt RLIKE '^[^09]*([.DV].*)?EEEE' THEN RETURN 'EEEE with no int digits #1'; END IF;
IF fmt RLIKE '^(FM|S)?[$B]+[CLU][0-9]*EEEE' THEN RETURN 'EEEE with no int digits #2'; END IF;
IF fmt RLIKE '.*EEEE.*(FM|[B09X.DV,GLCU$V])' THEN RETURN 'EEEE + unexpected'; END IF;
IF fmt RLIKE '^([$BC.DLUVS]|FM)EEEE' THEN RETURN '^Unexpected + EEEE immediately'; END IF;
IF fmt RLIKE '(G.*,|,.*G)' THEN RETURN 'comma and G cannot co-exist'; END IF;
IF fmt RLIKE '^([$B]|[^09]|)*[,G]' THEN RETURN 'group with no int digits'; END IF;
IF fmt RLIKE '[.DV].*[,G]' THEN RETURN 'dec + group'; END IF;
IF fmt RLIKE '(FM|[S.DCLUV])[,G]' THEN RETURN 'Unexpected + group immediately'; END IF;
IF fmt RLIKE '(MI|PR).+' THEN RETURN 'Trailing sign + something'; END IF;
IF fmt RLIKE '[$09BVCLUX.D,G].*TM' THEN RETURN 'Unexpected + TM'; END IF;
IF fmt RLIKE 'TM([^E9].*|[E9].+)' THEN RETURN 'TMx + something'; END IF;
IF fmt RLIKE '([9BCDLUVS.,G$]|TM).*X' THEN RETURN 'Unexpected + X'; END IF;
IF fmt RLIKE 'X[^X]' THEN RETURN 'X + unexpected'; END IF;
-- Bad combinations consisting of three elements
IF fmt RLIKE '[.VD].*[CLU].*[09]' THEN RETURN 'Dec + CLU + digit'; END IF;
IF fmt RLIKE '[CLUV09.BD$].*[S].*([09$BVCLU.D]|EEEE)' THEN RETURN 'Trailing S sign + unexpected'; END IF;
IF fmt RLIKE '[B09].*[CLUV].*[,GV.D]' THEN RETURN 'CLUV as dec + group/dec'; END IF;
IF fmt RLIKE '[.DV].*[CLU].*[B]' THEN RETURN 'CLU as trailing currency + B'; END IF;
RETURN '';
END;
$$
CREATE TABLE t1 (fmt VARCHAR(32));
INSERT INTO t1 VALUES ('');
INSERT INTO t1 VALUES ('FM') /* leading flags */;
INSERT INTO t1 VALUES ('.'),('D'),('V') /* dec */;
INSERT INTO t1 VALUES (','),('G') /* group */;
INSERT INTO t1 VALUES ('$'),('B') /* inline flags */;
INSERT INTO t1 VALUES ('C'),('L'),('U') /* currency */;
INSERT INTO t1 VALUES ('S') /* sign */;
INSERT INTO t1 VALUES ('MI'),('PR') /* trailing sign */;
INSERT INTO t1 VALUES ('TM'),('TM9'),('TME') /* TM formats */;
INSERT INTO t1 VALUES ('0'),('9'),('X') /* digits */;
INSERT INTO t1 VALUES ('EEEE') /* approximate format */;
SELECT fmt FROM t1 WHERE bad(fmt)='' AND to_number('1',fmt) IS NULL;
fmt
SELECT fmt FROM t1 WHERE bad(fmt)<>'' AND to_number('1',fmt) IS NOT NULL;
fmt
CREATE VIEW v2 AS SELECT CONCAT(t1.fmt, t2.fmt) AS fmt FROM t1 t1, t1 t2;
SELECT fmt FROM v2 WHERE bad(fmt)='' AND to_number('1',fmt) IS NULL;
fmt
SELECT fmt FROM v2 WHERE bad(fmt)<>'' AND to_number('1',fmt) IS NOT NULL;
fmt
DROP VIEW v2;
CREATE VIEW v3 AS SELECT CONCAT(t1.fmt, t2.fmt, t2.fmt) AS fmt FROM t1 t1, t1 t2, t1 t3;
SELECT fmt FROM v3 WHERE bad(fmt)='' AND to_number('1',fmt) IS NULL;
fmt
SELECT fmt FROM v3 WHERE bad(fmt)<>'' AND to_number('1',fmt) IS NOT NULL;
fmt
DROP VIEW v3;
DROP TABLE t1;
CREATE TABLE t4 (fmt VARCHAR(32));
INSERT INTO t4 VALUES ('.'),('D'),('V') /* dec */;
INSERT INTO t4 VALUES (','),('G') /* group */;
INSERT INTO t4 VALUES ('$'),('B') /* inline flags */;
INSERT INTO t4 VALUES ('C') /* currency - simplified */;
INSERT INTO t4 VALUES ('0'),('9'),('X') /* digits */;
CREATE VIEW v4 AS
SELECT CONCAT(t1.fmt, t2.fmt, t3.fmt,t4.fmt) AS fmt
FROM t4 t1, t4 t2, t4 t3, t4 t4;
SELECT fmt FROM v4 WHERE bad(fmt)='' AND to_number('1',fmt) IS NULL;
fmt
SELECT fmt FROM v4 WHERE bad(fmt)<>'' AND to_number('1',fmt) IS NOT NULL;
fmt
DROP VIEW v4;
DROP TABLE t4;
CREATE TABLE t4 (fmt VARCHAR(32));
INSERT INTO t4 VALUES ('');
INSERT INTO t4 VALUES ('FM') /* leading flags */;
INSERT INTO t4 VALUES ('.') /* dec - simplified */;
INSERT INTO t4 VALUES (',') /* group - simplified */;
INSERT INTO t4 VALUES ('$'),('B') /* inline flags */;
INSERT INTO t4 VALUES ('C') /* currency - simplified */;
INSERT INTO t4 VALUES ('S') /* sign */;
INSERT INTO t4 VALUES ('MI') /* trailing sign - simplified */;
INSERT INTO t4 VALUES ('TM9') /* TM formats - simplified */;
INSERT INTO t4 VALUES ('9'),('X') /* digits - simplified */;
INSERT INTO t4 VALUES ('EEEE') /* approximate format */;
CREATE VIEW v4 AS
SELECT CONCAT(t1.fmt, t2.fmt, t3.fmt,t4.fmt) AS fmt
FROM t4 t1, t4 t2, t4 t3, t4 t4;
SELECT fmt FROM v4 WHERE bad(fmt)='' AND to_number('1',fmt) IS NULL;
fmt
SELECT fmt FROM v4 WHERE bad(fmt)<>'' AND to_number('1',fmt) IS NOT NULL;
fmt
DROP VIEW v4;
DROP TABLE t4;
DROP FUNCTION bad;
SET debug_dbug= @saved_debug_dbug;

View File

@@ -0,0 +1,139 @@
--source include/have_debug.inc
SET @saved_debug_dbug= @@debug_dbug;
SET @@debug_dbug='+d,numconv_format';
--echo #
--echo # MDEV-20022 sql_mode="oracle" does not support TO_NUMBER() function
--echo #
# This function detects if the passed format is correct or wrong
DELIMITER $$;
CREATE FUNCTION bad(fmt VARCHAR(128)) RETURNS VARCHAR(128)
BEGIN
IF fmt RLIKE '(FM.*FM|B.*B|EEEE.*EEEE|[CLU$].*[CLU$]|[.VD].*[.VD]|(S|MI|PR).*(S|MI|PR))'
THEN
RETURN 'FM/B/currency/dec/sign cannot repeat';
END IF;
IF fmt RLIKE '[09XBCDLUV,G.$].*FM' THEN RETURN 'Unexpected + FM'; END IF;
IF fmt RLIKE '^[^09]*([.DV].*)?EEEE' THEN RETURN 'EEEE with no int digits #1'; END IF;
IF fmt RLIKE '^(FM|S)?[$B]+[CLU][0-9]*EEEE' THEN RETURN 'EEEE with no int digits #2'; END IF;
IF fmt RLIKE '.*EEEE.*(FM|[B09X.DV,GLCU$V])' THEN RETURN 'EEEE + unexpected'; END IF;
IF fmt RLIKE '^([$BC.DLUVS]|FM)EEEE' THEN RETURN '^Unexpected + EEEE immediately'; END IF;
IF fmt RLIKE '(G.*,|,.*G)' THEN RETURN 'comma and G cannot co-exist'; END IF;
IF fmt RLIKE '^([$B]|[^09]|)*[,G]' THEN RETURN 'group with no int digits'; END IF;
IF fmt RLIKE '[.DV].*[,G]' THEN RETURN 'dec + group'; END IF;
IF fmt RLIKE '(FM|[S.DCLUV])[,G]' THEN RETURN 'Unexpected + group immediately'; END IF;
IF fmt RLIKE '(MI|PR).+' THEN RETURN 'Trailing sign + something'; END IF;
IF fmt RLIKE '[$09BVCLUX.D,G].*TM' THEN RETURN 'Unexpected + TM'; END IF;
IF fmt RLIKE 'TM([^E9].*|[E9].+)' THEN RETURN 'TMx + something'; END IF;
IF fmt RLIKE '([9BCDLUVS.,G$]|TM).*X' THEN RETURN 'Unexpected + X'; END IF;
IF fmt RLIKE 'X[^X]' THEN RETURN 'X + unexpected'; END IF;
-- Bad combinations consisting of three elements
IF fmt RLIKE '[.VD].*[CLU].*[09]' THEN RETURN 'Dec + CLU + digit'; END IF;
IF fmt RLIKE '[CLUV09.BD$].*[S].*([09$BVCLU.D]|EEEE)' THEN RETURN 'Trailing S sign + unexpected'; END IF;
IF fmt RLIKE '[B09].*[CLUV].*[,GV.D]' THEN RETURN 'CLUV as dec + group/dec'; END IF;
IF fmt RLIKE '[.DV].*[CLU].*[B]' THEN RETURN 'CLU as trailing currency + B'; END IF;
RETURN '';
END;
$$
DELIMITER ;$$
# Populate t1 with all known format elements
CREATE TABLE t1 (fmt VARCHAR(32));
INSERT INTO t1 VALUES ('');
INSERT INTO t1 VALUES ('FM') /* leading flags */;
INSERT INTO t1 VALUES ('.'),('D'),('V') /* dec */;
INSERT INTO t1 VALUES (','),('G') /* group */;
INSERT INTO t1 VALUES ('$'),('B') /* inline flags */;
INSERT INTO t1 VALUES ('C'),('L'),('U') /* currency */;
INSERT INTO t1 VALUES ('S') /* sign */;
INSERT INTO t1 VALUES ('MI'),('PR') /* trailing sign */;
INSERT INTO t1 VALUES ('TM'),('TM9'),('TME') /* TM formats */;
INSERT INTO t1 VALUES ('0'),('9'),('X') /* digits */;
INSERT INTO t1 VALUES ('EEEE') /* approximate format */;
SELECT fmt FROM t1 WHERE bad(fmt)='' AND to_number('1',fmt) IS NULL;
--disable_warnings
SELECT fmt FROM t1 WHERE bad(fmt)<>'' AND to_number('1',fmt) IS NOT NULL;
--enable_warnings
CREATE VIEW v2 AS SELECT CONCAT(t1.fmt, t2.fmt) AS fmt FROM t1 t1, t1 t2;
SELECT fmt FROM v2 WHERE bad(fmt)='' AND to_number('1',fmt) IS NULL;
--disable_warnings
SELECT fmt FROM v2 WHERE bad(fmt)<>'' AND to_number('1',fmt) IS NOT NULL;
--enable_warnings
DROP VIEW v2;
CREATE VIEW v3 AS SELECT CONCAT(t1.fmt, t2.fmt, t2.fmt) AS fmt FROM t1 t1, t1 t2, t1 t3;
SELECT fmt FROM v3 WHERE bad(fmt)='' AND to_number('1',fmt) IS NULL;
--disable_warnings
SELECT fmt FROM v3 WHERE bad(fmt)<>'' AND to_number('1',fmt) IS NOT NULL;
--enable_warnings
DROP VIEW v3;
DROP TABLE t1;
# Populate t4 only with decimal number body format elements
CREATE TABLE t4 (fmt VARCHAR(32));
INSERT INTO t4 VALUES ('.'),('D'),('V') /* dec */;
INSERT INTO t4 VALUES (','),('G') /* group */;
INSERT INTO t4 VALUES ('$'),('B') /* inline flags */;
INSERT INTO t4 VALUES ('C') /* currency - simplified */;
INSERT INTO t4 VALUES ('0'),('9'),('X') /* digits */;
CREATE VIEW v4 AS
SELECT CONCAT(t1.fmt, t2.fmt, t3.fmt,t4.fmt) AS fmt
FROM t4 t1, t4 t2, t4 t3, t4 t4;
SELECT fmt FROM v4 WHERE bad(fmt)='' AND to_number('1',fmt) IS NULL;
--disable_warnings
SELECT fmt FROM v4 WHERE bad(fmt)<>'' AND to_number('1',fmt) IS NOT NULL;
--enable_warnings
DROP VIEW v4;
DROP TABLE t4;
# Populate t4 only with *some* known format elements, for performance purposes
CREATE TABLE t4 (fmt VARCHAR(32));
INSERT INTO t4 VALUES ('');
INSERT INTO t4 VALUES ('FM') /* leading flags */;
INSERT INTO t4 VALUES ('.') /* dec - simplified */;
INSERT INTO t4 VALUES (',') /* group - simplified */;
INSERT INTO t4 VALUES ('$'),('B') /* inline flags */;
INSERT INTO t4 VALUES ('C') /* currency - simplified */;
INSERT INTO t4 VALUES ('S') /* sign */;
INSERT INTO t4 VALUES ('MI') /* trailing sign - simplified */;
INSERT INTO t4 VALUES ('TM9') /* TM formats - simplified */;
INSERT INTO t4 VALUES ('9'),('X') /* digits - simplified */;
INSERT INTO t4 VALUES ('EEEE') /* approximate format */;
CREATE VIEW v4 AS
SELECT CONCAT(t1.fmt, t2.fmt, t3.fmt,t4.fmt) AS fmt
FROM t4 t1, t4 t2, t4 t3, t4 t4;
SELECT fmt FROM v4 WHERE bad(fmt)='' AND to_number('1',fmt) IS NULL;
--disable_warnings
SELECT fmt FROM v4 WHERE bad(fmt)<>'' AND to_number('1',fmt) IS NOT NULL;
--enable_warnings
DROP VIEW v4;
DROP TABLE t4;
DROP FUNCTION bad;
SET debug_dbug= @saved_debug_dbug;

View File

@@ -0,0 +1,58 @@
#
# MDEV-20022 sql_mode="oracle" does not support TO_NUMBER() function
#
SET NAMES utf8mb4;
SELECT to_number('$123-', CONVERT('$999S' USING ucs2)) AS c1;
c1
-123
SELECT to_number('$123-', CONVERT('$999Š' USING ucs2)) AS c1;
ERROR HY000: Incorrect <number format> value: 'Š' for function to_number
SELECT to_number(CONVERT('$123-' USING ucs2), '$999S') AS c1;
c1
-123
SELECT to_number(CONVERT('$123-' USING ucs2), CONVERT('$999S' USING ucs2)) AS c1;
c1
-123
SELECT to_number(CONVERT('GarbageŠ' USING ucs2), CONVERT('$999S' USING ucs2)) AS c1;
c1
NULL
Warnings:
Warning 1411 Incorrect <number format>='$999S' value: 'GarbageŠ' for function to_number
CREATE TABLE t1 (fmt VARCHAR(32) CHARACTER SET ucs2);
INSERT INTO t1 VALUES ('$999S'), ('$999MI'), ('$999Š');
SELECT fmt, to_number('$123-', fmt) AS c1 FROM t1;
fmt c1
$999S -123
$999MI -123
$999Š NULL
Warnings:
Warning 1411 Incorrect <number format> value: 'Š' for function to_number
SELECT fmt, to_number('GarbageŠ', fmt) AS c1 FROM t1;
fmt c1
$999S NULL
$999MI NULL
$999Š NULL
Warnings:
Warning 1411 Incorrect <number format>='$999S' value: 'GarbageŠ' for function to_number
Warning 1411 Incorrect <number format>='$999MI' value: 'GarbageŠ' for function to_number
Warning 1411 Incorrect <number format> value: 'Š' for function to_number
DROP TABLE t1;
CREATE TABLE t1 (fmt VARCHAR(32) CHARACTER SET ucs2);
INSERT INTO t1 VALUES ('$999S'), ('$999MI'), ('$999Š');
SELECT fmt, to_number(CONVERT('$123-' USING ucs2), fmt) AS c1 FROM t1;
fmt c1
$999S -123
$999MI -123
$999Š NULL
Warnings:
Warning 1411 Incorrect <number format> value: 'Š' for function to_number
SELECT fmt, to_number(CONVERT('GarbageŠ' USING ucs2), fmt) AS c1 FROM t1;
fmt c1
$999S NULL
$999MI NULL
$999Š NULL
Warnings:
Warning 1411 Incorrect <number format>='$999S' value: 'GarbageŠ' for function to_number
Warning 1411 Incorrect <number format>='$999MI' value: 'GarbageŠ' for function to_number
Warning 1411 Incorrect <number format> value: 'Š' for function to_number
DROP TABLE t1;

View File

@@ -0,0 +1,38 @@
--source include/have_ucs2.inc
--echo #
--echo # MDEV-20022 sql_mode="oracle" does not support TO_NUMBER() function
--echo #
SET NAMES utf8mb4;
# Constant UCS2 format
SELECT to_number('$123-', CONVERT('$999S' USING ucs2)) AS c1;
# Make sure the error is readable
--error ER_WRONG_VALUE_FOR_TYPE
SELECT to_number('$123-', CONVERT('$999Š' USING ucs2)) AS c1;
# UCS2 subject + utf8mb4 format
SELECT to_number(CONVERT('$123-' USING ucs2), '$999S') AS c1;
# UCS2 subject + UCS2 format
SELECT to_number(CONVERT('$123-' USING ucs2), CONVERT('$999S' USING ucs2)) AS c1;
# UCS2 subject + UCS2 format - check the warning:
SELECT to_number(CONVERT('GarbageŠ' USING ucs2), CONVERT('$999S' USING ucs2)) AS c1;
# utf8mb4 subject + non-constant UCS2 format
CREATE TABLE t1 (fmt VARCHAR(32) CHARACTER SET ucs2);
INSERT INTO t1 VALUES ('$999S'), ('$999MI'), ('$999Š');
SELECT fmt, to_number('$123-', fmt) AS c1 FROM t1;
SELECT fmt, to_number('GarbageŠ', fmt) AS c1 FROM t1;
DROP TABLE t1;
# UCS2 subject + non-constant UCS2 format
CREATE TABLE t1 (fmt VARCHAR(32) CHARACTER SET ucs2);
INSERT INTO t1 VALUES ('$999S'), ('$999MI'), ('$999Š');
SELECT fmt, to_number(CONVERT('$123-' USING ucs2), fmt) AS c1 FROM t1;
SELECT fmt, to_number(CONVERT('GarbageŠ' USING ucs2), fmt) AS c1 FROM t1;
DROP TABLE t1;

View File

@@ -106,6 +106,7 @@ SET (SQL_SOURCE
hostname.cc init.cc item.cc item_buff.cc item_cmpfunc.cc
item_create.cc item_func.cc item_geofunc.cc item_row.cc
item_strfunc.cc item_subselect.cc item_sum.cc item_timefunc.cc
item_numconvfunc.cc
key.cc log.cc log_cache.cc lock.cc
log_event.cc log_event_server.cc
rpl_record.cc rpl_reporting.cc

View File

@@ -37,6 +37,7 @@
#include "sql_time.h"
#include "sql_type_geom.h"
#include "item_vectorfunc.h"
#include "item_numconvfunc.h"
#include <mysql/plugin_function.h>
@@ -6613,6 +6614,7 @@ const Native_func_registry func_array[] =
{ { STRING_WITH_LEN("TIME_TO_SEC") }, BUILDER(Create_func_time_to_sec)},
{ { STRING_WITH_LEN("TO_BASE64") }, BUILDER(Create_func_to_base64)},
{ { STRING_WITH_LEN("TO_CHAR") }, BUILDER(Create_func_to_char)},
{ { STRING_WITH_LEN("TO_NUMBER") }, &create_func_to_number},
{ { STRING_WITH_LEN("TO_DAYS") }, BUILDER(Create_func_to_days)},
{ { STRING_WITH_LEN("TO_SECONDS") }, BUILDER(Create_func_to_seconds)},
{ { STRING_WITH_LEN("TRUNC") }, BUILDER(Create_func_trunc)},

View File

@@ -744,6 +744,44 @@ public:
};
class Handler_double: public Handler
{
public:
const Type_handler *return_type_handler(const Item_handled_func *)
const override
{
return &type_handler_double;
}
String *val_str(Item_handled_func *item, String *to) const override
{
double nr= val_real(item);
if (item->null_value)
return 0;
to->set_real(nr, NOT_FIXED_DEC, item->collation.collation);
return to;
}
String *val_str_ascii(Item_handled_func *item, String *to) const override
{
return item->Item::val_str_ascii(to);
}
double val_real(Item_handled_func *item) const override= 0;
my_decimal *val_decimal(Item_handled_func *item, my_decimal *to) const override
{
return item->val_decimal_from_real(to);
}
bool get_date(THD *thd, Item_handled_func *item,
MYSQL_TIME *to, date_mode_t fuzzydate) const override
{
return item->get_date_from_real(thd, to, fuzzydate);
}
longlong val_int(Item_handled_func *item) const override
{
return item->val_int_from_real();
}
};
class Handler_int: public Handler
{
public:
@@ -830,6 +868,8 @@ protected:
public:
Item_handled_func(THD *thd)
:Item_func(thd), m_func_handler(NULL) { }
Item_handled_func(THD *thd, List<Item> & args)
:Item_func(thd, args), m_func_handler(NULL) { }
Item_handled_func(THD *thd, Item *a)
:Item_func(thd, a), m_func_handler(NULL) { }
Item_handled_func(THD *thd, Item *a, Item *b)

3391
sql/item_numconvfunc.cc Normal file

File diff suppressed because it is too large Load Diff

25
sql/item_numconvfunc.h Normal file
View File

@@ -0,0 +1,25 @@
#ifndef ITEM_NUMCONVFUNC_INCLUDED
#define ITEM_NUMCONVFUNC_INCLUDED
/*
Copyright (c) 2009, 2025, MariaDB Corporation
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; version 2 of the License.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program; if not, write to the Free Software
Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1335 USA */
#include "item_create.h"
extern Create_func & create_func_to_number;
#endif // ITEM_NUMCONVFUNC_INCLUDED

View File

@@ -293,41 +293,24 @@ private:
// Rules consisting of a single token
class TokenAT: public TOKEN<Parser, TokenID::tAT>
{
public:
using TOKEN::TOKEN;
};
using TokenAT= TokenParser<Parser, TokenID::tAT>;
class TokenEOF: public TOKEN<Parser, TokenID::tEOF>
{
public:
using TOKEN::TOKEN;
};
using TokenEOF= TokenParser<Parser, TokenID::tEOF>;
class Keyword_QB_NAME: public TOKEN<Parser, TokenID::keyword_QB_NAME>
{
public:
using TOKEN::TOKEN;
};
using Keyword_QB_NAME= TokenParser<Parser, TokenID::keyword_QB_NAME>;
class Keyword_MAX_EXECUTION_TIME:
public TOKEN<Parser, TokenID::keyword_MAX_EXECUTION_TIME>
{
public:
using TOKEN::TOKEN;
};
using Keyword_MAX_EXECUTION_TIME=
TokenParser<Parser, TokenID::keyword_MAX_EXECUTION_TIME>;
class Keyword_SUBQUERY: public TOKEN<Parser, TokenID::keyword_SUBQUERY>
{
public:
using TOKEN::TOKEN;
};
using Keyword_SUBQUERY= TokenParser<Parser, TokenID::keyword_SUBQUERY>;
class Identifier: public TOKEN<Parser, TokenID::tIDENT>
class Identifier: public TokenParser<Parser, TokenID::tIDENT>
{
public:
using TOKEN::TOKEN;
using TokenParser::TokenParser;
Identifier(Token &&tok)
:TokenParser(std::move(tok))
{ }
Lex_ident_cli_st to_ident_cli() const
{
Lex_ident_cli_st cli;
@@ -342,10 +325,10 @@ private:
}
};
class Unsigned_Number: public TOKEN<Parser, TokenID::tUNSIGNED_NUMBER>
class Unsigned_Number: public TokenParser<Parser, TokenID::tUNSIGNED_NUMBER>
{
public:
using TOKEN::TOKEN;
using TokenParser::TokenParser;
/*
Converts token string to a non-negative number ( >=0 ).
@@ -364,17 +347,9 @@ private:
}
};
class LParen: public TOKEN<Parser, TokenID::tLPAREN>
{
public:
using TOKEN::TOKEN;
};
using LParen= TokenParser<Parser, TokenID::tLPAREN>;
class RParen: public TOKEN<Parser, TokenID::tRPAREN>
{
public:
using TOKEN::TOKEN;
};
using RParen= TokenParser<Parser, TokenID::tRPAREN>;
// Rules consisting of multiple choices of tokens

File diff suppressed because it is too large Load Diff

View File

@@ -239,6 +239,11 @@ public:
m_cs(cs)
{ }
CHARSET_INFO *charset() const
{
return m_cs;
}
// Skip all leading spaces
void get_spaces()
{

View File

@@ -963,10 +963,21 @@ class Double_null: public Null_flag
protected:
double m_value;
public:
Double_null()
:Null_flag(true), m_value(0)
{ }
Double_null(double value, bool is_null)
:Null_flag(is_null), m_value(value)
{ }
Double_null(double value)
:Null_flag(false), m_value(value)
{ }
double value() const { return m_value; }
Double_null operator-() const
{
DBUG_ASSERT(!is_null());
return Double_null(-m_value);
}
};