database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2026-01-06 05:22:24 +03:00
Code Activity

some ammendments (comments and code style)

Browse Source 
mysql-test/t/func_str.test:
  add skipped new line
sql/item_strfunc.cc:
  rewrote some comments for Item_func_elt
This commit is contained in:
unknown
2004-01-22 20:20:43 +04:00
parent 24ca1e1edb
commit 8b03b319f5
2 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
mysql-test/t/func_str.test
View File

@@ -162,4 +162,4 @@ DROP TABLE t1;
CREATE TABLE t1 (i int, j int);
INSERT INTO t1 VALUES (1,1),(2,2);
SELECT DISTINCT i, ELT(j, '345', '34') FROM t1;
DROP TABLE t1;
DROP TABLE t1;

9
sql/item_strfunc.cc
View File

@@ -1507,7 +1507,14 @@ void Item_func_elt::fix_length_and_dec()
{
max_length=0;
decimals=0;
for (uint i= 0; i < arg_count ; i++) // first number argument isn't in list!
/*
first numeric argument isn't in args (3.23 and 4.0)
but since 4.1 the cycle should start from 1
so this change
should NOT be merged into 4.1!!!
*/
for (uint i= 0; i < arg_count ; i++)
{
set_if_bigger(max_length,args[i]->max_length);
set_if_bigger(decimals,args[i]->decimals);