database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-12-24 11:21:21 +03:00
Code Activity

Fix for bug #23653: Crash if last_day('0000-00-00')

Browse Source 
As get_arg0_date() in the Item_func_last_day::get_date() returns 
0000-00-00 date sometimes, we have to check ltime->month for 0 after the call.
This commit is contained in:
ramil/ram@mysql.com/myoffice.izhnet.ru
2006-11-09 16:17:50 +04:00
parent c2aca91b7f
commit 4b823e045f
3 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
mysql-test/r/func_time.result
View File

@@ -815,4 +815,7 @@ union
(select time_format(timediff(now(), DATE_SUB(now(),INTERVAL 5 HOUR)),'%k') As H);
H
5
select last_day('0000-00-00');
last_day('0000-00-00')
NULL
End of 4.1 tests

6
mysql-test/t/func_time.test
View File

@@ -446,4 +446,10 @@ union
union
(select time_format(timediff(now(), DATE_SUB(now(),INTERVAL 5 HOUR)),'%k') As H);
#
# Bug #23653: crash if last_day('0000-00-00')
#
select last_day('0000-00-00');
--echo End of 4.1 tests

3
sql/item_timefunc.cc
View File

@@ -3058,7 +3058,8 @@ String *Item_func_str_to_date::val_str(String *str)
bool Item_func_last_day::get_date(TIME *ltime, uint fuzzy_date)
{
if (get_arg0_date(ltime, fuzzy_date & ~TIME_FUZZY_DATE))
if (get_arg0_date(ltime, fuzzy_date & ~TIME_FUZZY_DATE) ||
(ltime->month == 0))
return 1;
uint month_idx= ltime->month-1;
ltime->day= days_in_month[month_idx];