database/mariadb-columnstore-engine
1
0
Fork 0
mirror of https://github.com/mariadb-corporation/mariadb-columnstore-engine.git synced 2025-12-24 14:20:59 +03:00
Code Activity

Merge pull request #2009 from mariadb-AlexeyAntipovsky/fix-diskagg-ub-dev

Browse Source 
[MCOL-4709] Fix UB in disk aggregation
This commit is contained in:
David.Hall
2021-06-28 12:17:55 -05:00
committed by GitHub
parent 132146b9c8 8a0b68f25e
commit dd12bd3cd0
1 changed files with 13 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
utils/rowgroup/rowstorage.cpp
View File

@@ -660,6 +660,19 @@ public:
fLRU->clear();
fMM->release();
fRGDatas.clear();
// we need at least one RGData so create it right now
auto* curRG = new RGData(*fRowGroupOut, fMaxRows);
fRowGroupOut->setData(curRG);
fRowGroupOut->resetRowGroup(0);
fRGDatas.emplace_back(curRG);
auto memSz = fRowGroupOut->getSizeWithStrings(fMaxRows);
if (!fMM->acquire(memSz))
{
throw logging::IDBExcept(logging::IDBErrorInfo::instance()->errorMsg(
logging::ERR_AGGREGATION_TOO_BIG),
logging::ERR_AGGREGATION_TOO_BIG);
}
++fGeneration;
}