1
0
mirror of https://github.com/mariadb-corporation/mariadb-columnstore-engine.git synced 2025-08-05 16:15:50 +03:00

New warnfixes (#2254)

* Fix clang warnings

* Remove vim tab guides

* initialize variables

* 'strncpy' output truncated before terminating nul copying as many bytes from a string as its length

* Fix ISO C++17 does not allow 'register' storage class specifier for outdated bison

* chars are unsigned on ARM, having  if (ival < 0) always false

* chars are unsigned by default on ARM and comparison with -1 if always true
This commit is contained in:
Leonid Fedorov
2022-02-17 13:08:58 +03:00
committed by GitHub
parent 15a87ee510
commit 3919c541ac
325 changed files with 20 additions and 353 deletions

View File

@@ -1056,10 +1056,10 @@ bool copytask(bool connectionTest = false)
copy_cmd* cmd = (copy_cmd*)buf;
cmd->opcode = COPY;
cmd->file1.flen = strlen(source);
strncpy(cmd->file1.filename, source, cmd->file1.flen);
memcpy(cmd->file1.filename, source, cmd->file1.flen);
f_name* file2 = (f_name*)&cmd->file1.filename[cmd->file1.flen];
file2->flen = strlen(dest);
strncpy(file2->filename, dest, file2->flen);
memcpy(file2->filename, dest, file2->flen);
uint len = (uint64_t)&file2->filename[file2->flen] - (uint64_t)buf;