New warnfixes (#2254)

* Fix clang warnings

* Remove vim tab guides

* initialize variables

* 'strncpy' output truncated before terminating nul copying as many bytes from a string as its length

* Fix ISO C++17 does not allow 'register' storage class specifier for outdated bison

* chars are unsigned on ARM, having  if (ival < 0) always false

* chars are unsigned by default on ARM and comparison with -1 if always true

CMakeLists.txt

@@ -223,7 +223,7 @@ IF (MASK_LONGDOUBLE)
 ENDIF()
 
 
-SET (CMAKE_REQUIRED_FLAGS "-Werror -Wall")
+MY_CHECK_AND_SET_COMPILER_FLAG("-Werror -Wall")
 SET (ENGINE_LDFLAGS    "-Wl,--no-as-needed -Wl,--add-needed")
 SET (ENGINE_DT_LIB datatypes)
 SET (ENGINE_COMMON_LIBS     messageqcpp loggingcpp configcpp idbboot ${Boost_LIBRARIES} xml2 pthread rt libmysql_client ${ENGINE_DT_LIB})

datatypes/mcs_datatype.cpp

@@ -1915,4 +1915,3 @@ const uint8_t* TypeHandlerUDecimal128::getEmptyValueForType(
 
 }  // end of namespace datatypes
 
-// vim:ts=2 sw=2:

datatypes/mcs_datatype.h

@@ -2521,4 +2521,3 @@ class TypeHandlerTimestamp : public TypeHandlerTemporal
 
 }  // end of namespace datatypes
 
-// vim:ts=2 sw=2:

datatypes/mcs_datatype_basic.h

@@ -78,4 +78,3 @@ uint64_t xFloatToMCSUInt64Round(SRC value)
 
 }  // end of namespace datatypes
 
-// vim:ts=2 sw=2:

datatypes/mcs_double.h

@@ -54,4 +54,3 @@ class TDouble
 
 }  // end of namespace datatypes
 
-// vim:ts=2 sw=2:

datatypes/mcs_float128.h

@@ -724,4 +724,3 @@ class TFloat128
 
 }  // namespace datatypes
 
-// vim:ts=2 sw=2:

datatypes/mcs_int128.cpp

@@ -113,4 +113,3 @@ std::ostream& operator<<(std::ostream& os, const TSInt128& x)
 }
 
 }  // end of namespace datatypes
-// vim:ts=2 sw=2:

datatypes/mcs_int128.h

@@ -322,4 +322,3 @@ class TSInt128
 
 }  // end of namespace datatypes
 
-// vim:ts=2 sw=2:

datatypes/mcs_int64.h

@@ -179,4 +179,3 @@ class TSInt64Null : public TSInt64, public TNullFlag
 
 }  // end of namespace datatypes
 
-// vim:ts=2 sw=2:

datatypes/mcs_longdouble.h

@@ -54,4 +54,3 @@ class TLongDouble
 
 }  // end of namespace datatypes
 
-// vim:ts=2 sw=2:

dbcon/ddlpackage/CMakeLists.txt

@@ -9,7 +9,7 @@ FIND_PACKAGE(FLEX REQUIRED)
 FLEX_TARGET(ddl_scan ddl.l ${CMAKE_CURRENT_BINARY_DIR}/ddl-scan.cpp COMPILE_FLAGS "-i -L -Pddl")
 ADD_FLEX_BISON_DEPENDENCY(ddl_scan ddl_gram)
 
-set_source_files_properties(ddl-scan.cpp PROPERTIES COMPILE_FLAGS "-Wno-sign-compare -DYY_NO_INPUT")
+set_source_files_properties(ddl-scan.cpp PROPERTIES COMPILE_FLAGS "-Wno-register -Wno-deprecated-register -Wno-sign-compare -DYY_NO_INPUT")
 
 ########### next target ###############
 

dbcon/ddlpackageproc/altertableprocessor.cpp

@@ -2539,7 +2539,6 @@ void AlterTableProcessor::renameColumn(uint32_t sessionID, execplan::CalpontSyst
 }
 
 }  // namespace ddlpackageprocessor
-// vim:ts=4 sw=4:
 
 #ifdef __clang__
 #pragma clang diagnostic pop

dbcon/ddlpackageproc/createtableprocessor.cpp

@@ -830,4 +830,3 @@ void CreateTableProcessor::rollBackCreateTable(const string& error, BRM::TxnID t
 }
 
 }  // namespace ddlpackageprocessor
-// vim:ts=4 sw=4:

dbcon/ddlpackageproc/ddlpackageprocessor.cpp

@@ -1491,4 +1491,3 @@ int DDLPackageProcessor::commitTransaction(uint64_t uniqueId, BRM::TxnID txnID)
 }
 
 }  // namespace ddlpackageprocessor
-// vim:ts=4 sw=4:

dbcon/ddlpackageproc/ddlpackageprocessor.h

@@ -890,4 +890,3 @@ bool from_string(T& t, const std::string& s, std::ios_base& (*f)(std::ios_base&)
 
 #undef EXPORT
 
-// vim:ts=4 sw=4:

dbcon/ddlpackageproc/droptableprocessor.cpp

@@ -1367,4 +1367,3 @@ TruncTableProcessor::DDLResult TruncTableProcessor::processPackage(
 
 }  // namespace ddlpackageprocessor
 
-// vim:ts=4 sw=4:

dbcon/dmlpackage/CMakeLists.txt

@@ -10,7 +10,7 @@ FIND_PACKAGE(FLEX REQUIRED)
 FLEX_TARGET(dml_scan dml.l ${CMAKE_CURRENT_BINARY_DIR}/dml-scan.cpp COMPILE_FLAGS "-i -L -Pdml")
 ADD_FLEX_BISON_DEPENDENCY(dml_scan dml_gram)
 
-set_source_files_properties(dml-scan.cpp PROPERTIES COMPILE_FLAGS "-Wno-sign-compare -DYY_NO_INPUT")
+set_source_files_properties(dml-scan.cpp PROPERTIES COMPILE_FLAGS "-Wno-register -Wno-deprecated-register -Wno-sign-compare -DYY_NO_INPUT")
 
 ########### next target ###############
 

dbcon/dmlpackageproc/autoincrementdata.cpp

@@ -97,4 +97,3 @@ AutoincrementData::OIDNextValue& AutoincrementData::getOidNextValueMap()
 
   return fOidNextValueMap;
 }
-// vim:ts=4 sw=4:

dbcon/dmlpackageproc/autoincrementdata.h

@@ -49,4 +49,3 @@ class AutoincrementData
   boost::mutex fOIDnextvalLock;
 };
 
-// vim:ts=4 sw=4:

dbcon/dmlpackageproc/dmlpackageprocessor.cpp

@@ -913,4 +913,3 @@ int DMLPackageProcessor::endTransaction(uint64_t uniqueId, BRM::TxnID txnID, boo
   return rc;
 }
 }  // namespace dmlpackageprocessor
-// vim:ts=4 sw=4:

dbcon/dmlpackageproc/insertpackageprocessor.cpp

@@ -432,4 +432,3 @@ DMLPackageProcessor::DMLResult InsertPackageProcessor::processPackage(dmlpackage
 
 }  // namespace dmlpackageprocessor
 
-// vim:ts=4 sw=4:

dbcon/dmlpackageproc/tablelockdata.cpp

@@ -101,4 +101,3 @@ TablelockData::OIDTablelock& TablelockData::getOidTablelockMap()
 }
 
 }  // namespace dmlpackageprocessor
-// vim:ts=4 sw=4:

dbcon/dmlpackageproc/tablelockdata.h

@@ -61,4 +61,3 @@ class TablelockData
 
 #undef EXPORT
 
-// vim:ts=4 sw=4:

dbcon/execplan/calpontselectexecutionplan.h

@@ -939,4 +939,3 @@ inline std::ostream& operator<<(std::ostream& os, const CalpontSelectExecutionPl
 }
 
 }  // namespace execplan
-// vim:ts=4 sw=4:

dbcon/execplan/calpontsystemcatalog.h

@@ -1279,4 +1279,3 @@ bool ctListSort(const CalpontSystemCatalog::ColType& a, const CalpontSystemCatal
 
 }  // namespace execplan
 
-// vim:ts=4 sw=4:

dbcon/execplan/clientrotator.cpp

@@ -399,4 +399,3 @@ void ClientRotator::writeToLog(int line, const string& msg, bool critical) const
 }
 
 }  // namespace execplan
-// vim:ts=4 sw=4:

dbcon/execplan/clientrotator.h

@@ -166,4 +166,3 @@ class ClientRotator
 };
 
 }  // namespace execplan
-// vim:ts=4 sw=4:

dbcon/execplan/constantcolumn.cpp

@@ -347,4 +347,3 @@ bool ConstantColumn::operator!=(const TreeNode* t) const
 }
 
 }  // namespace execplan
-// vim:ts=4 sw=4:

dbcon/execplan/constantfilter.cpp

@@ -308,4 +308,3 @@ void ConstantFilter::setSimpleColumnList()
 }
 
 }  // namespace execplan
-// vim:ts=4 sw=4:

dbcon/execplan/sessionmanager.h

@@ -213,4 +213,3 @@ class SessionManager
 
 }  // namespace execplan
 
-// vim:ts=4 sw=4:

dbcon/joblist/anydatalist.cpp

@@ -170,4 +170,3 @@ std::ostream& omitOidInDL(std::ostream& strm)
 }
 
 }  // namespace joblist
-// vim:ts=4 sw=4:

dbcon/joblist/batchprimitiveprocessor-jl.h

@@ -366,4 +366,3 @@ class BatchPrimitiveProcessorJL
 
 }  // namespace joblist
 
-// vim:ts=4 sw=4:

dbcon/joblist/columncommand-jl.h

@@ -129,4 +129,3 @@ class ColumnCommandJL : public CommandJL
 
 }  // namespace joblist
 
-// vim:ts=4 sw=4:

dbcon/joblist/crossenginestep.cpp

@@ -828,4 +828,3 @@ void CrossEngineStep::formatMiniStats()
 }
 
 }  // namespace joblist
-// vim:ts=4 sw=4:

dbcon/joblist/crossenginestep.h

@@ -249,4 +249,3 @@ class CrossEngineStep : public BatchPrimitive, public TupleDeliveryStep
 
 }  // namespace joblist
 
-// vim:ts=4 sw=4:

dbcon/joblist/diskjoinstep.cpp

@@ -163,7 +163,7 @@ void DiskJoinStep::smallReader()
   RGData rgData;
   bool more = true;
   int64_t memUsage = 0, combinedMemUsage = 0;
-  int rowCount = 0;
+  [[maybe_unused]] int rowCount = 0;
   RowGroup l_smallRG = smallRG;
 
   try
@@ -224,7 +224,7 @@ void DiskJoinStep::largeReader()
   RGData rgData;
   bool more = true;
   int64_t largeSize = 0;
-  int rowCount = 0;
+  [[maybe_unused]] int rowCount = 0;
   RowGroup l_largeRG = largeRG;
 
   largeIterationCount++;

dbcon/joblist/distributedenginecomm.cpp

@@ -1146,4 +1146,3 @@ uint32_t DistributedEngineComm::MQE::getNextConnectionId(const size_t pmIndex,
 }
 
 }  // namespace joblist
-// vim:ts=4 sw=4:

dbcon/joblist/elementtype.h

@@ -638,4 +638,3 @@ extern std::ostream& omitOidInDL(std::ostream& strm);
 
 #endif
 
-// vim:ts=4 sw=4:

dbcon/joblist/errorinfo.h

@@ -52,4 +52,3 @@ typedef boost::shared_ptr<ErrorInfo> SErrorInfo;
 
 }  // namespace joblist
 
-// vim:ts=4 sw=4:

dbcon/joblist/expressionstep.cpp

@@ -790,4 +790,3 @@ const string ExpressionStep::toString() const
 }
 
 }  // namespace joblist
-// vim:ts=4 sw=4:

dbcon/joblist/fifo.h

@@ -529,4 +529,3 @@ void FIFO<element_t>::totalFileCounts(uint64_t& numFiles, uint64_t& numBytes) co
 
 }  // namespace joblist
 
-// vim:ts=4 sw=4:

dbcon/joblist/groupconcat.cpp

@@ -1051,4 +1051,3 @@ const string GroupConcatNoOrder::toString() const
 }
 
 }  // namespace joblist
-// vim:ts=4 sw=4:

dbcon/joblist/jlf_common.cpp

@@ -822,4 +822,3 @@ bool compatibleColumnTypes(const CalpontSystemCatalog::ColDataType& dt1, uint32_
 }
 
 }  // namespace joblist
-// vim:ts=4 sw=4:

dbcon/joblist/jlf_execplantojoblist.cpp

@@ -3446,7 +3446,6 @@ void JLF_ExecPlanToJobList::addJobSteps(JobStepVector& nsv, JobInfo& jobInfo, bo
 }
 
 }  // namespace joblist
-// vim:ts=4 sw=4:
 
 #ifdef __clang__
 #pragma clang diagnostic pop

dbcon/joblist/jlf_graphics.cpp

@@ -418,7 +418,6 @@ ostream& writeDotCmds(ostream& dotFile, const JobStepVector& query, const JobSte
 
 }  // end namespace jlf_graphics
 
-// vim:ts=4 sw=4 syntax=cpp:
 
 #ifdef __clang__
 #pragma clang diagnostic pop

dbcon/joblist/jlf_subquery.cpp

@@ -875,4 +875,3 @@ SJSTEP doUnionSub(CalpontExecutionPlan* ep, JobInfo& jobInfo)
 }
 
 }  // namespace joblist
-// vim:ts=4 sw=4:

dbcon/joblist/jlf_tuplejoblist.cpp

@@ -4559,7 +4559,6 @@ SJSTEP unionQueries(JobStepVector& queries, uint64_t distinctUnionNum, JobInfo&
 }
 
 }  // namespace joblist
-// vim:ts=4 sw=4:
 
 #ifdef __clang__
 #pragma clang diagnostic pop

dbcon/joblist/joblist.cpp

@@ -1233,4 +1233,3 @@ void TupleJobList::abort()
 #pragma clang diagnostic pop
 #endif
 
-// vim:ts=4 sw=4:

dbcon/joblist/joblist.h

@@ -260,4 +260,3 @@ typedef boost::shared_ptr<TupleJobList> STJLP;
 
 #undef EXPORT
 
-// vim:ts=4 sw=4:

dbcon/joblist/joblistfactory.cpp

@@ -2316,7 +2316,6 @@ SJLP JobListFactory::makeJobList(CalpontExecutionPlan* cplan, ResourceManager* r
 }
 
 }  // namespace joblist
-// vim:ts=4 sw=4:
 
 #ifdef __clang__
 #pragma clang diagnostic pop

dbcon/joblist/jobstep.cpp

@@ -244,4 +244,3 @@ void JobStep::handleException(std::exception_ptr e, const int errorCode, const u
 }
 
 }  // namespace joblist
-// vim:ts=4 sw=4:

dbcon/joblist/jobstep.h

@@ -566,4 +566,3 @@ typedef boost::shared_ptr<JobStep> SJSTEP;
 
 }  // namespace joblist
 
-// vim:ts=4 sw=4:

dbcon/joblist/lbidlist.cpp

@@ -920,4 +920,3 @@ template bool LBIDList::checkRangeOverlap<int64_t>(int64_t min, int64_t max, int
 
 }  // namespace joblist
 
-// vim:ts=4 sw=4:

dbcon/joblist/limitedorderby.cpp

@@ -303,4 +303,3 @@ const string LimitedOrderBy::toString() const
 }
 
 }  // namespace joblist
-// vim:ts=4 sw=4:

dbcon/joblist/passthrucommand-jl.cpp

@@ -110,4 +110,3 @@ uint16_t PassThruCommandJL::getWidth()
 }
 
 };  // namespace joblist
-// vim:ts=4 sw=4:

dbcon/joblist/pcolscan.cpp

@@ -1224,4 +1224,3 @@ void pColScanStep::appendFilter(const std::vector<const execplan::Filter*>& fs)
 }
 
 }  // namespace joblist
-// vim:ts=4 sw=4:

dbcon/joblist/pcolstep.cpp

@@ -1511,4 +1511,3 @@ void pColStep::appendFilter(const std::vector<const execplan::Filter*>& fs)
 }
 
 }  // namespace joblist
-// vim:ts=4 sw=4:

dbcon/joblist/pdictionaryscan.cpp

@@ -916,4 +916,3 @@ void pDictionaryScan::abort()
 }
 
 }  // namespace joblist
-// vim:ts=4 sw=4:

dbcon/joblist/primitivemsg.h

@@ -884,4 +884,3 @@ struct LbidAtVer
 
 #pragma pack(pop)
 
-// vim:ts=4 sw=4:

dbcon/joblist/primitivestep.h

@@ -1835,4 +1835,3 @@ class PseudoColStep : public pColStep
 
 }  // namespace joblist
 
-// vim:ts=4 sw=4:

dbcon/joblist/rowestimator.cpp

@@ -269,8 +269,8 @@ float RowEstimator::estimateRowReturnFactor(const BRM::EMEntry& emEntry, const m
   float tempFactor = 1.0;
 
   uint64_t adjustedMin = 0, adjustedMax = 0;
-  uint128_t adjustedBigMin, adjustedBigMax;
-  uint32_t distinctValuesEstimate;
+  uint128_t adjustedBigMin = 0, adjustedBigMax = 0;
+  uint32_t distinctValuesEstimate = 0;
 
   // Adjust values based on column type and estimate the
   if (!ct.isWideDecimalType())

dbcon/joblist/subquerystep.cpp

@@ -533,4 +533,3 @@ void SubAdapterStep::formatMiniStats()
 }
 
 }  // namespace joblist
-// vim:ts=4 sw=4:

dbcon/joblist/subquerystep.h

@@ -273,4 +273,3 @@ class SubAdapterStep : public JobStep, public TupleDeliveryStep
 
 }  // namespace joblist
 
-// vim:ts=4 sw=4:

dbcon/joblist/subquerytransformer.cpp

@@ -622,4 +622,3 @@ void SimpleScalarTransformer::getScalarResult()
 }
 
 }  // namespace joblist
-// vim:ts=4 sw=4:

dbcon/joblist/subquerytransformer.h

@@ -223,4 +223,3 @@ class SimpleScalarTransformer : public SubQueryTransformer
 
 }  // namespace joblist
 
-// vim:ts=4 sw=4:

dbcon/joblist/tuple-bps.cpp

@@ -3356,4 +3356,3 @@ template bool TupleBPS::compareSingleValue<int64_t>(uint8_t COP, int64_t val1, i
 template bool TupleBPS::compareSingleValue<int128_t>(uint8_t COP, int128_t val1, int128_t val2) const;
 
 }  // namespace joblist
-// vim:ts=4 sw=4:

dbcon/joblist/tupleaggregatestep.cpp

@@ -5962,4 +5962,3 @@ void TupleAggregateStep::formatMiniStats()
 }
 
 }  // namespace joblist
-// vim:ts=4 sw=4:

dbcon/joblist/tupleaggregatestep.h

@@ -224,4 +224,3 @@ class TupleAggregateStep : public JobStep, public TupleDeliveryStep
 
 }  // namespace joblist
 
-// vim:ts=4 sw=4:

dbcon/joblist/tupleannexstep.cpp

@@ -1258,4 +1258,3 @@ void TupleAnnexStep::formatMiniStats()
 }
 
 }  // namespace joblist
-// vim:ts=4 sw=4:

dbcon/joblist/tupleannexstep.h

@@ -193,4 +193,3 @@ class reservablePQ : private std::priority_queue<T>
 
 }  // namespace joblist
 
-// vim:ts=4 sw=4:

dbcon/joblist/tupleconstantstep.cpp

@@ -842,4 +842,3 @@ const string TupleConstantBooleanStep::toString() const
 }
 
 }  // namespace joblist
-// vim:ts=4 sw=4:

dbcon/joblist/tupleconstantstep.h

@@ -189,4 +189,3 @@ class TupleConstantBooleanStep : public TupleConstantStep
 
 }  // namespace joblist
 
-// vim:ts=4 sw=4:

dbcon/joblist/tuplehashjoin.cpp

@@ -1997,4 +1997,3 @@ void TupleHashJoinStep::abort()
 }
 
 }  // namespace joblist
-// vim:ts=4 sw=4:

dbcon/joblist/tuplehashjoin.h

@@ -633,4 +633,3 @@ class TupleHashJoinStep : public JobStep, public TupleDeliveryStep
 
 }  // namespace joblist
 
-// vim:ts=4 sw=4:

dbcon/joblist/tuplehavingstep.cpp

@@ -408,4 +408,3 @@ void TupleHavingStep::formatMiniStats()
 }
 
 }  // namespace joblist
-// vim:ts=4 sw=4:

dbcon/joblist/tuplehavingstep.h

@@ -115,4 +115,3 @@ class TupleHavingStep : public ExpressionStep, public TupleDeliveryStep
 
 }  // namespace joblist
 
-// vim:ts=4 sw=4:

dbcon/joblist/virtualtable.cpp

@@ -158,4 +158,3 @@ const CalpontSystemCatalog::ColType& VirtualTable::columnType(uint32_t i) const
 }
 
 }  // namespace joblist
-// vim:ts=4 sw=4:

dbcon/joblist/windowfunctionstep.cpp

@@ -1597,4 +1597,3 @@ void WindowFunctionStep::formatMiniStats()
 }
 
 }  // namespace joblist
-// vim:ts=4 sw=4:

dbcon/joblist/windowfunctionstep.h

@@ -225,4 +225,3 @@ class WindowFunctionStep : public JobStep, public TupleDeliveryStep
 
 }  // namespace joblist
 
-// vim:ts=4 sw=4:

dbcon/mysql/ha_autoi.cpp

@@ -176,4 +176,3 @@ bool parseAutoincrementColumnComment(std::string comment, uint64_t& startValue)
   return autoincrement;
 }
 
-// vim:ts=4 sw=4:

dbcon/mysql/ha_mcs_datatype.h

@@ -841,4 +841,3 @@ class WriteBatchFieldMariaDB : public WriteBatchField
 
 }  // end of namespace datatypes
 
-// vim:ts=2 sw=2:

dbcon/mysql/ha_mcs_ddl.cpp

@@ -2807,4 +2807,3 @@ extern "C"
   }
 }
 
-// vim:ts=4 sw=4:

dbcon/mysql/ha_mcs_dml.cpp

@@ -1001,4 +1001,3 @@ int ha_mcs_impl_close_connection_(handlerton* hton, THD* thd, cal_connection_inf
   return rc;
 }
 
-// vim:ts=4 sw=4:

dbcon/mysql/ha_mcs_execplan.cpp

@@ -10459,4 +10459,3 @@ int getGroupPlan(gp_walk_info& gwi, SELECT_LEX& select_lex, SCSEP& csep, cal_gro
 }
 
 }  // namespace cal_impl_if
-// vim:ts=4 sw=4:

dbcon/mysql/ha_pseudocolumn.cpp

@@ -579,4 +579,3 @@ execplan::ReturnedColumn* buildPseudoColumn(Item* item, gp_walk_info& gwi, bool&
 }
 
 }  // namespace cal_impl_if
-// vim:ts=4 sw=4:

dbcon/mysql/idb_mysql.h

@@ -118,4 +118,3 @@ inline char* idb_mysql_query_str(THD* thd)
 }
 }  // namespace
 
-// vim:ts=4 sw=4:

ddlproc/ddlproc.cpp

@@ -248,4 +248,3 @@ int main(int argc, char** argv)
 
   return ServiceDDLProc(opt).Run();
 }
-// vim:ts=4 sw=4:

ddlproc/ddlprocessor.cpp

@@ -876,4 +876,3 @@ int DDLProcessor::commitTransaction(uint32_t txnID, std::string& errorMsg)
   return rc;
 }
 }  // namespace ddlprocessor
-// vim:ts=4 sw=4:

dmlproc/batchinsertprocessor.cpp

@@ -547,4 +547,3 @@ void BatchInsertProc::getError(int& errorCode, std::string& errMsg)
   errMsg = fErrMsg;
 }
 }  // namespace dmlprocessor
-// vim:ts=4 sw=4:

dmlproc/batchinsertprocessor.h

@@ -93,4 +93,3 @@ class BatchInsertProc
 };
 
 }  // namespace dmlprocessor
-// vim:ts=4 sw=4:

dmlproc/dmlproc.cpp

@@ -639,14 +639,7 @@ int ServiceDMLProc::Child()
 
     // Couldn't check the return code b/c
     // fuser returns 1 for unused port.
-#if defined(__GNUC__) && __GNUC__ >= 5
-#pragma GCC diagnostic push
-#pragma GCC diagnostic ignored "-Wunused-result"
-    (void)::system(cmd.c_str());
-#pragma GCC diagnostic pop
-#else
-    (void)::system(cmd.c_str());
-#endif
+    std::ignore = ::system(cmd.c_str());
   }
   catch (...)
   {
@@ -698,4 +691,3 @@ int main(int argc, char** argv)
   return ServiceDMLProc(opt).Run();
 }
 
-// vim:ts=4 sw=4:

dmlproc/dmlprocessor.cpp

@@ -2001,4 +2001,3 @@ void DMLProcessor::log(const std::string& msg, logging::LOG_TYPE level)
 }
 
 }  // namespace dmlprocessor
-// vim:ts=4 sw=4:

dmlproc/dmlprocessor.h

@@ -330,4 +330,3 @@ class RollbackTransactionProcessor : public dmlpackageprocessor::DMLPackageProce
 
 }  // namespace dmlprocessor
 
-// vim:ts=4 sw=4:

exemgr/activestatementcounter.cpp

@@ -57,4 +57,3 @@ void ActiveStatementCounter::decr(bool& counted)
   --fStatementCount;
   condvar.notify_one();
 }
-// vim:ts=4 sw=4:

exemgr/activestatementcounter.h

@@ -62,4 +62,3 @@ class ActiveStatementCounter
   BRM::VSS fVss;
 };
 
-// vim:ts=4 sw=4:

exemgr/main.cpp

@@ -1825,4 +1825,3 @@ int main(int argc, char* argv[])
   return ServiceExeMgr(opt).Run();
 }
 
-// vim:ts=4 sw=4:

oam/oamcpp/liboamcpp.cpp

@@ -1066,4 +1066,3 @@ std::string Oam::itoa(const int i)
   return ss.str();
 }
 }  // namespace oam
-// vim:ts=4 sw=4:

oam/oamcpp/liboamcpp.h

@@ -433,4 +433,3 @@ class Oam
 
 #undef EXPORT
 
-// vim:ts=4 sw=4:

oamapps/columnstoreDB/columnstoreDB.cpp

@@ -271,7 +271,7 @@ int main(int argc, char** argv)
   Oam oam;
   BRM::DBRM dbrm;
 
-  char c;
+  signed char c;
 
   // Invokes member function `int operator ()(void);'
   while ((c = getopt(argc, argv, "c:h")) != -1)

oamapps/postConfigure/mycnfUpgrade.cpp

@@ -284,4 +284,3 @@ int main(int argc, char* argv[])
 
   exit(0);
 }
-// vim:ts=4 sw=4: