New warnfixes (#2254)

* Fix clang warnings

* Remove vim tab guides

* initialize variables

* 'strncpy' output truncated before terminating nul copying as many bytes from a string as its length

* Fix ISO C++17 does not allow 'register' storage class specifier for outdated bison

* chars are unsigned on ARM, having  if (ival < 0) always false

* chars are unsigned by default on ARM and comparison with -1 if always true

primitives/blockcache/blockcacheclient.h

@@ -176,4 +176,3 @@ class blockCacheClient
 
 }  // namespace dbbc
 
-// vim:ts=4 sw=4:

primitives/blockcache/blockrequestprocessor.h

@@ -190,4 +190,3 @@ class BlockRequestProcessor
 };
 
 }  // namespace dbbc
-// vim:ts=4 sw=4:

primitives/blockcache/filerequest.h

@@ -320,4 +320,3 @@ class fileRequest
 
 }  // namespace dbbc
 
-// vim:ts=4 sw=4:

primitives/blockcache/iomanager.cpp

@@ -1440,4 +1440,3 @@ void ioManager::handleBlockReadError(fileRequest* fr, const string& errMsg, bool
 }
 
 }  // namespace dbbc
-// vim:ts=4 sw=4:

primitives/blockcache/iomanager.h

@@ -147,4 +147,3 @@ void dropFDCache();
 void purgeFDCache(std::vector<BRM::FileInfo>& files);
 
 }  // namespace dbbc
-// vim:ts=4 sw=4: