New warnfixes (#2254)

* Fix clang warnings

* Remove vim tab guides

* initialize variables

* 'strncpy' output truncated before terminating nul copying as many bytes from a string as its length

* Fix ISO C++17 does not allow 'register' storage class specifier for outdated bison

* chars are unsigned on ARM, having  if (ival < 0) always false

* chars are unsigned by default on ARM and comparison with -1 if always true

dbcon/mysql/ha_autoi.cpp

@@ -176,4 +176,3 @@ bool parseAutoincrementColumnComment(std::string comment, uint64_t& startValue)
   return autoincrement;
 }
 
-// vim:ts=4 sw=4:

dbcon/mysql/ha_mcs_datatype.h

@@ -841,4 +841,3 @@ class WriteBatchFieldMariaDB : public WriteBatchField
 
 }  // end of namespace datatypes
 
-// vim:ts=2 sw=2:

dbcon/mysql/ha_mcs_ddl.cpp

@@ -2807,4 +2807,3 @@ extern "C"
   }
 }
 
-// vim:ts=4 sw=4:

dbcon/mysql/ha_mcs_dml.cpp

@@ -1001,4 +1001,3 @@ int ha_mcs_impl_close_connection_(handlerton* hton, THD* thd, cal_connection_inf
   return rc;
 }
 
-// vim:ts=4 sw=4:

dbcon/mysql/ha_mcs_execplan.cpp

@@ -10459,4 +10459,3 @@ int getGroupPlan(gp_walk_info& gwi, SELECT_LEX& select_lex, SCSEP& csep, cal_gro
 }
 
 }  // namespace cal_impl_if
-// vim:ts=4 sw=4:

dbcon/mysql/ha_pseudocolumn.cpp

@@ -579,4 +579,3 @@ execplan::ReturnedColumn* buildPseudoColumn(Item* item, gp_walk_info& gwi, bool&
 }
 
 }  // namespace cal_impl_if
-// vim:ts=4 sw=4:

dbcon/mysql/idb_mysql.h

@@ -118,4 +118,3 @@ inline char* idb_mysql_query_str(THD* thd)
 }
 }  // namespace
 
-// vim:ts=4 sw=4: