Brad Warren
a86ea53a79
Added unit tests
2015-10-05 12:09:35 -07:00
Brad Warren
59348ad30c
Made methods private and updated tests
2015-10-01 13:33:22 -07:00
Brad Warren
c976c0abdf
Removed duplicated code
2015-10-01 13:03:23 -07:00
Peter Eckersley
43cb36807a
Also test top level help
2015-09-30 17:00:09 -07:00
Peter Eckersley
11ca1108c2
Test cases for command line help
2015-09-30 16:53:08 -07:00
Peter Eckersley
2406fc0486
Go back to VERBS as a list
...
The dictionary was destroying the ordering, which was important.
2015-09-30 16:07:16 -07:00
Peter Eckersley
d85f42d71f
Plugins don't need to be in HELP_TOPICS
...
They're already added as topics automatically, though they do need to be in
the hand-written top level help.
2015-09-30 15:29:29 -07:00
Peter Eckersley
2d578468bd
Use a verb -> function table instead of eval()
...
- plugins_cmd() not plugins() broke the more minimalist eval() approach
- more wrangling was required to mock out calls via the VERBS table
2015-09-30 12:32:44 -07:00
Peter Eckersley
2a3a111d62
Disable pylint invalid-name
...
It's clearly making our code harder to read and write
2015-09-30 12:10:16 -07:00
Peter Eckersley
1e3c92c714
Cleanup the verb -> subparser mapping
2015-09-30 11:49:46 -07:00
Peter Eckersley
627fca37b4
We didn't actually need to define --help as a verb
2015-09-29 18:55:59 -07:00
Peter Eckersley
18dacc528d
Preserve all argparse parameters
...
Try to restore all variants that applied to the different subcomannds
2015-09-29 18:55:59 -07:00
Peter Eckersley
6b6bc03882
--cert-path was required for install and revoke
...
Oops
2015-09-29 17:14:40 -07:00
Peter Eckersley
2297349b95
lintian
2015-09-29 16:56:36 -07:00
Peter Eckersley
4437ec5586
Merge remote-tracking branch 'origin/master' into subargs
2015-09-29 14:49:32 -07:00
Peter Eckersley
05d439a339
Update cli tests
...
We don't expect to error out if called with no args
2015-09-29 14:48:40 -07:00
Peter Eckersley
a0af023b14
--key-path is mandatory for install, optional for revoke
2015-09-29 14:48:26 -07:00
Peter Eckersley
2e0fd36c28
Improve flag and help processing
...
* letsencrypt --help $SUBCOMMAND now works.
Fixes #787 #819
* subcommand arguments are now actually argument groups, so that all flags
can be placed before or after subcommand verbs as the user wishes
Fixes : #820
A limitation:
* args like --cert-path were previously present for multiple verbs
(auth/install/revoke) with separate docs; they are now in the "paths"
topic. That's fine, though it would be good to *also* list them when the
user types letsencrypt --help install.
2015-09-29 21:01:02 +00:00
Brad Warren
312057b1b8
changes += kuba_feedback
2015-09-29 12:54:52 -07:00
Brad Warren
ed7977fb03
Added cli tests
2015-09-28 18:45:12 -07:00
Brad Warren
243c9e9021
Made cover and lint happy
2015-09-28 15:52:09 -07:00
Brad Warren
4da0e17255
Added message and changed reporter interface
2015-09-28 15:45:31 -07:00
Brad Warren
3279aefefb
Made PEP8 happy
2015-09-28 15:15:44 -07:00
bmw
917f240423
Merge pull request #854 from letsencrypt/remove_sigpwr
...
Remove `signal.SIGPWR` from error_handler.py
2015-09-28 12:39:19 -07:00
bmw
3c62e5b936
Merge pull request #853 from kuba/bugs/789
...
Hide null installer (fixes #789 ).
2015-09-28 12:39:07 -07:00
Brad Warren
c1012f5f00
Removed SIGPWR entirely
2015-09-28 12:25:37 -07:00
Jakub Warmuz
315b357781
Hide null installer ( fixes #789 ).
2015-09-28 19:08:57 +00:00
Jacob Hoffman-Andrews
9264d54605
Merge pull request #849 from letsencrypt/simple-verify-output
...
Emit error when simple_verify fails.
2015-09-28 12:04:06 -07:00
Jacob Hoffman-Andrews
27268afdcc
Remove extra newline.
2015-09-28 11:58:12 -07:00
Jacob Hoffman-Andrews
a7375eb549
Emit error when simple_verify fails.
...
When running the manual authenticator, if simple_verify fails, there is no
output to indicate what went wrong, just "Incomplete authorizations."
2015-09-27 23:43:26 -07:00
David Xia
96a737bbba
Fix CLI --help for OS X
...
OS X's signal module doesn't have SIGPWR. Don't try to use it.
Fixes #841
2015-09-27 22:11:33 -04:00
Peter Eckersley
ddc04c755b
work in progress
2015-09-27 07:56:38 +00:00
Peter Eckersley
a29afcc3bd
Merge remote-tracking branch 'origin/master' into subargs
2015-09-27 07:54:30 +00:00
Peter Eckersley
f3c2a096b5
Move the verb/subcommand to the end of the argparse line
2015-09-27 02:48:44 +00:00
Peter Eckersley
001d37f965
"-h" is also a ver.
2015-09-27 02:41:55 +00:00
James Kasten
523dba0b99
Merge pull request #777 from letsencrypt/fix_771
...
Make 'auth' and 'run' use the same code (fixes #771 )
2015-09-26 22:12:46 -04:00
Peter Eckersley
e7cbdc4f9a
Revert reversion
...
Revert "Revert "ManualAuthenticator -> Authenticator""
(commit required a pip reinstall but was not inherently broken)
This reverts commit 6f1b1570b1
2015-09-26 18:20:13 -07:00
Peter Eckersley
405bc99235
--help is effectively a verb for CLI purposes
2015-09-26 18:19:56 -07:00
Peter Eckersley
63e1c652e1
Undo damage from PEP8ification
2015-09-26 18:05:34 -07:00
Peter Eckersley
6f1b1570b1
Revert "ManualAuthenticator -> Authenticator"
...
This reverts commit 81f0a973a3
2015-09-26 17:48:45 -07:00
James Kasten
8dc345a3a0
address naming conventions
2015-09-26 16:04:44 -07:00
James Kasten
655c3c2a0e
Address comments
2015-09-26 15:44:57 -07:00
bmw
8e7e30a360
Merge pull request #833 from kuba/manual
...
ManualAuthenticator -> Authenticator
2015-09-26 12:42:10 -07:00
Brad Warren
d2a64166c6
Merge branch 'master' into red_errors
2015-09-26 12:18:41 -07:00
Brad Warren
2015811a6c
Incorporated Kuba's feedback
2015-09-26 12:18:32 -07:00
Jakub Warmuz
81f0a973a3
ManualAuthenticator -> Authenticator
2015-09-26 09:07:08 +00:00
James Kasten
c74bc409d8
Merge pull request #824 from letsencrypt/remove_revoker
...
Remove revoker
2015-09-26 04:35:54 -04:00
James Kasten
98d49ae8bf
Remove excessive error handling
2015-09-26 01:34:09 -07:00
James Kasten
e4771cf500
Merge pull request #814 from letsencrypt/crash_recovery
...
Crash recovery
2015-09-26 04:25:58 -04:00
James Kasten
84267c8f3a
Merge branch 'master' into remove_revoker
...
Conflicts:
letsencrypt/configuration.py
letsencrypt/interfaces.py
letsencrypt/tests/configuration_test.py
2015-09-26 01:19:28 -07:00
