Brad Warren
a86ea53a79
Added unit tests
2015-10-05 12:09:35 -07:00
Brad Warren
59348ad30c
Made methods private and updated tests
2015-10-01 13:33:22 -07:00
Brad Warren
c976c0abdf
Removed duplicated code
2015-10-01 13:03:23 -07:00
Peter Eckersley
393f4b4997
Merge pull request #863 from letsencrypt/subargs
...
Improve CLI flag and help processing
2015-09-30 17:05:06 -07:00
bmw
078b8c01f6
Merge pull request #869 from letsencrypt/broken-nginx
...
Mark Nginx as non-working.
2015-09-30 17:00:49 -07:00
Peter Eckersley
43cb36807a
Also test top level help
2015-09-30 17:00:09 -07:00
Peter Eckersley
11ca1108c2
Test cases for command line help
2015-09-30 16:53:08 -07:00
Jacob Hoffman-Andrews
95c4b55da0
Mark Nginx as non-working.
2015-09-30 16:49:03 -07:00
Peter Eckersley
2406fc0486
Go back to VERBS as a list
...
The dictionary was destroying the ordering, which was important.
2015-09-30 16:07:16 -07:00
Peter Eckersley
5ca1a27200
Keep the acme/ subtree compatible with strict pylinting
2015-09-30 15:31:32 -07:00
Peter Eckersley
d85f42d71f
Plugins don't need to be in HELP_TOPICS
...
They're already added as topics automatically, though they do need to be in
the hand-written top level help.
2015-09-30 15:29:29 -07:00
Peter Eckersley
2d578468bd
Use a verb -> function table instead of eval()
...
- plugins_cmd() not plugins() broke the more minimalist eval() approach
- more wrangling was required to mock out calls via the VERBS table
2015-09-30 12:32:44 -07:00
Peter Eckersley
2a3a111d62
Disable pylint invalid-name
...
It's clearly making our code harder to read and write
2015-09-30 12:10:16 -07:00
Peter Eckersley
1e3c92c714
Cleanup the verb -> subparser mapping
2015-09-30 11:49:46 -07:00
Peter Eckersley
627fca37b4
We didn't actually need to define --help as a verb
2015-09-29 18:55:59 -07:00
Peter Eckersley
18dacc528d
Preserve all argparse parameters
...
Try to restore all variants that applied to the different subcomannds
2015-09-29 18:55:59 -07:00
Peter Eckersley
6b6bc03882
--cert-path was required for install and revoke
...
Oops
2015-09-29 17:14:40 -07:00
Peter Eckersley
2297349b95
lintian
2015-09-29 16:56:36 -07:00
Peter Eckersley
4437ec5586
Merge remote-tracking branch 'origin/master' into subargs
2015-09-29 14:49:32 -07:00
Peter Eckersley
05d439a339
Update cli tests
...
We don't expect to error out if called with no args
2015-09-29 14:48:40 -07:00
Peter Eckersley
a0af023b14
--key-path is mandatory for install, optional for revoke
2015-09-29 14:48:26 -07:00
Peter Eckersley
2e0fd36c28
Improve flag and help processing
...
* letsencrypt --help $SUBCOMMAND now works.
Fixes #787 #819
* subcommand arguments are now actually argument groups, so that all flags
can be placed before or after subcommand verbs as the user wishes
Fixes : #820
A limitation:
* args like --cert-path were previously present for multiple verbs
(auth/install/revoke) with separate docs; they are now in the "paths"
topic. That's fine, though it would be good to *also* list them when the
user types letsencrypt --help install.
2015-09-29 21:01:02 +00:00
bmw
ce520ca532
Merge pull request #859 from letsencrypt/report_success
...
Report cert issuance to the user
2015-09-29 13:02:00 -07:00
Brad Warren
312057b1b8
changes += kuba_feedback
2015-09-29 12:54:52 -07:00
bmw
23e766a4d3
Merge pull request #861 from letsencrypt/nginx_alpha
...
Mark Nginx as Alpha
2015-09-29 11:12:19 -07:00
Brad Warren
dcd274ed93
Marked Nginx as Alpha
2015-09-29 11:06:02 -07:00
bmw
74d96f9d92
Merge pull request #860 from kuba/bugs/855
...
UnrecognizedChallenge (fixes #855 ).
2015-09-29 08:52:15 -07:00
Jakub Warmuz
0ffef20a20
UnrecognizedChallenge: fix tests and lint.
2015-09-29 07:02:33 +00:00
Jakub Warmuz
ad1fce03f7
UnrecognizedChallenge ( fixes #855 ).
...
Overrides quick fix from #856 .
2015-09-29 06:47:15 +00:00
Brad Warren
dc0b26c278
Raised cover percentage
2015-09-28 18:47:15 -07:00
Brad Warren
ed7977fb03
Added cli tests
2015-09-28 18:45:12 -07:00
bmw
43e55ae924
Merge pull request #856 from letsencrypt/ignore-unknown-challenges
...
Ignore unknown challenge types
2015-09-28 16:16:11 -07:00
James Kasten
5238f53092
DVChallenge -> Challenge
2015-09-28 16:03:03 -07:00
James Kasten
67ec4d09ee
Put in dummy challenge
2015-09-28 15:53:42 -07:00
Brad Warren
243c9e9021
Made cover and lint happy
2015-09-28 15:52:09 -07:00
Brad Warren
4da0e17255
Added message and changed reporter interface
2015-09-28 15:45:31 -07:00
James Kasten
fa992faf52
Fix pylint and add test
2015-09-28 15:24:51 -07:00
Brad Warren
3279aefefb
Made PEP8 happy
2015-09-28 15:15:44 -07:00
bmw
e2325b9b52
Merge pull request #840 from BKreisel/master
...
Add Mac compatibility to boulder-start
2015-09-28 15:07:30 -07:00
Brandon Kreisel
6c90997aa8
Merge remote-tracking branch 'upstream/master'
2015-09-28 17:49:26 -04:00
Brandon Kreisel
b6bbc9e0a2
Add inline Mac comment
2015-09-28 17:39:01 -04:00
Richard Barnes
ab98d5c39f
Ignore unknown challenge types
2015-09-28 17:14:33 -04:00
bmw
a70134a5c8
Merge pull request #852 from Jadaw1n/patch-1
...
Dockerfile: option --text doesn't exist
2015-09-28 12:42:03 -07:00
bmw
917f240423
Merge pull request #854 from letsencrypt/remove_sigpwr
...
Remove `signal.SIGPWR` from error_handler.py
2015-09-28 12:39:19 -07:00
bmw
3c62e5b936
Merge pull request #853 from kuba/bugs/789
...
Hide null installer (fixes #789 ).
2015-09-28 12:39:07 -07:00
Brad Warren
c1012f5f00
Removed SIGPWR entirely
2015-09-28 12:25:37 -07:00
Jakub Warmuz
315b357781
Hide null installer ( fixes #789 ).
2015-09-28 19:08:57 +00:00
Jacob Hoffman-Andrews
9264d54605
Merge pull request #849 from letsencrypt/simple-verify-output
...
Emit error when simple_verify fails.
2015-09-28 12:04:06 -07:00
Jacob Hoffman-Andrews
27268afdcc
Remove extra newline.
2015-09-28 11:58:12 -07:00
Jadaw1n
913a0a9e98
Dockerfile: option --text doesn't exist
2015-09-28 17:34:43 +02:00
