mirror of
https://github.com/certbot/certbot.git
synced 2026-01-26 07:41:33 +03:00
encourage words before code (#9377)
This commit is contained in:
1
.github/pull_request_template.md
vendored
1
.github/pull_request_template.md
vendored
@@ -1,5 +1,6 @@
|
||||
## Pull Request Checklist
|
||||
|
||||
- [ ] The Certbot team has recently expressed interest in reviewing a PR for this. If not, this PR may be closed due our limited resources and need to prioritize how we spend them.
|
||||
- [ ] If the change being made is to a [distributed component](https://certbot.eff.org/docs/contributing.html#code-components-and-layout), edit the `master` section of `certbot/CHANGELOG.md` to include a description of the change being made.
|
||||
- [ ] Add or update any documentation as needed to support the changes in this PR.
|
||||
- [ ] Include your name in `AUTHORS.md` if you like.
|
||||
|
||||
@@ -500,6 +500,9 @@ Submitting a pull request
|
||||
|
||||
Steps:
|
||||
|
||||
0. We recommend you talk with us in a GitHub issue or :ref:`Mattermost <ask for
|
||||
help>` before writing a pull request to ensure the changes you're making is
|
||||
something we have the time and interest to review.
|
||||
1. Write your code! When doing this, you should add :ref:`mypy type annotations
|
||||
<type annotations>` for any functions you add or modify. You can check that
|
||||
you've done this correctly by running ``tox -e mypy`` on a machine that has
|
||||
|
||||
Reference in New Issue
Block a user