crypt/certbot
1
0
Fork 0
mirror of https://github.com/certbot/certbot.git synced 2026-01-26 07:41:33 +03:00
Code Activity

Use a specific tag of adferrand/snapcraft to build QEMU snaps and avoid failures (#8158)

Browse Source 
The latest builds of snapcraft introduced somehow several failures when snaps are built on QEMU for armhf. See https://dev.azure.com/certbot/certbot/_build/results?buildId=2326&view=logs&j=7c548e18-6053-5a42-b366-e6480da09a69&t=a7c7ca26-ae0c-54e6-0355-3bfcd7bab03c for instance.

This PR uses a specific tags from `adferrand/snapcraft`, extracted from the last known working `nightly` pipeline, to avoid these failures until a more permanent fix is done. Very likely the fix will be the move to snapcraft remote builds.

* Use a specific tag of adferrand/snapcraft to build snaps and avoid an error on QEMU for armhf.

* Update tools/snap/build.sh

Co-authored-by: Brad Warren <bmw@users.noreply.github.com>

* Update tools/snap/build_dns.sh

Co-authored-by: Brad Warren <bmw@users.noreply.github.com>

Co-authored-by: Brad Warren <bmw@users.noreply.github.com>
This commit is contained in:
Adrien Ferrand
2020-07-21 02:17:10 +02:00
committed by GitHub
parent b13dfc6437
commit 74b0340a13
2 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
tools/snap/build.sh
View File

@@ -31,11 +31,14 @@ function cleanup() {
trap cleanup EXIT
# NB: We use ARCH-stable-save tag instead of ARCH-stable, because recent versions of snapcraft images
# behave badly on QEMU for arm64 architecture. This should be fixed either by a new version of the
# image that does not have this problem anymore, or the migration to snapcraft remote builds.
docker run \
--rm \
--net=host \
-v "${CERTBOT_DIR}:/certbot" \
-w "/certbot" \
-e "PIP_EXTRA_INDEX_URL=http://localhost:8080" \
"adferrand/snapcraft:${DOCKER_ARCH}-stable" \
"adferrand/snapcraft:${DOCKER_ARCH}-stable-save" \
bash -c "snapcraft clean && snapcraft"

5
tools/snap/build_dns.sh
View File

@@ -60,6 +60,9 @@ for DNS_PLUGIN in ${DNS_PLUGINS}; do
done
EOF
# NB: We use ARCH-stable-save tag instead of ARCH-stable, because recent versions of snapcraft images
# behave badly on QEMU for arm64 architecture. This should be fixed either by a new version of the
# image that does not have this problem anymore, or the migration to snapcraft remote builds.
docker run \
--rm \
--net=host \
@@ -69,5 +72,5 @@ docker run \
-w "/certbot" \
-e "DNS_PLUGINS=${DNS_PLUGINS}" \
-e "PIP_EXTRA_INDEX_URL=http://localhost:8080" \
"adferrand/snapcraft:${DOCKER_ARCH}-stable" \
"adferrand/snapcraft:${DOCKER_ARCH}-stable-save" \
/script.sh