1
0
mirror of https://github.com/square/okhttp.git synced 2026-01-25 16:01:38 +03:00

Changes by suggensions on /square/okhttp/pull/308:

1. fixed identations
2. fixed space char
3. memory allocation optimization
This commit is contained in:
Roman Tsirulnikov
2013-09-03 16:54:39 +04:00
parent a1d42ed5bd
commit 98920e22a7

View File

@@ -291,30 +291,30 @@ public final class RequestHeaders {
return ifModifiedSince != null || ifNoneMatch != null;
}
public void addCookies(Map<String, List<String>> allCookieHeaders) {
for (Map.Entry<String, List<String>> entry : allCookieHeaders.entrySet()) {
String key = entry.getKey();
if ("Cookie".equalsIgnoreCase(key) || "Cookie2".equalsIgnoreCase(key)) {
if (!entry.getValue().isEmpty()) {
headers.add(key, buildCookieHeader(entry.getValue()));
}
}
public void addCookies(Map<String, List<String>> allCookieHeaders) {
for (Map.Entry<String, List<String>> entry : allCookieHeaders.entrySet()) {
String key = entry.getKey();
if ("Cookie".equalsIgnoreCase(key) || "Cookie2".equalsIgnoreCase(key)) {
if (!entry.getValue().isEmpty()) {
headers.add(key, buildCookieHeader(entry.getValue()));
}
}
}
}
// format has defined here: http://tools.ietf.org/html/rfc6265#section-4.2.1
private String buildCookieHeader(List<String> cookies) {
StringBuilder sb = new StringBuilder();
boolean isFirst = true;
for (String cookie : cookies) {
if (isFirst) {
isFirst = false;
} else {
sb.append(';');
}
sb.append(cookie);
}
return sb.toString();
// format has defined here: http://tools.ietf.org/html/rfc6265#section-4.2.1
private String buildCookieHeader(List<String> cookies) {
if(1 == cookies.size()) {
return cookies.get(0);
}
StringBuilder sb = new StringBuilder();
for(int i=0;i < cookies.size();i++) {
if(i>0) {
sb.append("; ");
}
sb.append(cookies.get(i));
}
return sb.toString();
}
}