android/okhttp
1
0
Fork 0
mirror of https://github.com/square/okhttp.git synced 2026-01-17 08:42:25 +03:00
Code Releases Activity

Fix checkstyle issues in new Cookie code.

Browse Source
This commit is contained in:
jwilson
2013-09-03 11:13:03 -04:00
parent 3a85712e7b
commit 8f03548249
1 changed files with 11 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
okhttp/src/main/java/com/squareup/okhttp/internal/http/RequestHeaders.java
View File

@@ -294,27 +294,24 @@ public final class RequestHeaders {
public void addCookies(Map<String, List<String>> allCookieHeaders) {
for (Map.Entry<String, List<String>> entry : allCookieHeaders.entrySet()) {
String key = entry.getKey();
if ("Cookie".equalsIgnoreCase(key) || "Cookie2".equalsIgnoreCase(key)) {
if (!entry.getValue().isEmpty()) {
headers.add(key, buildCookieHeader(entry.getValue()));
}
if (("Cookie".equalsIgnoreCase(key) || "Cookie2".equalsIgnoreCase(key))
&& !entry.getValue().isEmpty()) {
headers.add(key, buildCookieHeader(entry.getValue()));
}
}
}
// format has defined here: http://tools.ietf.org/html/rfc6265#section-4.2.1
/**
* Send all cookies in one big header, as recommended by
* <a href="http://tools.ietf.org/html/rfc6265#section-4.2.1">RFC 6265</a>.
*/
private String buildCookieHeader(List<String> cookies) {
if(1 == cookies.size()) {
return cookies.get(0);
}
if (cookies.size() == 1) return cookies.get(0);
StringBuilder sb = new StringBuilder();
for(int i=0;i < cookies.size();i++) {
if(i>0) {
sb.append("; ");
}
for (int i = 0; i < cookies.size(); i++) {
if (i > 0) sb.append("; ");
sb.append(cookies.get(i));
}
return sb.toString();
}
}
}