android/okhttp
1
0
Fork 0
mirror of https://github.com/square/okhttp.git synced 2026-01-14 07:22:20 +03:00
Code Releases Activity

Merge pull request #5777 from square/jwilson.0209.tunnel_truncated

Browse Source 
Add a test for truncated tunnel responses
This commit is contained in:
Jesse Wilson
2020-02-09 17:01:56 -05:00
committed by GitHub
parent 23cdb3e9ab 56fd46baa3
commit 8733411031
1 changed files with 29 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
okhttp/src/test/java/okhttp3/CallTest.java
View File

@@ -3031,6 +3031,35 @@ public final class CallTest {
assertThat(hostnameVerifier.calls).containsExactly("verify android.com");
}
/**
* We had a bug where OkHttp would crash if HTTP proxies returned a truncated response.
* https://github.com/square/okhttp/issues/5727
*/
@Test public void proxyUpgradeFailsWithTruncatedResponse() throws Exception {
server.enqueue(new MockResponse()
.setBody("abc")
.setHeader("Content-Length", "5")
.setSocketPolicy(SocketPolicy.DISCONNECT_AT_END));
RecordingHostnameVerifier hostnameVerifier = new RecordingHostnameVerifier();
client = client.newBuilder()
.sslSocketFactory(
handshakeCertificates.sslSocketFactory(), handshakeCertificates.trustManager())
.proxy(server.toProxyAddress())
.hostnameVerifier(hostnameVerifier)
.build();
Request request = new Request.Builder()
.url("https://android.com/foo")
.build();
try {
client.newCall(request).execute();
fail();
} catch (IOException expected) {
assertThat(expected).hasMessage("unexpected end of stream");
}
}
/** Respond to a proxy authorization challenge. */
@Test public void proxyAuthenticateOnConnect() throws Exception {
server.useHttps(handshakeCertificates.sslSocketFactory(), true);