android/okhttp
1
0
Fork 0
mirror of https://github.com/square/okhttp.git synced 2025-08-08 23:42:08 +03:00
Code Releases Activity

Move flaky issues to comments (#5289)

Browse Source
This commit is contained in:
Yuri Schimke
2019-07-16 22:50:51 +01:00
committed by GitHub
parent a6c4ff6e44
commit 2c7811a64a
4 changed files with 15 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
okhttp-testing-support/src/main/java/okhttp3/testing/Flaky.kt
View File

@@ -21,4 +21,4 @@ package okhttp3.testing
* Annotation marking a test as flaky, and requires extra logging and linking against * Annotation marking a test as flaky, and requires extra logging and linking against
* a known github issue. This does not ignore the failure. * a known github issue. This does not ignore the failure.
*/ */
annotation class Flaky(val issues: Array<String> = []) annotation class Flaky

4
okhttp/src/test/java/okhttp3/URLConnectionTest.java
View File

@@ -686,8 +686,10 @@ public final class URLConnectionTest {
* *
* http://code.google.com/p/android/issues/detail?id=13178 * http://code.google.com/p/android/issues/detail?id=13178
*/ */
@Flaky(issues = "https://github.com/square/okhttp/issues/5222") @Flaky
@Test public void connectViaHttpsToUntrustedServer() throws Exception { @Test public void connectViaHttpsToUntrustedServer() throws Exception {
// Flaky https://github.com/square/okhttp/issues/5222
server.useHttps(handshakeCertificates.sslSocketFactory(), false); server.useHttps(handshakeCertificates.sslSocketFactory(), false);
server.enqueue(new MockResponse()); // unused server.enqueue(new MockResponse()); // unused

11
okhttp/src/test/java/okhttp3/internal/http2/HttpOverHttp2Test.java
View File

@@ -98,9 +98,11 @@ import static org.junit.Assume.assumeTrue;
/** Test how HTTP/2 interacts with HTTP features. */ /** Test how HTTP/2 interacts with HTTP features. */
@RunWith(Parameterized.class) @RunWith(Parameterized.class)
@Flaky(issues = {"https://github.com/square/okhttp/issues/4632", @Flaky
"https://github.com/square/okhttp/issues/4633"})
public final class HttpOverHttp2Test { public final class HttpOverHttp2Test {
// Flaky https://github.com/square/okhttp/issues/4632
// Flaky https://github.com/square/okhttp/issues/4633
private static final Logger http2Logger = Logger.getLogger(Http2.class.getName()); private static final Logger http2Logger = Logger.getLogger(Http2.class.getName());
private static final HandshakeCertificates handshakeCertificates = localhost(); private static final HandshakeCertificates handshakeCertificates = localhost();
@@ -1230,7 +1232,7 @@ public final class HttpOverHttp2Test {
(long) 1); (long) 1);
} }
@Flaky(issues = "https://github.com/square/okhttp/issues/5221") @Flaky
@Test public void missingPongsFailsConnection() throws Exception { @Test public void missingPongsFailsConnection() throws Exception {
if (protocol == Protocol.HTTP_2) { if (protocol == Protocol.HTTP_2) {
// https://github.com/square/okhttp/issues/5221 // https://github.com/square/okhttp/issues/5221
@@ -1409,8 +1411,9 @@ public final class HttpOverHttp2Test {
assertThat(server.takeRequest().getSequenceNumber()).isEqualTo(0); assertThat(server.takeRequest().getSequenceNumber()).isEqualTo(0);
} }
@Flaky(issues = "https://github.com/square/okhttp/issues/4836") @Flaky
@Test public void responseHeadersAfterGoaway() throws Exception { @Test public void responseHeadersAfterGoaway() throws Exception {
// Flaky https://github.com/square/okhttp/issues/4836
server.enqueue(new MockResponse() server.enqueue(new MockResponse()
.setHeadersDelay(1, SECONDS) .setHeadersDelay(1, SECONDS)
.setBody("ABC")); .setBody("ABC"));

6
okhttp/src/test/java/okhttp3/internal/ws/WebSocketHttpTest.java
View File

@@ -58,9 +58,11 @@ import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.data.Offset.offset; import static org.assertj.core.data.Offset.offset;
import static org.junit.Assert.fail; import static org.junit.Assert.fail;
@Flaky(issues = {"https://github.com/square/okhttp/issues/4515", @Flaky
"https://github.com/square/okhttp/issues/4953"})
public final class WebSocketHttpTest { public final class WebSocketHttpTest {
// Flaky https://github.com/square/okhttp/issues/4515
// Flaky https://github.com/square/okhttp/issues/4953
@Rule public final MockWebServer webServer = new MockWebServer(); @Rule public final MockWebServer webServer = new MockWebServer();
@Rule public final OkHttpClientTestRule clientTestRule = new OkHttpClientTestRule(); @Rule public final OkHttpClientTestRule clientTestRule = new OkHttpClientTestRule();