diff --git a/okhttp-testing-support/src/main/java/okhttp3/testing/Flaky.kt b/okhttp-testing-support/src/main/java/okhttp3/testing/Flaky.kt index 026eeb3b1..f3b04d880 100644 --- a/okhttp-testing-support/src/main/java/okhttp3/testing/Flaky.kt +++ b/okhttp-testing-support/src/main/java/okhttp3/testing/Flaky.kt @@ -21,4 +21,4 @@ package okhttp3.testing * Annotation marking a test as flaky, and requires extra logging and linking against * a known github issue. This does not ignore the failure. */ -annotation class Flaky(val issues: Array = []) +annotation class Flaky diff --git a/okhttp/src/test/java/okhttp3/URLConnectionTest.java b/okhttp/src/test/java/okhttp3/URLConnectionTest.java index 4643e8ab3..656122295 100644 --- a/okhttp/src/test/java/okhttp3/URLConnectionTest.java +++ b/okhttp/src/test/java/okhttp3/URLConnectionTest.java @@ -686,8 +686,10 @@ public final class URLConnectionTest { * * http://code.google.com/p/android/issues/detail?id=13178 */ - @Flaky(issues = "https://github.com/square/okhttp/issues/5222") + @Flaky @Test public void connectViaHttpsToUntrustedServer() throws Exception { + // Flaky https://github.com/square/okhttp/issues/5222 + server.useHttps(handshakeCertificates.sslSocketFactory(), false); server.enqueue(new MockResponse()); // unused diff --git a/okhttp/src/test/java/okhttp3/internal/http2/HttpOverHttp2Test.java b/okhttp/src/test/java/okhttp3/internal/http2/HttpOverHttp2Test.java index c35d2603b..6a684378f 100644 --- a/okhttp/src/test/java/okhttp3/internal/http2/HttpOverHttp2Test.java +++ b/okhttp/src/test/java/okhttp3/internal/http2/HttpOverHttp2Test.java @@ -98,9 +98,11 @@ import static org.junit.Assume.assumeTrue; /** Test how HTTP/2 interacts with HTTP features. */ @RunWith(Parameterized.class) -@Flaky(issues = {"https://github.com/square/okhttp/issues/4632", - "https://github.com/square/okhttp/issues/4633"}) +@Flaky public final class HttpOverHttp2Test { + // Flaky https://github.com/square/okhttp/issues/4632 + // Flaky https://github.com/square/okhttp/issues/4633 + private static final Logger http2Logger = Logger.getLogger(Http2.class.getName()); private static final HandshakeCertificates handshakeCertificates = localhost(); @@ -1230,7 +1232,7 @@ public final class HttpOverHttp2Test { (long) 1); } - @Flaky(issues = "https://github.com/square/okhttp/issues/5221") + @Flaky @Test public void missingPongsFailsConnection() throws Exception { if (protocol == Protocol.HTTP_2) { // https://github.com/square/okhttp/issues/5221 @@ -1409,8 +1411,9 @@ public final class HttpOverHttp2Test { assertThat(server.takeRequest().getSequenceNumber()).isEqualTo(0); } - @Flaky(issues = "https://github.com/square/okhttp/issues/4836") + @Flaky @Test public void responseHeadersAfterGoaway() throws Exception { + // Flaky https://github.com/square/okhttp/issues/4836 server.enqueue(new MockResponse() .setHeadersDelay(1, SECONDS) .setBody("ABC")); diff --git a/okhttp/src/test/java/okhttp3/internal/ws/WebSocketHttpTest.java b/okhttp/src/test/java/okhttp3/internal/ws/WebSocketHttpTest.java index 2dd8bb226..6d09aa150 100644 --- a/okhttp/src/test/java/okhttp3/internal/ws/WebSocketHttpTest.java +++ b/okhttp/src/test/java/okhttp3/internal/ws/WebSocketHttpTest.java @@ -58,9 +58,11 @@ import static org.assertj.core.api.Assertions.assertThat; import static org.assertj.core.data.Offset.offset; import static org.junit.Assert.fail; -@Flaky(issues = {"https://github.com/square/okhttp/issues/4515", - "https://github.com/square/okhttp/issues/4953"}) +@Flaky public final class WebSocketHttpTest { + // Flaky https://github.com/square/okhttp/issues/4515 + // Flaky https://github.com/square/okhttp/issues/4953 + @Rule public final MockWebServer webServer = new MockWebServer(); @Rule public final OkHttpClientTestRule clientTestRule = new OkHttpClientTestRule();