Manuel Brack
00eca4b887
[Pipeline] Add LEDITS++ pipelines ( #6074 )
...
* Setup LEdits++ file structure
* Fix import
* LEditsPP Stable Diffusion pipeline
* Include variable image aspect ratios
* Implement LEDITS++ for SDXL
* clean up LEditsPPPipelineStableDiffusion
* Adjust inversion output
* Added docu, more cleanup for LEditsPPPipelineStableDiffusion
* clean up LEditsPPPipelineStableDiffusionXL
* Update documentation
* Fix documentation import
* Add skeleton IF implementation
* Fix documentation typo
* Add LEDTIS docu to toctree
* Add missing title
* Finalize SD documentation
* Finalize SD-XL documentation
* Fix code style and quality
* Fix typo
* Fix return types
* added LEditsPPPipelineIF; minor changes for LEditsPPPipelineStableDiffusion and LEditsPPPipelineStableDiffusionXL
* Fix copy reference
* add documentation for IF
* Add first tests
* Fix batching for SD-XL
* Fix text encoding and perfect reconstruction for SD-XL
* Add tests for SD-XL, minor changes
* move user_mask to correct device, use cross_attention_kwargs also for inversion
* Example docstring
* Fix attention resolution for non-square images
* Refactoring for PR review
* Safely remove ledits_utils.py
* Style fixes
* Replace assertions with ValueError
* Remove LEditsPPPipelineIF
* Remove unecessary input checks
* Refactoring of CrossAttnProcessor
* Revert unecessary changes to scheduler
* Remove first progress-bar in inversion
* Refactor scheduler usage and reset
* Use imageprocessor instead of custom logic
* Fix scheduler init warning
* Fix error when running the pipeline in fp16
* Update documentation wrt perfect inversion
* Update tests
* Fix code quality and copy consistency
* Update LEditsPP import
* Remove enable/disable methods that are now in StableDiffusionMixin
* Change import in docs
* Revert import structure change
* Fix ledits imports
---------
Co-authored-by: Katharina Kornmeier <katharina.kornmeier@stud.tu-darmstadt.de >
2024-03-13 12:43:47 +02:00
Dhruv Nair
30132aba30
Update Stable Cascade Conversion Scripts ( #7271 )
...
* update
* update
* update
* update
* update
* update
* update
* update
* update
---------
Co-authored-by: Sayak Paul <spsayakpaul@gmail.com >
2024-03-13 12:35:44 +05:30
Dhruv Nair
a17d6d6858
Update Cascade documentation ( #7257 )
...
* updates
* update
* update
* Update docs/source/en/api/pipelines/stable_cascade.md
Co-authored-by: Sayak Paul <spsayakpaul@gmail.com >
* update
* update
* update
* update
---------
Co-authored-by: Sayak Paul <spsayakpaul@gmail.com >
Co-authored-by: Kashif Rasul <kashif.rasul@gmail.com >
2024-03-13 11:29:59 +05:30
Sayak Paul
8efd9ce787
[Chore] clean residue from copy-pasting in the UNet single file loader ( #7295 )
...
clean residue from copy-pasting
2024-03-13 11:20:13 +05:30
Dhruv Nair
299c16d0f5
Fix loading Img2Img refiner components in from_single_file ( #7282 )
...
* update
* update
* update
* update
2024-03-13 09:25:53 +05:30
Dhruv Nair
69f49195ac
Fix passing pooled prompt embeds to Cascade Decoder and Combined Pipeline ( #7287 )
...
* update
* update
* update
* update
2024-03-13 09:21:41 +05:30
Dhruv Nair
ed224f94ba
Add single file support for Stable Cascade ( #7274 )
...
* update
* update
* update
* update
* update
* update
---------
Co-authored-by: Sayak Paul <spsayakpaul@gmail.com >
2024-03-13 08:37:31 +05:30
Sayak Paul
531e719163
[LoRA] use the PyTorch classes wherever needed and start depcrecation cycles ( #7204 )
...
* fix PyTorch classes and start deprecsation cycles.
* remove args crafting for accommodating scale.
* remove scale check in feedforward.
* assert against nn.Linear and not CompatibleLinear.
* remove conv_cls and lineaR_cls.
* remove scale
* 👋 scale.
* fix: unet2dcondition
* fix attention.py
* fix: attention.py again
* fix: unet_2d_blocks.
* fix-copies.
* more fixes.
* fix: resnet.py
* more fixes
* fix i2vgenxl unet.
* depcrecate scale gently.
* fix-copies
* Apply suggestions from code review
Co-authored-by: YiYi Xu <yixu310@gmail.com >
* quality
* throw warning when scale is passed to the the BasicTransformerBlock class.
* remove scale from signature.
* cross_attention_kwargs, very nice catch by Yiyi
* fix: logger.warn
* make deprecation message clearer.
* address final comments.
* maintain same depcrecation message and also add it to activations.
* address yiyi
* fix copies
* Apply suggestions from code review
Co-authored-by: YiYi Xu <yixu310@gmail.com >
* more depcrecation
* fix-copies
---------
Co-authored-by: YiYi Xu <yixu310@gmail.com >
2024-03-13 07:56:19 +05:30
Sayak Paul
4fbd310fd2
[Chore] switch to logger.warning ( #7289 )
...
switch to logger.warning
2024-03-13 06:56:43 +05:30
Dhruv Nair
2ea28d69dc
Change export_to_video default ( #6990 )
...
update
Co-authored-by: Sayak Paul <spsayakpaul@gmail.com >
2024-03-12 17:13:12 +05:30
erliding
a1cb106459
instruct pix2pix pipeline: remove sigma scaling when computing classifier free guidance ( #7006 )
...
remove sigma scaling when computing cfg
Co-authored-by: Sayak Paul <spsayakpaul@gmail.com >
2024-03-11 10:23:31 +01:00
Sayak Paul
5dd8e04d4b
[Dockerfiles] add: a workflow to check if docker containers can be built in case of modifications ( #7129 )
...
* add: a workflow to check if docker containers can be built if the files are modified.
* type
* unify docker image build test and push
* make it run on prs too.
* check
* check
* check
* check again.
* remove docker test build file.
* remove extra dependencies./
* check
2024-03-11 08:54:00 +05:30
pravdomil
165af7edd3
Inline InputPadder ( #6582 )
...
inline InputPadder
2024-03-09 11:24:07 -10:00
Haofan Wang
6c5f0de713
Support latents_mean and latents_std ( #7132 )
...
* update latents_mean and latents_std
* fix typos
* Update src/diffusers/pipelines/controlnet/pipeline_controlnet_sd_xl_img2img.py
* format
---------
Co-authored-by: ResearcherXman <xhs.research@gmail.com >
Co-authored-by: Sayak Paul <spsayakpaul@gmail.com >
Co-authored-by: YiYi Xu <yixu310@gmail.com >
2024-03-09 08:54:19 -10:00
pravdomil
e64fdcf2ce
Fix gmflow_dir ( #6583 )
...
* remove sys.path
* update readme
2024-03-09 08:53:17 -10:00
Sayak Paul
ec64f371b1
[Chore] remove tf mention ( #7245 )
...
remove tf mention
2024-03-09 11:39:04 +05:30
Aryan
cd6e1f1171
[docs/nits] Fix return values based on return_dict and minor doc updates ( #7105 )
...
* fix returns and docs
* handle latent output_type correctly
* revert to old tensor2vid impl
* make fix-copies
* fix return in community animatediff pipes
* fix return docstring
* fix return docs
* add missing quote
---------
Co-authored-by: Dhruv Nair <dhruv.nair@gmail.com >
2024-03-08 18:47:24 -10:00
Xiaodong Wang
6f2b310a17
[UNet_Spatio_Temporal_Condition] fix default num_attention_heads in unet_spatio_temporal_condition ( #7205 )
...
fix default num_attention_heads in unet_spatio_temporal_condition
Co-authored-by: Sayak Paul <spsayakpaul@gmail.com >
2024-03-08 18:29:06 -10:00
YiYi Xu
e3cd6cae50
update the signature of from_single_file ( #7216 )
...
* update the signature of from_single_file
* Update src/diffusers/loaders/single_file.py
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com >
* Update src/diffusers/loaders/single_file.py
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com >
* Update src/diffusers/loaders/single_file.py
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com >
* Update src/diffusers/loaders/single_file.py
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com >
---------
Co-authored-by: yiyixuxu <yixu310@gmail,com>
Co-authored-by: Sayak Paul <spsayakpaul@gmail.com >
Co-authored-by: Dhruv Nair <dhruv.nair@gmail.com >
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com >
2024-03-08 17:51:51 -10:00
qqii
e5ee05da76
[Community Pipeline] Skip Marigold depth_colored with color_map=None ( #7170 )
...
[Community Pipeline] Skip Marigold depth_colored generation by passing color_map=None
2024-03-08 17:51:11 -10:00
Mengqing Cao
e6ff752840
Add npu support ( #7144 )
...
* Add npu support
* fix for code quality check
* fix for code quality check
2024-03-08 17:12:55 -10:00
UmerHA
3f9c746fb2
Adds denoising_end parameter to ControlNetPipeline for SDXL ( #6175 )
...
* Initial commit
* Removed copy hints, as in original SDXLControlNetPipeline
Removed copy hints, as in original SDXLControlNetPipeline, as the `make fix-copies` seems to have issues with the @property decorator.
* Reverted changes to ControlNetXS
* Addendum to: Removed changes to ControlNetXS
* Added test+docs for mixture of denoiser
* Update docs/source/en/using-diffusers/controlnet.md
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com >
* Update docs/source/en/using-diffusers/controlnet.md
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com >
---------
Co-authored-by: Sayak Paul <spsayakpaul@gmail.com >
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com >
2024-03-08 16:42:02 -10:00
Steven Liu
1f22c98820
[docs] IP-Adapter image embedding ( #7226 )
...
* update
* fix parameter name
* feedback
* add no mask version
---------
Co-authored-by: Sayak Paul <spsayakpaul@gmail.com >
2024-03-08 08:49:58 -08:00
Sayak Paul
b4226bd6a7
[Tests] fix config checking tests ( #7247 )
...
* debig
* cast tuples to lists.
* debug
* handle upcast attention
* handle downblock types for vae.
* remove print.
* address Dhruv's comments.
* fix: upblock types.
* upcast attention
* debug
* debug
* debug
* better guarding.
* style
2024-03-08 18:53:07 +05:30
Chi
46fac824be
Solve missing clip_sample implementation in FlaxDDIMScheduler. ( #7017 )
...
* I added a new doc string to the class. This is more flexible to understanding other developers what are doing and where it's using.
* Update src/diffusers/models/unet_2d_blocks.py
This changes suggest by maintener.
Co-authored-by: Sayak Paul <spsayakpaul@gmail.com >
* Update src/diffusers/models/unet_2d_blocks.py
Add suggested text
Co-authored-by: Sayak Paul <spsayakpaul@gmail.com >
* Update unet_2d_blocks.py
I changed the Parameter to Args text.
* Update unet_2d_blocks.py
proper indentation set in this file.
* Update unet_2d_blocks.py
a little bit of change in the act_fun argument line.
* I run the black command to reformat style in the code
* Update unet_2d_blocks.py
similar doc-string add to have in the original diffusion repository.
* Fix bug for mention in this issue section #6901
* Update src/diffusers/schedulers/scheduling_ddim_flax.py
Co-authored-by: Pedro Cuenca <pedro@huggingface.co >
* Fix linter
* Restore empty line
---------
Co-authored-by: Sayak Paul <spsayakpaul@gmail.com >
Co-authored-by: Pedro Cuenca <pedro@huggingface.co >
2024-03-08 12:01:59 +01:00
Martin Müller
b33b64f595
Make mid block optional for flax UNet ( #7083 )
...
* make mid block optional for flax UNet
* make style
2024-03-08 11:35:06 +01:00
Sayak Paul
9d9744075e
[Easy] fix: save_model_card utility of the DreamBooth SDXL LoRA script ( #7258 )
...
* fix: save_model_card utility.
* fix a little more to make it more lenient.
* remove lower()
2024-03-08 15:22:23 +05:30
Sayak Paul
d9a3b69806
[Utils] Improve " # Copied from ..." statements in the pipelines ( #6917 )
...
* copied from for t2i pipelines without ip adapter support.
* two more pipelines with proper copied from comments.
* revert to the original implementation
2024-03-08 14:42:26 +05:30
Sayak Paul
f7e5954d5e
[Tests] fix: VAE tiling tests when setting the right device ( #7246 )
...
* debug
* checking
* fix more
* remove device.
* fix-copies
2024-03-08 10:01:25 +05:30
Sayak Paul
8e19c073e5
[Core] throw error when patch inputs and layernorm are provided for Transformers2D ( #7200 )
...
* throw error when patch inputs and layernorm are provided for transformers2d.
* add comment on supported norm_types in transformers2d
* more check
* fix: norm _type handling
2024-03-08 09:41:02 +05:30
Steven Liu
f6df16cbb8
[docs] Community tips ( #7137 )
...
* tips
* feedback
* callback only
2024-03-07 15:17:26 -08:00
pravdomil
b24f78349c
use self.device ( #6595 )
...
* use self.device
* use device
* fix
* fix
2024-03-07 12:46:23 -10:00
Steven Liu
3ce905c9d0
[docs] Merge LoRAs ( #7213 )
...
* merge loras
* feedback
* torch.compile
* feedback
2024-03-07 11:28:50 -08:00
bimsarapathiraja
f539497ab4
Remove the line. Using it create wrong output ( #7075 )
...
Co-authored-by: Sayak Paul <spsayakpaul@gmail.com >
2024-03-07 10:04:31 -08:00
Dhruv Nair
39dfb7abbd
Raise an error when trying to use SD Cascade Decoder with dtype bfloat16 and torch < 2.2 ( #7244 )
...
update
2024-03-07 17:55:46 +05:30
Sayak Paul
196835695e
fix: support for loading playground v2.5 single file checkpoint. ( #7230 )
...
* fix: support for loading playground v2.5 single file checkpoint.
* remove is_playground_model.
* fix: edm key
* apply Dhruv's comments but errors.
* fix: things.
* delegate model_type inference to a function.
* address Dhruv's comment.
* address rest of the comments.
* fix: kwargs
* fix
* update
---------
Co-authored-by: DN6 <dhruv.nair@gmail.com >
2024-03-07 15:31:03 +05:30
Sayak Paul
0d4dfbbd0a
[Examples] fix: prior preservation setting in DreamBooth LoRA SDXL script. ( #7242 )
...
fix: prior preservation setting in DreamBooth LoRA SDXL script.
Co-authored-by: Linoy Tsaban <57615435+linoytsaban@users.noreply.github.com >
2024-03-07 15:19:58 +05:30
Rinne
ada3bb941b
fix: remove duplicated code in TemporalBasicTransformerBlock. ( #7212 )
...
fix: remove duplicate code in TemporalBasicTransformerBlock.
Co-authored-by: Sayak Paul <spsayakpaul@gmail.com >
2024-03-07 13:25:22 +05:30
Linoy Tsaban
b5814c5555
add DoRA training feature to sdxl dreambooth lora script ( #7235 )
...
* dora in canonical script
* add mention of DoRA to readme
2024-03-07 11:43:37 +05:30
Paakhhi
9940573618
Refactor Prompt2Prompt: Inherit from DiffusionPipeline ( #7211 )
...
refactor: inherit from DiffusionPipeline instead of StableDiffusionPipeline
2024-03-06 19:34:40 -10:00
Sayak Paul
59433ca1ae
[Core] move out the utilities from pipeline_utils.py ( #7234 )
...
move out the utilities from pipeline_utils.py
2024-03-07 08:45:24 +05:30
Nate Landman
534f5d54fa
Update train_dreambooth_lora_sdxl_advanced.py ( #7227 )
...
adding the type gives you
```
TypeError: _StoreTrueAction.__init__() got an unexpected keyword argument 'type'
```
2024-03-06 12:41:48 +01:00
Kashif Rasul
40aa47b998
[Pipiline] Wuerstchen v3 aka Stable Cascasde pipeline ( #6487 )
...
* initial diffNext v3
* move to v3 folder
* imports
* dry up the unets
* no switch_level
* fix init
* add switch_level tp config
* Fixed some things
* Added pooled text embeddings
* Initial work on adding image encoder
* changes from @dome272
* Stuff for the image encoder processing and variable naming in decoder
* fix arg name
* inference fixes
* inference fixes
* default TimestepBlock without conds
* c_skip=0 by default
* fix bfloat16 to cpu
* use config
* undo temp change
* fix gen_c_embeddings args
* change text encoding
* text encoding
* undo print
* undo .gitignore change
* Allow WuerstchenV3PriorPipeline to use the base DDPM & DDIM schedulers
* use WuerstchenV3Unet in both pipelines
* fix imports
* initial failing tests
* cleanup
* use scheduler.timesterps
* some fixes to the tests, still not fully working
* fix tests
* fix prior tests
* add dropout to the model_kwargs
* more tests passing
* update expected_slice
* initial rename
* rename tests
* rename class names
* make fix-copies
* initial docs
* autodocs
* typos
* fix arg docs
* add text_encoder info
* combined pipeline has optional image arg
* fix documentation
* Update src/diffusers/pipelines/stable_cascade/modeling_stable_cascade_common.py
Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com >
* Update src/diffusers/pipelines/stable_cascade/modeling_stable_cascade_common.py
Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com >
* Update src/diffusers/pipelines/stable_cascade/modeling_stable_cascade_common.py
Co-authored-by: YiYi Xu <yixu310@gmail.com >
* Update src/diffusers/pipelines/stable_cascade/modeling_stable_cascade_common.py
Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com >
* Update src/diffusers/pipelines/stable_cascade/pipeline_stable_cascade.py
Co-authored-by: YiYi Xu <yixu310@gmail.com >
* Update src/diffusers/pipelines/stable_cascade/modeling_stable_cascade_common.py
Co-authored-by: YiYi Xu <yixu310@gmail.com >
* use self.config
* Update src/diffusers/pipelines/stable_cascade/modeling_stable_cascade_common.py
Co-authored-by: YiYi Xu <yixu310@gmail.com >
* c_in -> in_channels
* removed kwargs from unet's forward
* Update src/diffusers/pipelines/stable_cascade/pipeline_stable_cascade.py
Co-authored-by: YiYi Xu <yixu310@gmail.com >
* Update src/diffusers/pipelines/stable_cascade/pipeline_stable_cascade.py
Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com >
* remove older callback api
* removed kwargs and fixed decoder guidance > 1
* decoder takes emeds
* check and use image_embeds
* fixed all but one decoder test
* fix decoder tests
* update callback api
* fix some more combined tests
* push combined pipeline
* initial docs
* fix doc_string
* update combined api
* no test_callback_inputs test for combined pipeline
* add optional components
* fix ordering of components
* fix combined tests
* update convert script
* Update src/diffusers/pipelines/stable_cascade/pipeline_stable_cascade_prior.py
Co-authored-by: YiYi Xu <yixu310@gmail.com >
* Update src/diffusers/pipelines/stable_cascade/pipeline_stable_cascade_prior.py
Co-authored-by: YiYi Xu <yixu310@gmail.com >
* Update src/diffusers/pipelines/stable_cascade/pipeline_stable_cascade_prior.py
Co-authored-by: YiYi Xu <yixu310@gmail.com >
* fix imports
* move effnet out of deniosing loop
* prompt_embeds_pooled only when doing guidance
* Fix repeat shape
* move StableCascadeUnet to models/unets/
* more descriptive names
* converted when numpy()
* StableCascadePriorPipelineOutput docs
* rename StableCascadeUNet
* add slow tests
* fix slow tests
* update
* update
* updated model_path
* add args for weights
* set push_to_hub to false
* update
* update
* update
* update
* update
* update
* update
* update
* update
* update
* update
* update
* update
* update
---------
Co-authored-by: Dominic Rampas <d6582533@gmail.com >
Co-authored-by: Pablo Pernias <pablo@pernias.com >
Co-authored-by: Sayak Paul <spsayakpaul@gmail.com >
Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com >
Co-authored-by: YiYi Xu <yixu310@gmail.com >
Co-authored-by: 99991 <99991@users.noreply.github.com >
Co-authored-by: Dhruv Nair <dhruv.nair@gmail.com >
2024-03-06 15:07:25 +05:30
Jinay Jain
1bc0d37ffe
[bug] Fix float/int guidance scale not working in StableVideoDiffusionPipeline ( #7143 )
...
* [bug] Fix float/int guidance scale not working in `StableVideoDiffusionPipeline`
* Add test to disable CFG on SVD
---------
Co-authored-by: Sayak Paul <spsayakpaul@gmail.com >
2024-03-06 14:05:07 +05:30
bram-w
eb942b866a
SDXL Turbo support and example launch ( #6473 )
...
* support and example launch for sdxl turbo
* White space fixes
* Trailing whitespace character
* ruff format
* fix guidance_scale and steps for turbo mode
---------
Co-authored-by: Sayak Paul <spsayakpaul@gmail.com >
Co-authored-by: Radames Ajna <radamajna@gmail.com >
2024-03-06 11:51:01 +05:30
Michael
687bc27727
add TCD Scheduler ( #7174 )
...
* add: support TCD scheduler
---------
Co-authored-by: Sayak Paul <spsayakpaul@gmail.com >
2024-03-04 19:43:34 -10:00
iczaw
6246c70d21
[Community] PromptDiffusion Pipeline ( #6752 )
...
* Create promptdiffusioncontrolnet.py
* Update __init__.py
Added PromptDiffusionControlNetModel
* Update __init__.py
Added PromptDiffusionControlNetModel
* Update promptdiffusioncontrolnet.py
* Create pipeline_prompt_diffusion.py
Added Prompt Diffusion pipeline.
* Create convert_original_promptdiffusion_to_diffusers.py
* Update convert_from_ckpt.py
Added download_promptdiffusion_from_original_ckpt, convert_promptdiffusion_checkpoint
* Update promptdiffusioncontrolnet.py
* Update pipeline_prompt_diffusion.py
* Update README.md
* Update pipeline_prompt_diffusion.py
* Delete src/diffusers/models/promptdiffusioncontrolnet.py
* Update __init__.py
* Update __init__.py
* Delete scripts/convert_original_promptdiffusion_to_diffusers.py
* Update convert_from_ckpt.py
* Update README.md
* Delete examples/community/pipeline_prompt_diffusion.py
* Create README.md
* Create promptdiffusioncontrolnet.py
* Create convert_original_promptdiffusion_to_diffusers.py
* Create pipeline_prompt_diffusion.py
* Update README.md
* Update pipeline_prompt_diffusion.py
* Update README.md
* Update pipeline_prompt_diffusion.py
* Update convert_original_promptdiffusion_to_diffusers.py
* Update promptdiffusioncontrolnet.py
* Update README.md
---------
Co-authored-by: Sayak Paul <spsayakpaul@gmail.com >
2024-03-05 09:06:02 +05:30
Sayak Paul
577b8a2783
[Core] errors should be caught as soon as possible. ( #7203 )
...
errors should be caught as soon as possible.
2024-03-05 08:57:38 +05:30
Vinh H. Pham
13f0c8b219
[Docs] Update callback.md code example ( #7150 )
...
Update callback.md
Co-authored-by: Sayak Paul <spsayakpaul@gmail.com >
2024-03-05 08:44:19 +05:30
Aryan
fa1bdce3d4
[docs] Improve SVD pipeline docs ( #7087 )
...
* update svd docs
* fix example doc string
* update return type hints/docs
* update type hints
* Fix typos in pipeline_stable_video_diffusion.py
* make style && make fix-copies
* Update src/diffusers/pipelines/stable_video_diffusion/pipeline_stable_video_diffusion.py
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com >
* Update src/diffusers/pipelines/stable_video_diffusion/pipeline_stable_video_diffusion.py
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com >
* update based on suggestion
---------
Co-authored-by: M. Tolga Cangöz <mtcangoz@gmail.com >
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com >
2024-03-04 12:12:38 -08:00
