Jeff Trawick
7a8893fe32
spool_reqbody_cl(): mention in commentary that any data we
...
read into memory before reaching our threshold will not be
written to disk
tweak an existing comment, since "also" does not apply to
the situation where we chunk due to an environment variable
setting
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/proxy-reqbody@151147 13f79535-47bb-0310-9956-ffa450edef68
2005-02-03 12:03:54 +00:00
Jeff Trawick
f611a09378
pretty up some error log messages; include useful info
...
such as directory name and file name
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/proxy-reqbody@125089 13f79535-47bb-0310-9956-ffa450edef68
2005-01-13 19:01:19 +00:00
Jeff Trawick
761dee95bd
in memory of Greg's Grandma, fix another ungrammatical comment
...
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/proxy-reqbody@125000 13f79535-47bb-0310-9956-ffa450edef68
2005-01-12 23:21:50 +00:00
Greg Ames
d5bb484117
simplify
...
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/proxy-reqbody@124999 13f79535-47bb-0310-9956-ffa450edef68
2005-01-12 22:28:27 +00:00
Greg Ames
3964c8fac0
grammatical nit-pick
...
(can't help it...Grandma was an English teacher)
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/proxy-reqbody@124994 13f79535-47bb-0310-9956-ffa450edef68
2005-01-12 21:46:35 +00:00
Jeff Trawick
853ffd21c6
don't flush more than is necessary; this change keeps us
...
from writing small packets to the origin server when we're
streaming the request body
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/proxy-reqbody@124807 13f79535-47bb-0310-9956-ffa450edef68
2005-01-10 16:15:34 +00:00
Jeff Trawick
fe5fe7fa54
stick with the same bucket alloc (r->connection)
...
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/proxy-reqbody@124805 13f79535-47bb-0310-9956-ffa450edef68
2005-01-10 15:27:14 +00:00
Jeff Trawick
8c19c6c82e
create tmp files with names more like those of htpasswd and
...
htdigest
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/proxy-reqbody@124796 13f79535-47bb-0310-9956-ffa450edef68
2005-01-10 12:33:54 +00:00
Jeff Trawick
c4882b844e
watch out for "Content-Length: 0" more carefully; it has
...
to be handled a certain way
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/proxy-reqbody@124562 13f79535-47bb-0310-9956-ffa450edef68
2005-01-07 19:37:33 +00:00
Jeff Trawick
15da839a22
if last brigade of data received from client had data
...
and EOS, then input_brigade would be empty here
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/proxy-reqbody@124377 13f79535-47bb-0310-9956-ffa450edef68
2005-01-06 14:16:54 +00:00
Jeff Trawick
a65178039f
support extremely large request bodies by representing the
...
spool file with multiple file buckets, as with default handler
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/proxy-reqbody@124230 13f79535-47bb-0310-9956-ffa450edef68
2005-01-05 17:29:52 +00:00
Jeff Trawick
7fa15d74f1
the check for EOS isn't going to work if we already
...
deleted the eos; we ended up sending the last piece
of data from the client twice; I had (poorly) modified
the EOS section from the normal idiom to keep from having
to deal with the EOS later when reusing the input
brigade
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/proxy-reqbody@124220 13f79535-47bb-0310-9956-ffa450edef68
2005-01-05 15:25:12 +00:00
Jeff Trawick
168ee6cbfb
clean up the data that we just wrote to the spool file;
...
otherwise, very very nasty stuff happens when input brigade
with same contents is passed down to filters to grab more
body data
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/proxy-reqbody@124204 13f79535-47bb-0310-9956-ffa450edef68
2005-01-05 14:11:49 +00:00
Jeff Trawick
07c50805fb
Fix a problem in the path which preserves the input content
...
length; the header brigade would get lost
Submitted by: Allan Edwards
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/proxy-reqbody@124202 13f79535-47bb-0310-9956-ffa450edef68
2005-01-05 14:08:00 +00:00
Jeff Trawick
94d4653558
overhaul of HTTP proxy handling of request bodies to resolve
...
unlimited memory consumption issue with current 2.1.x
solution
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/proxy-reqbody@124201 13f79535-47bb-0310-9956-ffa450edef68
2005-01-05 14:00:57 +00:00
Graham Leggett
0dfcbc1ad8
Fix some compiler warnings inside the LDAP modules
...
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@124187 13f79535-47bb-0310-9956-ffa450edef68
2005-01-05 07:07:46 +00:00
Jean-Frederic Clere
af7e1482aa
Add including of util_charset.h otherwise ap_hdrs_from_ascii is not defined.
...
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@124080 13f79535-47bb-0310-9956-ffa450edef68
2005-01-04 09:58:01 +00:00
Mladen Turk
6ef95d4e37
Kill the pool cleanup when closing non cachable connection.
...
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@123884 13f79535-47bb-0310-9956-ffa450edef68
2005-01-02 08:00:26 +00:00
William A. Rowe Jr
d962fcfc8b
FINALLY Correct ap_http_method()! It is NOT a method, it's a SCHEME!
...
Bumped mmn, and ap module cookie, for this function rename.
It's not a deprecation, as ap_http_method would be a lovely function
name sometime in the future: to determine what the function name implies.
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@123882 13f79535-47bb-0310-9956-ffa450edef68
2005-01-02 05:33:44 +00:00
Mladen Turk
55230b229b
Fix closing connection for non-cachable proxies.
...
Do not close the entire connection, just socket if
opened.
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@123842 13f79535-47bb-0310-9956-ffa450edef68
2005-01-01 16:04:25 +00:00
Mladen Turk
def2248738
Close the connection for generic forward and
...
reverse proxy workers.
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@123840 13f79535-47bb-0310-9956-ffa450edef68
2005-01-01 15:23:51 +00:00
Mladen Turk
6d38243ac0
Simplify connection address and port resolving for non-cachable workers (gereric forward and reverse proxy).
...
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@123811 13f79535-47bb-0310-9956-ffa450edef68
2004-12-31 17:25:58 +00:00
Mladen Turk
81f6517752
Do not cache hostname and port for forward and
...
reverse generic proxy workers.
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@123809 13f79535-47bb-0310-9956-ffa450edef68
2004-12-31 17:01:05 +00:00
Jeff Trawick
d2c60589c6
mod_proxy: Fix a request corruption problem and a buffering problem
...
which sometimes prevented proxy-sendchunks from working.
strlen() couldn't be used since no space had been allocated
for trailing NUL, so occasionally the T-E header field contained
garbage and a 400 error would be returned by the origin server.
The lack of a flush bucket after the final "0\r\n\r\n" was a
showstopper for my simple tests (reverse proxy to Apache 1.3 +
custom module which read the body).
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@123727 13f79535-47bb-0310-9956-ffa450edef68
2004-12-30 16:31:13 +00:00
Bradley Nicholes
eb693a93ab
Add the modules/debug directory to the NetWare build
...
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@122559 13f79535-47bb-0310-9956-ffa450edef68
2004-12-16 18:29:30 +00:00
Bradley Nicholes
46e42b3752
Add NetWare make files
...
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@122558 13f79535-47bb-0310-9956-ffa450edef68
2004-12-16 18:28:05 +00:00
Bradley Nicholes
dc10cf7111
Clean up a type mismatch
...
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@122557 13f79535-47bb-0310-9956-ffa450edef68
2004-12-16 18:07:40 +00:00
Jim Jagielski
79419db65a
simplify the BalancerMember load factor weighting. Instead of
...
being percentages (and adjusting when the number don't add
up), loadfactors/lbfactors are now normalized values, so
values like:
worker a b c
lbfactor 1 1 2
work as expected (ie: a gets 25%, b gets 25% and c gets 50%).
So we could also have the above as:
worker a b c
lbfactor 25 25 50
or even
worker a b c
lbfactor 15 15 30
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@122551 13f79535-47bb-0310-9956-ffa450edef68
2004-12-16 14:09:30 +00:00
Joe Orton
c1f1265c2b
* modules/ssl/ssl_engine_io.c (bio_filter_out_flush): Revert the
...
passed-brigade-reuse "fix" which is currently unnecessary.
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@111962 13f79535-47bb-0310-9956-ffa450edef68
2004-12-15 11:17:22 +00:00
Joe Orton
d0127de8e8
* modules/ssl/ssl_engine_io.c (ssl_io_filter_cleanup): Fix segfaults
...
from using ap_log_cerror from a c->pool cleanup; the debug message
triggers too often anyway so just remove it.
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@111959 13f79535-47bb-0310-9956-ffa450edef68
2004-12-15 10:08:09 +00:00
André Malo
a68539be28
svn:eol-style = native
...
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@111895 13f79535-47bb-0310-9956-ffa450edef68
2004-12-14 23:01:47 +00:00
Cliff Woolley
a89bce3fd9
"transfered" is not a word.
...
s/transfered/transferred/g;
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@111858 13f79535-47bb-0310-9956-ffa450edef68
2004-12-14 18:58:25 +00:00
Jim Jagielski
ab03698a23
ignore
...
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@111852 13f79535-47bb-0310-9956-ffa450edef68
2004-12-14 18:42:15 +00:00
Jim Jagielski
ae092ca1ce
Add in mod_dumpio in the new debug module directory. Also, place
...
mod_bucketeer in there as well, since it is more a debugging
module (and as per list suggestions)
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@111837 13f79535-47bb-0310-9956-ffa450edef68
2004-12-14 17:04:58 +00:00
Jim Jagielski
0fb2f37f3e
grammatical parameter change... "readed" -> "read"
...
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@111830 13f79535-47bb-0310-9956-ffa450edef68
2004-12-14 16:08:55 +00:00
Mladen Turk
939710c063
Make proxy address cache thread safe and available only
...
to pooled workers.
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@111827 13f79535-47bb-0310-9956-ffa450edef68
2004-12-14 15:45:19 +00:00
Paul Querna
3afc45863a
* Style fixes only. No functional changes. Remove two tabs. Fix an If. Split a String.
...
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@111719 13f79535-47bb-0310-9956-ffa450edef68
2004-12-13 16:13:06 +00:00
Jim Jagielski
cad0958648
We are an int.
...
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@111712 13f79535-47bb-0310-9956-ffa450edef68
2004-12-13 13:47:29 +00:00
Jim Jagielski
2ce0fb01c5
Seems to me that if we have a worker which is usable, we
...
should return that. Otherwise we have no worker (worker
is NULL) and we should return that or else the if clause
takes care of setting worker correctly.
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@111711 13f79535-47bb-0310-9956-ffa450edef68
2004-12-13 13:40:25 +00:00
Geoffrey Young
78c1d9dc3e
undo changes made in 111386 due to veto
...
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@111432 13f79535-47bb-0310-9956-ffa450edef68
2004-12-09 21:09:26 +00:00
Geoffrey Young
fe1bfd7775
add response code 226 constant (HTTP_IM_USED) and status
...
line ("226 IM Used"). PR 31128.
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@111386 13f79535-47bb-0310-9956-ffa450edef68
2004-12-09 14:16:16 +00:00
Mladen Turk
f08674d77b
Set the connection addr from connection pool addres
...
since proxy_ftp does not use the determine_connection
call.
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@111359 13f79535-47bb-0310-9956-ffa450edef68
2004-12-09 08:07:27 +00:00
Bradley Nicholes
559d71ed95
* modules/arch/netware/mod_nw_ssl.c (ssl_io_filter_Upgrade): Simplify the
...
Upgrade header check; allow upgrades on any method; don't drop the
ap_pass_brigade return value.
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@111327 13f79535-47bb-0310-9956-ffa450edef68
2004-12-08 23:22:09 +00:00
Jeff Trawick
803d2b468d
mod_proxy: Respect errors reported by pre_connection hooks.
...
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@111304 13f79535-47bb-0310-9956-ffa450edef68
2004-12-08 20:19:04 +00:00
Joe Orton
1e5e7dd8a1
* modules/ssl/ssl_engine_kernel.c (ssl_callback_SSLVerify): Use
...
X509_STORE_CTX_get_ex_data() and SSL_get_ex_data_X509_STORE_CTX_idx()
to use the correct ex_data index from the context in pathological
cases where SSL_get_ex_data_X509_STORE_CTX_idx() does not return 0.
PR: 32529
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@111241 13f79535-47bb-0310-9956-ffa450edef68
2004-12-08 09:43:21 +00:00
Joe Orton
16bfea9b63
* modules/ssl/ssl_engine_io.c (ssl_io_filter_Upgrade): Simplify the
...
Upgrade header check; allow upgrades on any method; don't drop the
ap_pass_brigade return value.
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@111159 13f79535-47bb-0310-9956-ffa450edef68
2004-12-07 22:49:54 +00:00
Paul Querna
196fce4667
* mod_log_config.c: Revert r109866 which used apr_file_writev instead of an
...
apr_file_write w/ a memcpy. Roy Fielding provided a -1 veto
on the commit, based on concerns that writev is not
guaranteed to be atomic like a write.
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@110069 13f79535-47bb-0310-9956-ffa450edef68
2004-12-07 03:41:18 +00:00
Paul Querna
9d58018f5e
mod_log_config.c: Use iovecs to write the log line to eliminate a memcpy
...
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@109866 13f79535-47bb-0310-9956-ffa450edef68
2004-12-05 07:05:23 +00:00
Jeff Trawick
7eb243ba75
wrong format string was converted to APR_PID_T_FMT
...
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@109506 13f79535-47bb-0310-9956-ffa450edef68
2004-12-02 16:37:41 +00:00
Joe Orton
1bb2c214cd
* modules/filters/mod_deflate.c (deflate_out_filter): Check explicitly
...
for a 304 or 204 response rather than a brigade which begins with EOS,
to correctly handle such responses when generated by a CGI script.
Don't alter the headers for this case either.
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@109500 13f79535-47bb-0310-9956-ffa450edef68
2004-12-02 13:45:32 +00:00