This makes binaries far easier to debug, during operation and for post-crash
.dmp analysis. Do not alter /Gs optimizations per brane.
Reviewed by: stoddard, brane
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@170253 13f79535-47bb-0310-9956-ffa450edef68
internalise the ap_reg*<->PCRE wrapper:
* configure.in: Add srclib/pcre to the include path.
* include/ap_regex.h: Renamed from include/pcreposix.h. Prefix all
constants with AP_; prefix all functions and types with ap_. Define
AP_DECLARE to nothing if necessary. Remove regcomp error codes.
* include/httpd.h: Include ap_regex.h not pcreposix.h.
(ap_pregcomp, ap_regexec, ap_regfree): s/regex_t/ap_regex_t/.
(ap_regexec, ap_regerror): Prototypes moved to ap_regex.h.
* server/util.c (regex_cleanup, ap_pregcomp, ap_pregsub, ap_pregfree):
Adjust for ap_ prefixed types. (ap_regexec, ap_regerror): Removed.
* server/Makefile.in: Build util_pcre.c.
* server/util_pcre.c: Copied from srclib/pcre/pcreposix.c; remove use
of PCRE-internals to do error mapping; rename types to add AP_/ap_
prefixes as above. Use APR includes. (ap_regerror): Use apr_snprintf.
* srclib/pcre/Makefile.in: Don't build pcreposix.c into libpcre.la.
* modules/*: Update to use new type and constant names.
PR: 27750 (part one)
Submitted by: Andres Salomon <dilinger voxel.net>, Joe Orton
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@153384 13f79535-47bb-0310-9956-ffa450edef68
Bumped mmn, and ap module cookie, for this function rename.
It's not a deprecation, as ap_http_method would be a lovely function
name sometime in the future: to determine what the function name implies.
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@123882 13f79535-47bb-0310-9956-ffa450edef68
Also, take quick pass through docs files to remove experimental label for them.
Reviewed by: Paul Querna, Bill Stoddard, Justin Erenkrantz
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@106737 13f79535-47bb-0310-9956-ffa450edef68
mod_filter directives.
OR_OPTIONS for all but FilterTrace, which isn't allowed in htaccess,
because it could DoS the server (see docs).
We should consider to introduce an allowoverride filters or so.
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@105477 13f79535-47bb-0310-9956-ffa450edef68
teaching mod_cache's cache_select_url and cache_save_filter how to deal with
this corner case.
* modules/experimental/cache_storage.c
(cache_select_url): If we have a stale entry, save the handle so that
cache_save_filter can use it later, and make the request conditional.
* modules/experimental/cache_util.c
(ap_cache_request_is_conditional): Take in a table rather than request_rec.
* modules/experimental/mod_cache.c
(cache_out_filter): Fix bogus comment.
(cache_save_filter): If we have already responded to the client, block all
data; correctly merge in 'stale' handles that are not really stale; set
r->status where appropriate; serve cached response if 'fresh'
* modules/experimental/mod_cache.h
(cache_info): Add a status field.
(cache_request_rec): Add stale handle field and note we may block responses.
(ap_cache_request_is_conditional): Update prototype.
* modules/experimental/mod_disk_cache.c
(store_headers): Use cache_info status instead of r->status.
* modules/experimental/mod_mem_cache.c
(recall_headers): Properly recall the status field.
(store_headers): Store the status field via cache_info status.
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@105322 13f79535-47bb-0310-9956-ffa450edef68
than the data file. (We rename the tempfile when we're completed with the data
file which is an atomic operation.)
Part of the code assumed that it was using a temporary file; other parts
wrote directly to the body file - which was incorrect. So, clean up the
whole mess to be consistent and more correct.
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@105261 13f79535-47bb-0310-9956-ffa450edef68
Previously, if the cached copy was stale, the response would go into an
indeterminate state. Therefore, the freshness check must be done before we
'accept' the response and, if it fails (i.e. stale), we can't allow any side
effects.
This caused a number of changes to how mod_disk_cache reads its headers as
ap_scan_script_header_err() purposely has side-effects and that's
unacceptable. So, factor out only what we need.
Also, remove the broken conditional filter code as you can't reliably alter the
filter list once the response is started. (Regardless, cache_select_url()
has the freshness checks now.)
Assist to Sascha Schumann for reporting mod_cache was busted.
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@105236 13f79535-47bb-0310-9956-ffa450edef68
