From fdfbe46134594e4fa95897fa65dc3d319d190f4b Mon Sep 17 00:00:00 2001 From: Joe Orton Date: Fri, 9 Oct 2026 19:34:39 +0000 Subject: [PATCH] * .github/PULL_REQUEST_TEMPLATE.md: Tweak wording, request test cases based on pyhttpd. [skip ci] git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1938961 13f79535-47bb-0310-9956-ffa450edef68 --- .github/PULL_REQUEST_TEMPLATE.md | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 4a8d261284..1a158f36dd 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -3,12 +3,15 @@ --- -- [ ] This PR does not report or submit a patch for a security - vulnerability (see [`SECURITY.md`](/apache/httpd/blob/trunk/SECURITY.md) - and ). +- [ ] This PR does not report or address a security vulnerability + (see [`SECURITY.md`](/apache/httpd/blob/trunk/SECURITY.md) and + ). - [ ] Code follows the [httpd style guide](https://httpd.apache.org/dev/styleguide.html). - [ ] New log messages (level debug or higher) use an *empty* `APLOGNO()` tag; - numbers are assigned by a committer at merge time - (see `docs/log-message-tags/README`). + numbers are assigned by a committer at merge time (see `docs/log-message-tags/README`). - [ ] If the change is user-visible, a `changes-entries/*.txt` file is included, following the template in `README.CHANGES` (not needed otherwise). +- [ ] Test cases based on pyhttpd are included where appropriate, in the + `test/modules/xxx` directory matching the `modules/xxx` module source, + or `test/modules/core` for core server changes. On Unix, verify these + pass locally with e.g. `make check-pytest PYTEST_DIRS=test/modules/xxx`.