www/apache
1
0
Fork 0
mirror of https://github.com/apache/httpd.git synced 2025-08-05 16:55:50 +03:00
Code Activity

core, mod_rewrite: introduce the 'redirect-keeps-vary' note

Browse Source 
to allow proper Vary header insertion when
                   dealing with a RewriteRule in a directory
                   context.

This change is an attempt to fix a long standing problem,
brought up while working on PR 58231. Our documentation clearly
states the following:

"If a HTTP header is used in a condition this header is added
to the Vary header of the response in case the condition
evaluates to true for the request."

This is currently not true for RewriteCond/Rules working in
a directory context, since when an internal redirect happens
all the outstanding response headers get dropped.

There might be a better solution so I am looking forward to
hear more opinions and comments. My goal for a delicate change
like this one would be to affect the least amount of configurations
possible, without triggering unwanted side effects.

If the solution is good for everybody tests will be written
in the suite asap.



git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1811744 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Luca Toscano
2017-10-10 17:41:37 +00:00
parent 7e7cd5ee58
commit aeaabea3c2
3 changed files with 17 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
modules/http/http_request.c
View File

@@ -523,6 +523,7 @@ static request_rec *internal_internal_redirect(const char *new_uri,
request_rec *r) {
int access_status;
request_rec *new;
const char *vary_header;
if (ap_is_recursion_limit_exceeded(r)) {
ap_die(HTTP_INTERNAL_SERVER_ERROR, r);
@@ -586,6 +587,16 @@ static request_rec *internal_internal_redirect(const char *new_uri,
if (location)
apr_table_setn(new->headers_out, "Location", location);
}
/* A module (like mod_rewrite) can force an internal redirect
* to carry over the Vary header (if present).
*/
if (apr_table_get(r->notes, "redirect-keeps-vary")) {
if((vary_header = apr_table_get(r->headers_out, "Vary"))) {
apr_table_setn(new->headers_out, "Vary", vary_header);
}
}
new->err_headers_out = r->err_headers_out;
new->trailers_out = apr_table_make(r->pool, 5);
new->subprocess_env = rename_original_env(r->pool, r->subprocess_env);