www/apache
1
0
Fork 0
mirror of https://github.com/apache/httpd.git synced 2025-08-08 15:02:10 +03:00
Code Activity

avoid a call to X509_NAME_oneline() and ASN1_INTEGER_get() in

Browse Source 
ssl_callback_SSLVerify_CRL() unless SSLLogLevel >= info, otherwise the
expense is unused.
PR:
Obtained from:
Submitted by:
Reviewed by:


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@92238 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Doug MacEachern
2001-11-29 06:52:18 +00:00
parent 6259b77f33
commit 6dd4b15f65
1 changed files with 12 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
modules/ssl/ssl_engine_kernel.c
View File

@@ -1342,11 +1342,8 @@ int ssl_callback_SSLVerify_CRL(
X509 *xs; X509 *xs;
X509_CRL *crl; X509_CRL *crl;
X509_REVOKED *revoked; X509_REVOKED *revoked;
long serial;
BIO *bio; BIO *bio;
int i, n, rc; int i, n, rc;
char *cp;
char *cp2;
/* /*
* Unless a revocation store for CRLs was created we * Unless a revocation store for CRLs was created we
@@ -1407,6 +1404,9 @@ int ssl_callback_SSLVerify_CRL(
* (A little bit complicated because of ASN.1 and BIOs...) * (A little bit complicated because of ASN.1 and BIOs...)
*/ */
if (sc->nLogLevel >= SSL_LOG_TRACE) { if (sc->nLogLevel >= SSL_LOG_TRACE) {
char *cp;
char *cp2;
bio = BIO_new(BIO_s_mem()); bio = BIO_new(BIO_s_mem());
BIO_printf(bio, "lastUpdate: "); BIO_printf(bio, "lastUpdate: ");
ASN1_UTCTIME_print(bio, X509_CRL_get_lastUpdate(crl)); ASN1_UTCTIME_print(bio, X509_CRL_get_lastUpdate(crl));
@@ -1478,14 +1478,16 @@ int ssl_callback_SSLVerify_CRL(
#endif #endif
if (ASN1_INTEGER_cmp(revoked->serialNumber, X509_get_serialNumber(xs)) == 0) { if (ASN1_INTEGER_cmp(revoked->serialNumber, X509_get_serialNumber(xs)) == 0) {
serial = ASN1_INTEGER_get(revoked->serialNumber); if (sc->nLogLevel >= SSL_LOG_INFO) {
cp = X509_NAME_oneline(issuer, NULL, 0); char *cp = X509_NAME_oneline(issuer, NULL, 0);
ssl_log(s, SSL_LOG_INFO, long serial = ASN1_INTEGER_get(revoked->serialNumber);
"Certificate with serial %ld (0x%lX) "
"revoked per CRL from issuer %s",
serial, serial, cp);
free(cp);
ssl_log(s, SSL_LOG_INFO,
"Certificate with serial %ld (0x%lX) "
"revoked per CRL from issuer %s",
serial, serial, cp);
free(cp);
}
X509_STORE_CTX_set_error(ctx, X509_V_ERR_CERT_REVOKED); X509_STORE_CTX_set_error(ctx, X509_V_ERR_CERT_REVOKED);
X509_OBJECT_free_contents(&obj); X509_OBJECT_free_contents(&obj);
return FALSE; return FALSE;