mirror of
https://github.com/postfixadmin/postfixadmin.git
synced 2026-11-20 23:43:26 +03:00
* Add regression tests for global admin privilege check in TOTP exceptions (#1012) Verifies that global admins with both 'admin' and 'global-admin' roles can add TOTP exceptions for any domain, while regular admins are restricted to their managed domains. * Add tests for db_in_clause(): placeholders, empty array, unique keys, real query Covers the parameterized query refactor from PR #1004. * Move test cleanup to tearDown: add admin table delete and session unset Prevents state leaking between tests, especially when expectException() aborts the method before inline cleanup runs. * Use assertEquals with exact expected SQL per review
132 lines
3.8 KiB
PHP
132 lines
3.8 KiB
PHP
<?php
|
|
|
|
class DbBasicTest extends \PHPUnit\Framework\TestCase
|
|
{
|
|
private $test_domain;
|
|
|
|
public function setUp(): void
|
|
{
|
|
$db = db_connect();
|
|
$test_domain = 'test' . uniqid() . '.com';
|
|
$this->test_domain = $test_domain;
|
|
|
|
$db->exec("DELETE FROM domain WHERE domain = '$test_domain'");
|
|
}
|
|
public function testInsertDeleteDomain()
|
|
{
|
|
$domain = $this->test_domain;
|
|
|
|
$username = 'testusername' . uniqid();
|
|
|
|
$this->assertEquals(
|
|
1,
|
|
db_insert(
|
|
'domain',
|
|
array(
|
|
'domain' => $domain,
|
|
'description' => 'test',
|
|
'transport' => '',
|
|
'password_expiry' => 99
|
|
)
|
|
)
|
|
);
|
|
|
|
|
|
$this->assertEquals(1,
|
|
db_insert(
|
|
'mailbox',
|
|
array(
|
|
'username' => $username,
|
|
'password' => 'blah',
|
|
'name' => 'blah',
|
|
'maildir' => 'blah',
|
|
'local_part' => 'blah',
|
|
'domain' => $domain
|
|
)
|
|
)
|
|
);
|
|
|
|
$this->assertEquals(1,
|
|
db_update(
|
|
'mailbox',
|
|
'username',
|
|
$username,
|
|
array('name' => 'blah updated')
|
|
)
|
|
);
|
|
|
|
$ret = db_query_one("SELECT * FROM mailbox WHERE username = :username", array('username' => $username));
|
|
|
|
|
|
$this->assertTrue(!empty($ret));
|
|
$this->assertTrue(is_array($ret));
|
|
|
|
|
|
$this->assertEquals($ret['name'], 'blah updated');
|
|
|
|
$this->assertEquals(0, db_delete('mailbox', 'username', 'blahblahinvalid'));
|
|
|
|
$this->assertEquals(1, db_delete('mailbox', 'username', $username));
|
|
$this->assertEquals(1, db_delete('domain', 'domain', $domain));
|
|
}
|
|
|
|
/**
|
|
* Test db_in_clause() generates correct placeholders and params.
|
|
*/
|
|
public function testDbInClause()
|
|
{
|
|
$params = [];
|
|
$sql = db_in_clause('domain', ['example.com', 'test.org'], $params);
|
|
|
|
$this->assertEquals(' domain IN (:_in_0_0,:_in_1_1) ', $sql);
|
|
$this->assertEquals(['_in_0_0' => 'example.com', '_in_1_1' => 'test.org'], $params);
|
|
}
|
|
|
|
/**
|
|
* Test db_in_clause() with empty array returns safe false predicate.
|
|
*/
|
|
public function testDbInClauseEmpty()
|
|
{
|
|
$params = [];
|
|
$sql = db_in_clause('domain', [], $params);
|
|
|
|
$this->assertEquals(' 1=0 ', $sql);
|
|
$this->assertCount(0, $params);
|
|
}
|
|
|
|
/**
|
|
* Test db_in_clause() generates unique param keys when called multiple times.
|
|
*/
|
|
public function testDbInClauseUniqueKeys()
|
|
{
|
|
$params = [];
|
|
$sql1 = db_in_clause('domain', ['a.com'], $params);
|
|
$sql2 = db_in_clause('domain', ['b.com'], $params);
|
|
|
|
$this->assertEquals(' domain IN (:_in_0_0) ', $sql1);
|
|
$this->assertEquals(' domain IN (:_in_1_0) ', $sql2);
|
|
$this->assertEquals(['_in_0_0' => 'a.com', '_in_1_0' => 'b.com'], $params);
|
|
}
|
|
|
|
/**
|
|
* Test db_in_clause() actually works in a real query.
|
|
*/
|
|
public function testDbInClauseInQuery()
|
|
{
|
|
$domain = $this->test_domain;
|
|
db_insert('domain', ['domain' => $domain, 'description' => 'test', 'transport' => '']);
|
|
|
|
$params = [];
|
|
$in = db_in_clause('domain', [$domain, 'nonexistent.com'], $params);
|
|
$result = db_query_all("SELECT domain FROM " . table_by_key('domain') . " WHERE $in", $params);
|
|
|
|
$domains = array_column($result, 'domain');
|
|
$this->assertContains($domain, $domains);
|
|
$this->assertNotContains('nonexistent.com', $domains);
|
|
|
|
db_delete('domain', 'domain', $domain);
|
|
}
|
|
}
|
|
|
|
/* vim: set expandtab softtabstop=4 tabstop=4 shiftwidth=4: */
|