mirror of
https://github.com/postfixadmin/postfixadmin.git
synced 2026-11-20 23:43:26 +03:00
- treat recipient_delimiter as a set of alternative characters, matching Postfix semantics - centralize recipient-extension removal so alias status and mailbox classification cannot diverge - restrict delimiter matching to the local part and document multi-character configuration - add focused unit and alias-status regression coverage See #1143 Thanks @TrapoSAMA
101 lines
4.7 KiB
PHP
101 lines
4.7 KiB
PHP
<?php
|
|
|
|
class AliasDestinationStatusTest extends \PHPUnit\Framework\TestCase
|
|
{
|
|
private array $savedConfig;
|
|
|
|
protected function setUp(): void
|
|
{
|
|
global $CONF;
|
|
$this->savedConfig = $CONF;
|
|
$CONF['show_undeliverable'] = 'YES';
|
|
$CONF['show_undeliverable_color'] = 'tomato';
|
|
$CONF['show_external_color'] = 'lightblue';
|
|
$CONF['show_undeliverable_exceptions'] = ['exception.test'];
|
|
$CONF['vacation_domain'] = 'vacation.test';
|
|
$CONF['recipient_delimiter'] = '+';
|
|
$CONF['show_popimap'] = 'NO';
|
|
$CONF['show_vacation'] = 'NO';
|
|
$CONF['show_disabled'] = 'NO';
|
|
$CONF['password_expiration'] = 'NO';
|
|
$CONF['show_custom_domains'] = [];
|
|
|
|
foreach (['local.test', 'alias.test', 'private.test'] as $domain) {
|
|
db_insert('domain', ['domain' => $domain, 'description' => 'status test', 'transport' => '']);
|
|
}
|
|
}
|
|
|
|
protected function tearDown(): void
|
|
{
|
|
global $CONF;
|
|
$CONF = $this->savedConfig;
|
|
db_execute('DELETE FROM ' . table_by_key('alias'));
|
|
db_execute('DELETE FROM ' . table_by_key('alias_domain'));
|
|
db_execute('DELETE FROM ' . table_by_key('domain'));
|
|
}
|
|
|
|
private function alias(string $address, string $goto): void
|
|
{
|
|
db_execute('INSERT INTO ' . table_by_key('alias') . ' (address, goto, domain) VALUES (?, ?, ?)', [$address, $goto, explode('@', $address)[1]]);
|
|
}
|
|
|
|
private function renderStatus(string $goto, array $domains = ['local.test', 'alias.test']): string
|
|
{
|
|
db_execute('DELETE FROM ' . table_by_key('alias') . ' WHERE address = ?', ['source@local.test']);
|
|
$this->alias('source@local.test', $goto);
|
|
return gen_show_status('source@local.test', $domains);
|
|
}
|
|
|
|
public function testMissingLocalAndExternalDestinationsAreIndependent(): void
|
|
{
|
|
$local = $this->renderStatus('missing@local.test');
|
|
self::assertStringContainsString('background-color:tomato', $local);
|
|
self::assertStringNotContainsString('background-color:lightblue', $local);
|
|
$mixed = $this->renderStatus('missing@local.test, person@outside.test');
|
|
self::assertStringContainsString('background-color:tomato', $mixed);
|
|
self::assertStringContainsString('background-color:lightblue', $mixed);
|
|
}
|
|
|
|
public function testOtherAdministratorsRecordsDoNotAffectOutput(): void
|
|
{
|
|
$before = $this->renderStatus('person@private.test');
|
|
$this->alias('person@private.test', 'person@private.test');
|
|
self::assertSame($before, $this->renderStatus('person@private.test'));
|
|
self::assertStringContainsString('background-color:lightblue', $before);
|
|
self::assertStringNotContainsString('background-color:tomato', $before);
|
|
self::assertStringContainsString('background-color:lightblue', $this->renderStatus('missing@local.test', []));
|
|
}
|
|
|
|
public function testKnownRecipientsCatchallsAndExceptions(): void
|
|
{
|
|
$this->alias('person@local.test', 'person@local.test');
|
|
self::assertStringNotContainsString('background-color:', $this->renderStatus('person+tag@local.test'));
|
|
$this->alias('@local.test', 'person@local.test');
|
|
self::assertStringNotContainsString('background-color:', $this->renderStatus('anything@local.test'));
|
|
self::assertStringNotContainsString('background-color:', $this->renderStatus('person@exception.test,person@vacation.test'));
|
|
}
|
|
|
|
public function testMultipleRecipientDelimitersResolveToKnownRecipient(): void
|
|
{
|
|
global $CONF;
|
|
$CONF['recipient_delimiter'] = '+.';
|
|
$this->alias('person@local.test', 'person@local.test');
|
|
|
|
foreach (['person+tag@local.test', 'person.tag@local.test', 'person+tag.more@local.test'] as $destination) {
|
|
self::assertStringNotContainsString('background-color:', $this->renderStatus($destination));
|
|
}
|
|
}
|
|
|
|
public function testAliasDomainsRespectTargetPermissions(): void
|
|
{
|
|
db_execute('INSERT INTO ' . table_by_key('alias_domain') . ' (alias_domain, target_domain, active) VALUES (?, ?, ?)', ['alias.test', 'local.test', true]);
|
|
$this->alias('person@local.test', 'person@local.test');
|
|
self::assertStringNotContainsString('background-color:', $this->renderStatus('person@alias.test'));
|
|
self::assertStringContainsString('background-color:tomato', $this->renderStatus('missing@alias.test'));
|
|
$hidden = $this->renderStatus('person@alias.test', ['alias.test']);
|
|
db_execute('DELETE FROM ' . table_by_key('alias') . ' WHERE address = ?', ['person@local.test']);
|
|
self::assertSame($hidden, $this->renderStatus('person@alias.test', ['alias.test']));
|
|
self::assertStringContainsString('background-color:lightblue', $hidden);
|
|
}
|
|
}
|