Files
David Goodwin ae85e51f6e Security fixes (master only) (#1165)
Someone wishing to remain anonymous emailed @cboltz a number of security issues, summarised below.

1. fix sql injection bug in getPageBrowser - search keys bypass the field filter, due to 2a6f27c3 / #1127
2. when performing a password change, do not start the session before the new password has been validated for compexity etc - as things stand someone with a recovery code gets logged in even if their password gets
rejected. Also invalid recovery code on failure.
3. broadcast-message.php was using smtp_mail() with incorrect args, and passing the SMTP password in as the mail body. - probably related to commit 7f1d78e and 42a664e9c2
4. a regular (non-admin) user could submit an arbitrary username in the POST data and create/edit a TOTP exception for another user or entire domain

PR includes refactoring of the password change code (into PasswordChangeAttempt) to make it easier to test/verify.
2026-10-17 09:27:59 +01:00

80 lines
1.7 KiB
PHP

<?php
/**
* Postfix Admin
*
* LICENSE
* This source file is subject to the GPL license that is bundled with
* this package in the file LICENSE.TXT.
*
* Further details on the project are available at https://github.com/postfixadmin/postfixadmin
*
* @version $Id$
* @license GNU GPL v2 or later.
*
* File: sendmail.php
* Used to send an email to a user.
* Template File: sendmail.tpl
*
* Template Variables:
*
* tFrom
* tSubject
* tBody
*
* Form POST \ GET Variables:
*
* fTo
* fSubject
* fBody
*/
require_once('common.php');
authentication_require_role('admin');
$CONF = Config::getInstance()->getAll();
$smarty = PFASmarty::getInstance();
$PALANG = $CONF['__LANG'];
if ($CONF['sendmail'] == 'NO') {
header("Location: main.php");
exit;
}
$smtp_from_email = smtp_get_admin_email();
if ($_SERVER['REQUEST_METHOD'] == "POST") {
CsrfToken::assertValid(safepost('CSRF_Token'));
$fTo = safepost('fTo');
$fFrom = $smtp_from_email;
$fSubject = safepost('fSubject');
$tBody = $_POST['fBody'];
$error = 0;
$email_check = check_email($fTo);
if (empty($fTo) or ($email_check != '')) {
$error = 1;
flash_error($PALANG['pSendmail_to_text_error']); # TODO: superfluous?
flash_error($email_check);
}
if ($error != 1) {
if (!smtp_mail(to: $fTo, from: $fFrom, subject_or_data: $fSubject, body: $tBody)) {
flash_error(Config::lang_f('pSendmail_result_error', $fTo));
} else {
flash_info(Config::lang_f('pSendmail_result_success', $fTo));
}
}
}
$smarty->assign('smtp_from_email', $smtp_from_email);
$smarty->assign('smarty_template', 'sendmail');
$smarty->display('index.tpl');
/* vim: set expandtab softtabstop=3 tabstop=3 shiftwidth=3: */