Stored TOTP-exception and application-password descriptions bypass PFASmarty escaping on maintained 4.x, allowing mailbox-controlled markup to execute when a global administrator views the lists. Both controllers
now use the existing recursive HTML escaping so stored descriptions render as text, including records already in the database.
thanks @TrapoSAMA
Port the final merged behavior of #1150 to `postfixadmin_4.0`, completing the wording-only port in #1152 (discussion #886).
Alias destinations with no matching local record within the administrator's managed domains are marked red; destinations outside those domains are marked blue without inspecting another administrator's
records. Mixed destinations can show both indicators.
thanks @TrapoSAMA
when a user is part way through an MFA login (username/password auth done, but not the MFA bit),
authentication_get_username() will return their current username. This function is used in various other places
and historically it was a suitable check to determine if someone was also authenticated.
Commit updates authentication_get_username() to include a call to authentication_mfa_incomplete() by default, the only exclusion being on the login-mfa.php pages.
Thanks to Wenhao Wu (Southeast University) for the security report "MFA-incomplete (password-only) mailbox session can rewrite its own alias forwarding via /edit.php (CWE-308)"
Require a completed authenticated role for TOTP management and verify the current password before removing a TOTP secret.
See #1129 and #1128
thanks @TrapoSAMA
Require a validated canonical site_url for recovery links, keep responses uniform, and persist a five-minute per-account request limit.
This ports the behavior of PR #1130 while preserving PHP 7.4 compatibility and the 4.x database boolean handling.
Refs #1128
Thanks @TrapoSAMA
Reject password-only XML-RPC authentication for mailbox accounts that require TOTP while preserving existing behavior for accounts without TOTP.
This ports PR #1131 with PHP 7.4 compatibility and includes the documented XML-RPC/TOTP limitation requested during master review.
Refs #1128
thanks @TrapoSAMA
Restore default output sanitisation for viewlog records and replace the
inline JavaScript detail popup with native details markup.
This ports PR #1134 while preserving Smarty 3/4 and Bootstrap 3
compatibility.
Refs #1128
Thanks @TrapoSAMA
- port the password-expiration correction to `postfixadmin_4.0`
- make password expiration optional and disabled by default
- make 0 consistently mean that domain passwords do not expire
- validate whole-day policies from 0 through 36500
- align password-change paths and preserve the existing Login fallback
- show mailbox expiration states in lists and CSV output
- add the new labels to every 4.x language file
- document how to enable the feature in `config.local.php`
thanks @TrapoSAMA
fix regression in MySQL schema upgrade from 3.3 where vacation.domain, vacation.email and quota2.username had the wrong collation. (Thanks @TrapoSAMA + @knofte)
Restrict recreating $_SESSION to only those where the user has been logged in previously; this should help stop anonymous users from failing a CSRF check.
thanks @TrapoSAMA
This PR contains corrective UI and Spanish i18n fixes for the 4.0.x
branch.
Fixes included:
- Fix domain list layout stability by adding explicit column classes and
widths.
- Fix horizontal overflow in the domain list so wide tables remain
usable on smaller screens.
- Fix quota bar rendering consistency in domain and mailbox listings.
- Fix action buttons in list views by using compact icon buttons with
title and aria-label attributes.
- Fix top menu spacing and labels so the navigation remains readable in
constrained widths.
- Fix untranslated dashboard/global search labels by adding language
strings.
- Fix Spanish labels and wording used by the affected 4.0.x screens.
- Fix the total quota label shown in the domain list.
Thanks @TrapoSAMA
This backports the invalid-token/session-expired UX improvement to the 4.0 branch.
When a session expires and an old CSRF token is submitted, PostfixAdmin
currently shows a raw invalid token error.
This change renders a translated session-expired page instead, returning HTTP 419.
thanks @TrapoSAMA