Create and edit forms currently lack a Cancel action, making administrators and mailbox users rely on browser navigation or menus to abandon changes. The individual and broadcast mail composers have the
same gap.
thanks @TrapoSAMA
fixes potential XSS issue with TOTP exception lists (which need escaping, see also #1185).
refactors Template escaping to use TemplateEscape enum (rather than the previous boolean).
thanks @TrapoSAMA
Someone wishing to remain anonymous emailed @cboltz a number of security issues, summarised below.
1. fix sql injection bug in getPageBrowser - search keys bypass the field filter, due to 2a6f27c3 / #1127
2. when performing a password change, do not start the session before the new password has been validated for compexity etc - as things stand someone with a recovery code gets logged in even if their password gets
rejected. Also invalid recovery code on failure.
3. broadcast-message.php was using smtp_mail() with incorrect args, and passing the SMTP password in as the mail body. - probably related to commit 7f1d78e and 42a664e9c2
4. a regular (non-admin) user could submit an arbitrary username in the POST data and create/edit a TOTP exception for another user or entire domain
PR includes refactoring of the password change code (into PasswordChangeAttempt) to make it easier to test/verify.
- treat recipient_delimiter as a set of alternative characters, matching Postfix semantics
- centralize recipient-extension removal so alias status and mailbox classification cannot diverge
- restrict delimiter matching to the local part and document multi-character configuration
- add focused unit and alias-status regression coverage
See #1143
Thanks @TrapoSAMA
fix regression in smtp_mail() so only do SMTP AUTH if $CONF['admin_smtp_password'] is a non-empty string
(used by password recovery, broadcast message, mailbox post-creation etc)
Thanks @TrapoSAMA
Alias destinations absent from local records previously shared the misleading “maybe UNDELIVERABLE” indicator, including valid external addresses such as Gmail. The indicator now distinguishes “Check local destination” (red) from “External destination” (blue), with short explanatory tooltips. An alias with both kinds of destinations can show
both indicators.
thanks @TrapoSAMA
Unlimited mailboxes currently show only the unlimited label, hiding available usage.
Unlimited domain counters also lose their quota box, and the domain storage label continues to show assigned quota even when actual usage is available.
thanks @TrapoSAMA
Users changing their mailbox password currently hit an unprefixed `mailbox` table lookup when `database_prefix` is configured, causing the password change to fail even though authentication succeeds.
Fixes: #1154
thanks @masterblaster79
Show DNS status for domains to administrators.
Adds new config setting domain_dns_status_check ( 0 - disabled, 1 authoritative zone, 2 usable MX )
Document installation, an optional CLI/cron command, permissions, networking, timeouts, and saved-result semantics.
thanks @TrapoSAMA
The virtual-address overview currently shows a blank search box with
only a hard-coded English tooltip. Add a visible translated placeholder
and an accessible name: "Search mailboxes and aliases..." (Spanish:
"Buscar buzones y alias...").
thanks @TrapoSAMA
- require a completed user or admin role before opening TOTP management
- remove TOTP through the existing password-verifying change path
- keep configured post-change hooks active when a secret is removed
- add regression coverage proving an invalid password cannot remove the stored secret
This is the first focused change for #1128.
thanks @TrapoSAMA
- restore `md5crypt` as the PostfixAdmin 3.x-compatible alias for MD5-CRYPT
- verify stored unprefixed MD5-CRYPT, prefixed MD5-CRYPT, bcrypt, and SHA512 crypt hashes from their stored format
- document the canonical `MD5-CRYPT` setting, the legacy alias, and the 3.x upgrade implications
This addresses #1123 on `master`. The `postfixadmin_4.0` correction is in #1126 so each maintained branch can be reviewed and tested against its own PHP requirements.
thanks @TrapoSAMA
Limit the example Roundcube synchronization update to the selected user and disallow object instantiation while decoding stored preferences.
The script also validates its arguments and safely initializes malformed preference data.
Refs #1128
thanks @TrapoSAMA
Require a validated canonical site_url for recovery links, keep responses uniform, and persist a five-minute per-account request limit.
The token update is atomic across supported database engines and performs the same password hashing work for unknown accounts.
Refs #1128
thanks @TrapoSAMA
Render log records through the default output sanitization path and
remove the inline JavaScript interpolation of log data.
Full log data remains available through a native details element without
placing it in a script context.
Refs #1128
thanks @TrapoSAMA
When using dovecot: passwords, and calling the doveadm binary,, ignore stderr as long as the exit code is 0.
Switch _pacrypt_dovecot() to use the Exec class (instead of calling proc_popen directly).
fixes#1119
thanks @TrapoSAMA
- validate domain password-expiration policies as whole numbers from 0 through 36500 days
- make password expiration optional and disabled by default
- make 0 consistently mean that passwords in the domain do not expire
- align administrator, recovery, mailbox-user, and XML-RPC password changes
- show each mailbox password-expiration state in lists and CSV output
- add the new labels to every language file
- document how to enable the feature in `config.local.php`
thanks @TrapoSAMA
- distinguish the per-mailbox maximum quota error from insufficient remaining domain quota
- add the domain-quota error message to every language catalog
Thanks @TrapoSAMA
fix regression in MySQL schema upgrade from 3.3 where vacation.domain, vacation.email and quota2.username had the wrong collation.
thanks @TrapoSAMA + @Knofte
Adds a **Forward status: All / Active / Inactive** selector above the
alias (forwards) list in the domain overview (`list-virtual.php`).
see #1038, thanks @knofte
Adds an **"All domains"** option to the View Log domain dropdown, so an
admin managing many domains can see log entries across all of them in
one view instead of picking each domain individually.
Closes#1059.
Thanks @knofte
Adds a `description` field to the `alias` and `alias_domain` tables, so you can add a comment explaining why the alias exists.
Partially addresses #1036
thanks @jpwarren
Prepared statements were binding DB-specific boolean literals (`'t'/'f'`) produced by `db_get_boolean()`, which breaks PostgreSQL parameter typing in some paths (notably mailbox creation via handler flows).
This change standardizes bound boolean parameters to native PHP `true`/`false` (which are then cast to 0/1 which seems to work fine within PDO/PostgreSQL).
fixes https://github.com/postfixadmin/postfixadmin/issues/1017
* code refactoring (adds Exec class to centralise proc_open like calls).
* bump phpunit to ^11.0, as this is the last release that supports php8.2. Note, there is not (yet?) a phpunit release for php8.2 that fixes PKSA-z3gr-8qht-p93v or PKSA-5jz8-6tcw-pbk4, so ignore them for now in composer.json
* Add regression tests for global admin privilege check in TOTP exceptions (#1012)
Verifies that global admins with both 'admin' and 'global-admin' roles
can add TOTP exceptions for any domain, while regular admins are
restricted to their managed domains.
* Add tests for db_in_clause(): placeholders, empty array, unique keys, real query
Covers the parameterized query refactor from PR #1004.
* Move test cleanup to tearDown: add admin table delete and session unset
Prevents state leaking between tests, especially when expectException()
aborts the method before inline cleanup runs.
* Use assertEquals with exact expected SQL per review
possible fix for https://github.com/postfixadmin/postfixadmin/issues/967
CSRF Token changes : rather than have one PFA_Token value in $_SESSION, store a list of them, where each value has a time stamp it was issued on. The aim is to allow the user to have multiple browser tabs open at once - and not have the last tab that loaded trample on others. Tokens expire after 1 hour.
Adds a Smarty helper function `{CSRF_Token}` which will output `<input type=hidden name=CSRF_Token value=asdf123>` or `{CSRF_Token type=url}` which outputs a literal string like 'asdf123' suitable for placing in a URL.
Adds a PHP exception handler in public/common.php, which could be used to display a more friendly error message/response (but at the moment is fairly minimal).
Removes most uses of `die()` within the codebase, and instead moves to throw an exception