Commit Graph
23 Commits
Author SHA1 Message Date
Rodrigo Cortés Cano 3feeb081af Escape security lists and make template escaping opt-outs explicit (#1172)
fixes potential XSS issue with TOTP exception lists (which need escaping, see also #1185). 

refactors Template escaping to use TemplateEscape enum (rather than the previous boolean).

thanks @TrapoSAMA
2026-11-01 10:41:54 +00:00
Rodrigo Cortés Cano ca76931f06 Allow configurable mailbox user display-name editing (#1177)
add config setting edit_mailbox_name which can be set to allow users to change their name. 

https://github.com/postfixadmin/postfixadmin/issues/1176#issuecomment-6061535053

Thanks @TrapoSAMA & @pvdv
2026-10-15 19:23:51 +01:00
8ctopus a2d5a5a94d Fix smarty template did not have noindex (#1161)
discourage search engines from indexing postfixadmin 

thanks @8ctopus
2026-09-25 08:55:59 +01:00
David Goodwin 1b55dc96e4 security updates (smarty, phpunit)
move to use smarty/smarty ^5.8.4 (see https://github.com/postfixadmin/postfixadmin/security/dependabot/2),
use phpunit ^11.5.50
use only psalm 6
2026-08-16 10:28:44 +01:00
David Goodwin 8a1f9a11af CSRF protection - support multiple tokens (#985)
possible fix for https://github.com/postfixadmin/postfixadmin/issues/967

CSRF Token changes : rather than have one PFA_Token value in $_SESSION, store a list of them, where each value has a time stamp it was issued on. The aim is to allow the user to have multiple browser tabs open at once - and not have the last tab that loaded trample on others. Tokens expire after 1 hour.

Adds a Smarty helper function `{CSRF_Token}` which will output `<input type=hidden name=CSRF_Token value=asdf123>` or `{CSRF_Token type=url}` which outputs a literal string like 'asdf123' suitable for placing in a URL.

Adds a PHP exception handler in public/common.php, which could be used to display a more friendly error message/response (but at the moment is fairly minimal).

Removes most uses of `die()` within the codebase, and instead moves to throw an exception
2026-03-01 19:30:16 +00:00
Christian Boltz d50d171914 Fix 404 when loading css etc. for admins
For admins, the relative path to css etc. is '', not '../'
2025-09-11 21:56:35 +02:00
David Goodwin cb12b6f3ec formatting 2025-04-21 19:33:48 +01:00
David Goodwin ee3329a91c i think this is an actual fix for #913 - add a htmlentities_no_double_encode modifier to smarty and use it to hopefully escape the itemkey variable... 2025-04-11 09:56:56 +01:00
David Goodwin c8bf8ec642 register htmlentities earlier, although i do not think this changes anything 2025-04-11 09:26:42 +01:00
David Goodwin 8ec9140673 fix: "PHP Deprecated: Using unregistered function "htmlentities" in a template..." from Smarty, see https://github.com/postfixadmin/postfixadmin/issues/872 2024-11-22 20:28:34 +00:00
David Goodwin 5a14f4bc1f this might be a more logical approach - only try and call htmlentities on things that are stringy or arrays 2022-08-29 08:35:54 +01:00
David Goodwin f760d2cd3a to not try to sanitise a null - see https://github.com/postfixadmin/postfixadmin/issues/650 2022-08-28 15:01:47 +01:00
Fredrik Falk 9e73025058 Add Domain Key handling 2022-06-23 20:40:06 +02:00
David Goodwin 2edabc3e03 phpcs insists on some brace changes 2021-04-13 21:19:16 +01:00
David Goodwin 823f27b29d phpcs wants to change ... 2021-03-22 09:28:28 +00:00
David Goodwin e3269b62d9 fix formatting 2021-01-26 21:39:11 +00:00
David Goodwin 92fd05cb5d do not worry about escaping an object 2021-01-26 20:42:28 +00:00
David Goodwin da7607c9c5 see #429 - check for some CONF keys before trying to use them 2021-01-23 16:55:41 +00:00
David Goodwin 431d885e4e see: //github.com/postfixadmin/postfixadmin/issues/410 - ignore theme_css if it points to css/default.css; drop css/default.css 2021-01-09 19:43:43 +00:00
David Goodwin f79351aaee composer format 2021-01-08 15:53:55 +00:00
David Goodwin c7850b78eb fix bootstrap theme for users/ urls; make some other links use https. 2021-01-07 20:34:06 +00:00
David Goodwin d83b287297 rejig smarty 2020-09-28 20:33:21 +01:00
David Goodwin 8be966d0bb allow the template to be destroyed 2020-09-27 10:52:19 +01:00