Commit Graph
11 Commits
Author SHA1 Message Date
Kent Riboe 650a91bd05 Improve DKIM: auto-generate keypair, descriptive signing table (#1029)
Implements the improvements suggested by @fredkilbourn in #1024, cleaned up for current master.

**Changes:**

1. **Auto-generate RSA 2048 keypair** when creating a new DKIM key. Only
generates on the create form, not on list views or edits.

2. **Descriptive signing table dropdown** shows `domain:selector
(description) [id]` instead of just the numeric ID.

3. **Domain:Selector and Description columns** in the signing table list
view via LEFT JOIN.

4. **Order by domain:selector** instead of raw dkim_id.

**Technical notes:**
- Uses `$this->new` check to avoid key generation overhead on list/edit
views
- Handles MySQL (`CONCAT()`) vs SQLite/PostgreSQL (`||`) string
concatenation
- Uses named arguments for `pacol()` per current conventions

Two separate commits. Credit to @fredkilbourn for the original patch.
2026-05-23 14:41:13 +01:00
Kent Riboe 8e6a4f0f4b Add developer documentation for Handler classes, update PFAHandler::pacol() params (#1008)
Add DOCUMENTS/HANDLER_CLASSES.md which attempts to document how the Handler classes work and help future developers/contributors. 

Changes spec of PFAHandler::pacol() to discourage the 9th parameter (was: multiopt) from being passed as an array (param renamed to not_in_db). Previous behaviour is maintained, but a deprecation error should be triggered.
2026-04-18 10:10:00 +01:00
David Goodwin b092017f9b be more explict over what types class properties should be 2026-01-28 09:50:26 +00:00
David Goodwin 0d5edbf099 move pacol() into PFAHandler class, I think it makes more sense for it to be there given the dependency between the two 2025-07-13 10:12:22 +01:00
David Goodwin f01274ec94 try relaxing composer dependencies to allow php8.2 dev support, reformat so composer format passes 2024-04-22 21:02:01 +01:00
David Goodwin c422a4bad2 see #808 - db_log expects 3 strings ... make sure we do not pass in a null 2024-03-08 11:46:14 +00:00
Christian Boltz 4b8027e8e3 rename 'txtlarge' field type to 'txta'
... (think "textarea") to keep the field type name short.

This is a follow-up up https://github.com/postfixadmin/postfixadmin/pull/631#issuecomment-1188336564
2022-07-23 21:22:49 +02:00
Christian Boltz 6a53b1ab88 Drop duplicate db_delete() call from DkimHandler
... and DkimsigningHandler

The hardcoded name is the same as $this->db_table, which effectively
means running the same query twice. One of them is enough.
2022-07-18 22:57:55 +02:00
Christian Boltz 9ec3196c6d Whitespace fixes 2022-07-18 22:55:24 +02:00
David Goodwin b55457d978 composer format 2022-07-18 08:55:34 +01:00
Fredrik Falk 9e73025058 Add Domain Key handling 2022-06-23 20:40:06 +02:00