Commit Graph
481 Commits
Author SHA1 Message Date
David Goodwin c422a4bad2 see #808 - db_log expects 3 strings ... make sure we do not pass in a null 2024-03-08 11:46:14 +00:00
David Goodwin eda637df1a Merge branch 'master' into michaelkrieger-patch-1 2024-01-11 08:51:17 +00:00
John Fawcett 668960ccf6 Add a flag to mailbox table for enable/disable smtp protocol. The table column name
is "smtp_active". This enables use of this flag instead of active flag for postfix
mysql queries. There is a new configuration parameter $CONF['smtp_active_flag'] =
YES or NO, which defaults to NO, providing the existing behaviour. When set to YES
the active_smtp field is displayed in the edit mode and can be modified.
The commit includes update to the language files and documentation.

The commit does not include the code to add the field to existing installs,
which I presume can be added during the release cycle in upgrade.php along the
lines of:

_db_add_field('mailbox',  'smtp_active', 'int DEFAULT 1');
2024-01-09 20:50:49 +01:00
David Goodwin 6e6e4301ed an empty check would catch null ... while != "" will also match null it feels wrong 2024-01-05 19:31:54 +00:00
David Goodwin 6b5801c666 typo fixes 2024-01-05 19:30:16 +00:00
David Goodwin 39e378c783 improve type hinting 2023-12-27 16:17:55 +00:00
David Goodwin dc792a0222 add unit test to cover some of Login::addAppPassword() 2023-12-27 16:17:55 +00:00
David Goodwin 8003978ca5 type hints etc and todo notes 2023-12-23 21:55:50 +00:00
David Goodwin 824ba906b1 more type hints 2023-12-23 21:49:57 +00:00
David Goodwin 4d6767cc37 avoid sql injection 2023-12-23 21:47:57 +00:00
David Goodwin 015d4ec9cd reindent / reformat; add type hints for some of the app password stuff; try and make sure someone can only remove their own app password (see revokeAppPassword() ) 2023-12-23 21:43:31 +00:00
David Goodwin 4d17aa6ef9 manaul merge in of verdigado:master (see #753) (MFA/TOTP support) 2023-12-23 17:05:52 +00:00
Fredrik Boström ea121c721b Add Alert() about illegal character in username 2023-09-26 15:27:24 +02:00
Fredrik Boström 7b8532b2b0 Add javascript check for illegal characters in username
Signed-off-by: Fredrik Boström <fredrik.bostroem@verdigado.com>
2023-09-26 14:12:33 +02:00
David Goodwin 7a99861802 Merge pull request #665 from Jan-Kruis/master
small correction
2022-10-12 20:37:13 +01:00
David Goodwin 8cc19b0adf add @todo for php-imap.com - see also #656 2022-10-12 20:28:53 +01:00
Jan Kruis e279c77ca5 languages/nl.lang translation from english for new function such as dkim and password
public/editactive.php			edit wrong description text it said this module is used for deleting admin domains mailbos etc
					modify templates that it is used

public/list-virtual.php			modify templates that it is used
					modify the remarks behind arguments and internal , the texteditor thought the text after this was still remark text untl is see */

public/vacation.php and
model/VacantionHandel.php		adjust date string actionFrom and activeUntil these are written in the database as e.g. 2020-10-01 15:14:00 and 2020-10-30-15:14:00
					this should be 2020-10-01 00:00:00 and 2020-10-30 23:59:59 so that it contains all day, this happens if no holiday has been set for the account yet
					when adjusting the dates, the seconds of until are set to 00 instead of 59. When the holiday is canceled and then action is taken again, the from time
					to the time when the setting is made.

templates/editform.tpl			remove blank space

templates/list-virtual_mailbox.tpl	remove indent tabs
2022-10-12 17:46:15 +02:00
David Goodwin 5a14f4bc1f this might be a more logical approach - only try and call htmlentities on things that are stringy or arrays 2022-08-29 08:35:54 +01:00
David Goodwin f760d2cd3a to not try to sanitise a null - see https://github.com/postfixadmin/postfixadmin/issues/650 2022-08-28 15:01:47 +01:00
Christian Boltz 4b8027e8e3 rename 'txtlarge' field type to 'txta'
... (think "textarea") to keep the field type name short.

This is a follow-up up https://github.com/postfixadmin/postfixadmin/pull/631#issuecomment-1188336564
2022-07-23 21:22:49 +02:00
Christian Boltz 6a53b1ab88 Drop duplicate db_delete() call from DkimHandler
... and DkimsigningHandler

The hardcoded name is the same as $this->db_table, which effectively
means running the same query twice. One of them is enough.
2022-07-18 22:57:55 +02:00
Christian Boltz 9ec3196c6d Whitespace fixes 2022-07-18 22:55:24 +02:00
David Goodwin b55457d978 composer format 2022-07-18 08:55:34 +01:00
David Goodwin d3e101e9d8 Merge remote-tracking branch 'origin/master' into feature/dkim 2022-07-18 08:55:07 +01:00
David Goodwin 38549c48ad composer format 2022-07-17 21:16:47 +01:00
Adrien Crivelli 80e500591f Avoid deprecation in PHP 8.1 2022-07-15 11:44:58 +02:00
Adrien Crivelli a97771adfd Automatic code style fixes 2022-07-15 11:29:55 +02:00
David Goodwin 2d6ded2786 PSR2 -> PSR12 formatting 2022-06-28 13:46:11 +01:00
Fredrik Falk 9e73025058 Add Domain Key handling 2022-06-23 20:40:06 +02:00
David Goodwin 35486a2ca9 remove dead code 2022-06-06 20:35:53 +01:00
David Goodwin c240cb0033 reformat 2022-02-13 20:40:34 +00:00
Oliver Cooper b4028bd309 Add Mailbox quota translations 2022-02-13 18:01:36 +00:00
benchea dan 51673118bb Update PFACrypt.php
if you have old hashes like $nr$salt$hash and you migrate to {algoithm}hash
2022-02-09 10:39:15 +02:00
David Goodwin 422daf6c44 see #567 - missed SHA512-CRYPT 2021-11-30 10:48:06 +00:00
David Goodwin 0b9b7db917 Merge remote-tracking branch 'origin/master' into feature-improve-pacrypt 2021-09-29 18:04:49 +01:00
BotoX 768f2ee844 Improve dovecot mail-crypt postpassword script security (pipe password instead of passing on cmdline)
Suggested from: https://github.com/postfixadmin/postfixadmin/issues/441#issuecomment-774736944
2021-06-13 12:24:27 +02:00
David Goodwin 4c6c857e3e Merge pull request #500 from vakartel/patch-1
model/AdminpasswordHandler.php :: eliminate php waring
2021-06-02 11:26:36 +01:00
David Goodwin 033b70abcd Merge pull request #501 from vakartel/patch-2
model/MailboxHandler.php :: eliminate php warning
2021-06-02 11:26:27 +01:00
David Goodwin 961124fae4 Merge pull request #502 from vakartel/patch-3
model/AliasdomainHandler.php :: eliminate php warning
2021-06-02 11:26:17 +01:00
Valery Kartel f392024784 Update VacationHandler.php 2021-06-02 13:25:02 +03:00
Valery Kartel d54754097f Update AliasdomainHandler.php 2021-06-02 13:24:11 +03:00
Valery Kartel ae0d9436b5 Update MailboxHandler.php 2021-06-02 13:13:40 +03:00
Valery Kartel b075544c66 Update AdminpasswordHandler.php 2021-06-02 13:13:00 +03:00
David Goodwin 659b242b59 merge fix 2021-05-15 21:28:19 +01:00
David Goodwin 5a305bc830 allow vacation settings to include a time (but specify a time if one is not), this should stop us overwriting the time - see https://sourceforge.net/p/postfixadmin/discussion/676076/thread/5637ae3bc5/?limit=25#24a5 2021-05-13 16:16:22 +01:00
David Goodwin 8518d53906 merge postfixadmin_3.3 into master 2021-05-13 13:15:27 +01:00
David Goodwin 584e4ef41d type hinting changes 2021-05-13 12:56:38 +01:00
Andrey Miroshnichenko 0ebb006888 Adds an ability to update password_expity field when user changes own password 2021-05-13 00:23:05 +03:00
David Goodwin 1a63ee6c5d might fix tests 2021-05-11 22:05:36 +01:00
David Goodwin 179dd4c6e2 try and improve hashing, remove duplicate code, try and cope with the algorithm/method in $pw_db being different from the configured one; add tests 2021-05-11 21:56:48 +01:00