From bfe0b8cfd0fe5aff9bf74be08b2ee5e72748213c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rodrigo=20Cort=C3=A9s=20Cano?= <38475681+TrapoSAMA@users.noreply.github.com> Date: Wed, 22 Jul 2026 03:51:38 -0400 Subject: [PATCH] Avoid restarting anonymous login sessions on 4.x (#1086) Restrict recreating $_SESSION to only those where the user has been logged in previously; this should help stop anonymous users from failing a CSRF check. thanks @TrapoSAMA --- public/login.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/public/login.php b/public/login.php index 474c51e4..78dd97ab 100644 --- a/public/login.php +++ b/public/login.php @@ -101,7 +101,9 @@ if ($_SERVER['REQUEST_METHOD'] == "POST") { error_log("PostfixAdmin admin login failed (username: $fUsername, ip_address: {$_SERVER['REMOTE_ADDR']})"); flash_error($PALANG['pLogin_failed']); } -} else { +} elseif (isset($_SESSION['sessid'])) { + // Do not restart anonymous sessions while rendering the login form. + // An existing authenticated session should still be cleared before login. session_unset(); session_destroy(); session_start();