From bd41cf169306eb225c1f5aeaf68bda6dc6ede3a3 Mon Sep 17 00:00:00 2001 From: Christian Boltz Date: Tue, 31 May 2011 21:47:02 +0000 Subject: [PATCH] edit-domain.php: - changed UPDATE query to db_update() This should also fix https://sourceforge.net/tracker/?func=detail&aid=3306933&group_id=191583&atid=937964 - replaced various isset($_POST[...]) with safepost() calls git-svn-id: https://svn.code.sf.net/p/postfixadmin/code/trunk@1064 a1433add-5e2c-0410-b055-b7f2511e0802 --- edit-domain.php | 42 +++++++++++++++++++++--------------------- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/edit-domain.php b/edit-domain.php index b1493671..388f2232 100644 --- a/edit-domain.php +++ b/edit-domain.php @@ -59,19 +59,12 @@ if ($_SERVER['REQUEST_METHOD'] == "POST") { if (isset ($_GET['domain'])) $domain = escape_string ($_GET['domain']); - if (isset ($_POST['fDescription'])) $fDescription = escape_string ($_POST['fDescription']); - if (isset ($_POST['fAliases'])) $fAliases = intval($_POST['fAliases']); - if (isset ($_POST['fMailboxes'])) $fMailboxes = intval($_POST['fMailboxes']); - if (isset ($_POST['fMaxquota'])) { - $fMaxquota = intval($_POST['fMaxquota']); - } else { - $fMaxquota = 0; - } - if (isset ($_POST['fDomainquota'])) { - $fDomainquota = intval($_POST['fDomainquota']); - } else { - $fDomainquota = $CONF['domain_quota_default']; - } + $fDescription = safepost('fDescription'); + $fAliases = (int) safepost('fAliases'); + $fMailboxes = (int) safepost('fMailboxes'); + $fMaxquota = (int) safepost('fMaxquota', 0); + $fDomainquota = (int) safepost('fDomainquota', $CONF['domain_quota_default']); + # TODO: check for / error out on values < -1 $fTransport = $CONF['transport_default']; if($CONF['transport'] != 'NO' && isset ($_POST['fTransport'])) { @@ -102,19 +95,26 @@ if ($_SERVER['REQUEST_METHOD'] == "POST") $sqlActive = db_get_boolean(False); } - $sqltransport = ""; + $db_values = array( + 'description'=> $fDescription, + 'aliases' => $fAliases, + 'mailboxes' => $fMailboxes, + 'maxquota' => $fMaxquota, + 'quota' => $fDomainquota, + 'backupmx' => $sqlBackupmx, + 'active' => $sqlActive, + ); + if($CONF['transport'] != 'NO') { # only change transport if it is allowed in config. Otherwise, keep the old value. - $sqltransport = "transport='$fTransport',"; + $db_values['transport'] =$fTransport; } - $result = db_query ("UPDATE $table_domain SET description='$fDescription',aliases=$fAliases,mailboxes=$fMailboxes,maxquota=$fMaxquota,quota=$fDomainquota,$sqltransport backupmx='$sqlBackupmx',active='$sqlActive',modified=NOW() WHERE domain='$domain'"); - if ($result['rows'] == 1) - { + $result = db_update('domain', 'domain', $domain, $db_values); + + if ($result == 1) { header ("Location: list-domain.php"); exit; - } - else - { + } else { $tMessage = $PALANG['pAdminEdit_domain_result_error']; } }