From 5870a1946f1bfbcdba133d3c847484fa921f8f97 Mon Sep 17 00:00:00 2001 From: David Goodwin Date: Fri, 21 Feb 2025 09:11:02 +0000 Subject: [PATCH] tighten up the cookie used by postfixadmin for PHP sessions - add samesite, httponly and perhaps secure flags, see #903, thanks @gitblacker --- common.php | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/common.php b/common.php index b45522d3..df71b77b 100644 --- a/common.php +++ b/common.php @@ -21,6 +21,18 @@ if (!defined('POSTFIXADMIN')) { # already defined if called from setup.php if (!defined('POSTFIXADMIN_CLI')) { // this is the default; see also https://sourceforge.net/p/postfixadmin/bugs/347/ session_cache_limiter('nocache'); + + /** + * @see https://github.com/postfixadmin/postfixadmin/issues/903 + */ + $cookie_params = session_get_cookie_params(); + $cookie_params['samesite'] = 'Strict'; + $cookie_params['httponly'] = true; + // Is this worthwhile? a non https request will get a non 'secure' cookie. + if(isset($_SERVER['HTTPS']) && $_SERVER['HTTPS'] == 'on') { + $cookie_params['secure'] = true; + } + session_set_cookie_params($cookie_params); session_name('postfixadmin_session'); session_start();