webapp/phpmyadmin
1
0
Fork 0
mirror of https://github.com/phpmyadmin/phpmyadmin.git synced 2026-10-29 21:24:44 +03:00
Code Activity
125,212 Commits 12 Branches 481 Tags
fd52b85eed3ff9d470787ba2b59674bb7f262f82
Commit Graph

312 Commits

Author SHA1 Message Date
Kamil Tekiela
fd52b85eed Microoptimization of fetchResult() 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-12-19 19:30:13 +00:00
Kamil Tekiela
dd699f348d Clean up LIKE escaping 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-11-25 00:06:52 +00:00
Maurício Meneghini Fauth
e194eb3961 Improve type DatabaseInterface's $link params 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-21 14:50:52 -03:00
Maurício Meneghini Fauth
ca489f3b41 Improve type of DatabaseInterface::getLowerCaseNames() 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-19 15:50:14 -03:00
Maurício Meneghini Fauth
219a665c8f Improve type of DatabaseInterface::getCurrentUserGrants() 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-19 15:50:14 -03:00
Maurício Meneghini Fauth
3ec0a92a0b Improve type inference of getCurrentUserAndHost() 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-19 13:05:23 -03:00
Maurício Meneghini Fauth
3c26a938cb Add better type inference for DatabaseInterface::$links 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-18 21:36:38 -03:00
Maurício Meneghini Fauth
d0d90551c3 Remove the dblist global variable 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-13 21:08:00 -03:00
Kamil Tekiela
3b49a5bedb Implement quoteString() 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-11-06 19:06:48 +00:00
Kamil Tekiela
95a93ba909 Minor stylistic changes (#17865) 
* Stylistic changes to make refactoring easier
* Parameter $where was unnecessarily nullable
* Refactor Routines::getDetails()
* Refactor Events::getDetails()
* Refactor Triggers::getDetails()
* Split up QueryGenerator::getInformationSchemaColumnsFullRequest

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-11-05 12:55:44 -03:00
Maurício Meneghini Fauth
103968f352 Replace fatalError() with exception in Core::warnMissingExtension() 
Also moves some other calls to Core::warnMissingExtension() to the
Common::checkRequiredPhpExtensions() method.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-10-31 20:25:55 -03:00
William Desportes
d82b43c5ff Fixup testGetMySQLDocuURL after changing setVersion() in DBI 
and fix a phpc issue

See: cac09436c9

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-10-13 20:38:12 +02:00
William Desportes
fd13e506d0 Fixup tests and DBI after changing setVersion() in DBI 
Signed-off-by: William Desportes <williamdes@wdes.fr>

See: cac09436c9
 2022-10-13 20:28:32 +02:00
William Desportes
6da193304f Merge branch 'QA_5_2' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-10-13 20:13:48 +02:00
Mo Sureerat
a07474f997 Handle array re-index + fix setVersion logic + hardcode version int 
Signed-off-by: Mo Sureerat <sureemo@gmail.com>
 2022-10-11 17:32:03 +07:00
Mo Sureerat
9ff395e888 Fix type 
Signed-off-by: Mo Sureerat <sureemo@gmail.com>
 2022-10-11 13:40:20 +07:00
Mo Sureerat
d97df6c00b Define type 
Signed-off-by: Mo Sureerat <sureemo@gmail.com>
 2022-10-11 13:12:07 +07:00
Mo Sureerat
cac09436c9 Rewrite method to set database info 
Signed-off-by: Mo Sureerat <sureemo@gmail.com>
 2022-10-11 13:01:19 +07:00
Mo Sureerat
7ea0a95646 Update code style 
Signed-off-by: Mo Sureerat <sureemo@gmail.com>
 2022-10-11 01:24:39 +07:00
Mo Sureerat
8c93351647 Relocate method and fix unit test fail 
Signed-off-by: Mo Sureerat <sureemo@gmail.com>
 2022-10-11 01:18:52 +07:00
Maurício Meneghini Fauth
e96fab654d Move DBI's getProceduresOrFunctions into Routines class 
Splits the method into Routines::getFunctionNames and
Routines::getProcedureNames and adds tests.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-11 17:32:44 -03:00
Maurício Meneghini Fauth
7975f5fb05 Move DBI's getDefinition into the Routines and Events classes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-11 15:48:26 -03:00
Maurício Meneghini Fauth
1cf2d303c0 Refactor Plugins\Export\ExportXml::exportDefinitions method 
Improve type inference of the parameters.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-10 20:03:39 -03:00
Maurício Meneghini Fauth
a8421efd56 Move DBI getTriggers method into the Triggers class 
DatabaseInterface::getTriggers -> Database\Triggers::getDetails

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-10 16:00:42 -03:00
Maurício Meneghini Fauth
d760df02dd Move DBI getEvents method into the Events class 
DatabaseInterface::getEvents -> Database\Events::getDetails

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-10 12:48:44 -03:00
Maurício Meneghini Fauth
81192a142b Move DBI getRoutines method to the Routines class 
DatabaseInterface::getRoutines -> Database\Routines::getDetails

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-09 23:29:26 -03:00
Maurício Meneghini Fauth
9d2350d28c Extract dbi global variable from Index::loadIndexes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-07 21:59:03 -03:00
Maurício Meneghini Fauth
bc4fa31a06 Add better type description for Dbal\DbalInterface::getTableIndexes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-07 16:14:04 -03:00
Maurício Meneghini Fauth
d3a267fdfc Refactor DbiMysqli::connect to use Server value object 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-08-29 18:19:38 -03:00
Maurício Meneghini Fauth
a5d60f5698 Refactor the Server\PrivilegesTest test class 
Removes the class properties to better isolate the test.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-07-07 16:19:01 -03:00
Maurício Meneghini Fauth
eb3703882b Move Routing::getCurrentRoute to ServerRequest 
The route is retrieved from the request, so it makes sense to move the
method to the Http\ServerRequest class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-06-06 23:36:57 -03:00
Maurício Meneghini Fauth
92457c1607 Fix an issue detected by Psalm 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-05-03 15:59:29 -03:00
Kamil Tekiela
116708ffd4 Microoptimize escapeString 
Technically, it's less opcode :)

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-03-15 16:39:29 +00:00
Maurício Meneghini Fauth
c0941401c1 Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-11 14:26:19 -03:00
Maurício Meneghini Fauth
2653b2942b Merge branch 'QA_5_1' into QA_5_2 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-11 13:02:15 -03:00
Maurício Meneghini Fauth
1438cb211e Replace global keyword with $GLOBALS 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-07 17:31:11 -03:00
Maurício Meneghini Fauth
f8bba12d61 Rename DatabaseInterface variables to use camel case 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-01 14:30:01 -03:00
Kamil Tekiela
7be18653aa Fix broken column edit 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-02-13 18:03:34 +00:00
Maurício Meneghini Fauth
a57102412c Merge branch 'QA_5_1' into QA_5_2 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-01-26 10:42:45 -03:00
Maurício Meneghini Fauth
feda222da9 Fix failing tests 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-01-26 10:02:26 -03:00
Maurício Meneghini Fauth
6177f83b03 Merge pull request #17279 from kamil-tekiela/Dbal-pt.4 
Major Dbal refactoring pt.4
 2022-01-19 12:16:14 -03:00
Maurício Meneghini Fauth
813ffbf562 Merge branch 'QA_4_9-security' into QA_5_1-security 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-01-13 17:20:04 -03:00
William Desportes
ca54f1db05 security - Fix - 2FA/U2F can be disabled without any code change 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-01-13 19:07:34 +01:00
Kamil Tekiela
b8f6fce3ef Fix parameter types 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-09 23:09:56 +00:00
Kamil Tekiela
86031d2bf6 Deimplement fetchAssoc() helper 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-09 22:44:53 +00:00
Kamil Tekiela
a4b2d7e524 Deimplement fetchRow() helper 
This helper isn't needed anymore.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-09 22:44:53 +00:00
Kamil Tekiela
3e6e4fffbc Expose execution time as public property 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-09 21:21:55 +00:00
Kamil Tekiela
bcf2b7b322 Deimplement numFields() helper 
There were only two usages remaining. This helper isn't needed anymore.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-07 23:27:37 +00:00
Kamil Tekiela
2edc9da063 Deimplement dataSeek() helper 
There were only two usages remaining. This helper isn't needed anymore.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-07 23:22:49 +00:00
Maurício Meneghini Fauth
290f026a02 Merge pull request #17272 from kamil-tekiela/queryAsControlUser 
Query as control user
 2022-01-06 21:32:46 -03:00