Rosheen Naeem
673c194b01
Fixed underscore prefixes
...
Signed-off-by: Rosheen Naeem <rosheennaeem4@gmail.com >
2020-08-06 17:51:34 +05:00
Maurício Meneghini Fauth
75397c913d
Refactor Display\Export class
...
- Uses template inheritance for the export templates.
- Renames Display\Export to Export\Options.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2020-08-03 23:56:20 -03:00
Maurício Meneghini Fauth
879ae32edc
Extract HTML from server, db and table export controllers
...
- Controllers\Server\ExportController::index
- Controllers\Database\ExportController::index
- Controllers\Table\ExportController::index
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2020-08-01 14:08:51 -03:00
Maurício Meneghini Fauth
e26bde7e96
Fix coding standard errors
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2020-07-24 20:33:47 -03:00
William Desportes
47c70dacc7
Merge branch 'QA_5_0'
...
Signed-off-by: William Desportes <williamdes@wdes.fr >
2020-07-23 19:57:46 +02:00
William Desportes
fe9e7ba89d
Fix #16255 - Tinyint(1) shown as INT in search page
...
Signed-off-by: William Desportes <williamdes@wdes.fr >
2020-07-23 19:53:52 +02:00
Maurício Meneghini Fauth
7b958b874f
Create ExportTemplateController class
...
Extracts export templates handling from Display\Export class.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2020-07-17 16:27:37 -03:00
Maurício Meneghini Fauth
e5328434bf
Extract response from Operations class
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2020-07-14 20:18:03 -03:00
Maurício Meneghini Fauth
858e8dc666
Extract template render from ColumnsDefinition::displayForm
...
Related to https://github.com/phpmyadmin/phpmyadmin/issues/16258 .
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2020-07-12 17:21:36 -03:00
Maurício Meneghini Fauth
1dccc10493
Extract method for adding script files
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2020-07-12 16:58:33 -03:00
Maurício Meneghini Fauth
f8320956ee
Remove Config\PageSettings::showGroup method
...
Related to https://github.com/phpmyadmin/phpmyadmin/issues/16258 .
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2020-07-12 16:01:18 -03:00
Maurício Meneghini Fauth
918b1f38c6
Change return type of Sql::executeQueryAndSendQueryResponse
...
Remove Response::addHTML call.
Related to https://github.com/phpmyadmin/phpmyadmin/issues/16258 .
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2020-07-12 15:22:57 -03:00
Maurício Meneghini Fauth
3b285ff17e
Use identical operator for non-empty strings
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2020-07-10 18:06:29 -03:00
Maurício Meneghini Fauth
a3147c26e1
Extract exit; from Core::previewSQL method
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2020-07-09 16:20:41 -03:00
William Desportes
06ffb871b4
Merge branch 'QA_5_0' and sync Search controllers
...
Signed-off-by: William Desportes <williamdes@wdes.fr >
2020-07-07 15:00:47 +02:00
Ankush Patil
69d49789ce
Fixes #16248 : identifying searchType in validation function
...
Signed-off-by: Ankush Patil <aspraz2658@gmail.com >
2020-07-07 13:57:23 +02:00
Maurício Meneghini Fauth
05c62ad1a8
Fix some PHPStan errors
...
Fixes "Cannot access offset on array" errors.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2020-07-02 16:12:07 -03:00
William Desportes
e89b02c08d
Merge branch 'QA_5_0'
...
Signed-off-by: William Desportes <williamdes@wdes.fr >
2020-06-24 09:07:17 +02:00
William Desportes
40d01944a3
Fix #16088 - Do not add axis switch on MariaDB
...
Ref: 969f43c82b
Signed-off-by: William Desportes <williamdes@wdes.fr >
2020-06-22 21:56:56 +02:00
Maurício Meneghini Fauth
41d401b95e
Extract save action from table structure index method
...
Closes #16136
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2020-06-08 19:57:28 -03:00
Maurício Meneghini Fauth
2529824c23
Extract change column action from table structure index method
...
Related to #16136
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2020-06-08 18:20:48 -03:00
Maurício Meneghini Fauth
5df2c41d67
Extract add-key action from table structure index method
...
Related to #16136
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2020-06-06 19:35:52 -03:00
Maurício Meneghini Fauth
4446963b5a
Extract partitioning actions from index method
...
Extracts from Table/StructureController::index method.
Related to #16136
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2020-06-06 17:20:10 -03:00
Maurício Meneghini Fauth
9d18234581
Refactor Util::getUniqueCondition method
...
Passes the Statement instance directly instead of the
$analyzed_sql_results array.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2020-06-05 13:49:44 -03:00
Maurício Meneghini Fauth
2937e9796d
Remove underscore prefix from some method names
...
Related to #16149
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2020-05-30 17:20:43 -03:00
William Desportes
9ce286070e
Merge #16142 - Split some code out of DatabaseInterface
...
Signed-off-by: William Desportes <williamdes@wdes.fr >
2020-05-27 18:35:07 +02:00
Maurício Meneghini Fauth
f4582e083e
Use early exit when possible
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2020-05-27 00:35:24 -03:00
Maurício Meneghini Fauth
bd979dd1ff
Remove useless elseif with if
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2020-05-26 22:53:44 -03:00
William Desportes
4d61ef2313
Split some code out of DatabaseInterface
...
Signed-off-by: William Desportes <williamdes@wdes.fr >
2020-05-26 13:18:01 +02:00
Maurício Meneghini Fauth
94955f187a
Fix function call signatures indentation
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2020-05-26 04:22:02 -03:00
Maurício Meneghini Fauth
3ae05c785d
Use short list syntax and single line arrays
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2020-05-26 03:32:59 -03:00
Maurício Meneghini Fauth
3baad2eb1c
Fix some coding standard issues
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2020-05-25 22:42:37 -03:00
Maurício Meneghini Fauth
9269d75fb4
Fix some coding standard issues
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2020-05-25 20:22:18 -03:00
William Desportes
6d123fe452
Some minor codebase fixes and improvements
...
Signed-off-by: William Desportes <williamdes@wdes.fr >
2020-05-24 15:25:56 +02:00
Maurício Meneghini Fauth
e638ac2104
Extract table structure reserved word check action
...
Related to #16136
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2020-05-23 15:24:16 -03:00
Maurício Meneghini Fauth
1d17c55f36
Extract table structure move columns action
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2020-05-22 20:20:47 -03:00
Maurício Meneghini Fauth
7902e28652
Remove duplicated code in Table\StructureController
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2020-05-22 19:46:26 -03:00
Maurício Meneghini Fauth
3bf3fd5c36
Extract browse action from table structure index method
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2020-05-22 19:36:07 -03:00
Maurício Meneghini Fauth
a6d9818b3a
Extract the change action from table structure index method
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2020-05-22 19:36:07 -03:00
Maurício Meneghini Fauth
765059def4
Extract central columns actions from index method
...
Extracts the /table/structure/central-columns-add and
/table/structure/central-columns-remove routes from the /table/structure
route.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2020-05-22 17:15:15 -03:00
Maurício Meneghini Fauth
7b5ed8634a
Extract the ftext action from table structure index method
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2020-05-22 15:43:09 -03:00
Maurício Meneghini Fauth
3551dc3eaa
Extract spatial action from table structure index method
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2020-05-22 03:22:14 -03:00
Maurício Meneghini Fauth
2eceedb05c
Extract unique action from table structure index action
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2020-05-22 02:12:36 -03:00
Maurício Meneghini Fauth
4913980970
Extract add index action from table structure index method
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2020-05-21 15:29:36 -03:00
Maurício Meneghini Fauth
115f79c959
Extract primary action from table structure index method
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2020-05-20 19:59:55 -03:00
Maurício Meneghini Fauth
04590f5b4f
Extract drop fields action from index action
...
Extracts the /table/structure/drop route from the /table/structure
route.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2020-05-19 13:37:16 -03:00
Maurício Meneghini Fauth
ff86a0b6d6
Extract drop confirmation action from index action
...
Extracts the /table/structure/drop-confirm route from the
/table/structure route.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2020-05-19 11:21:42 -03:00
William Desportes
a72203c514
Remove some unused code
...
Signed-off-by: William Desportes <williamdes@wdes.fr >
2020-05-16 23:51:43 +02:00
Maurício Meneghini Fauth
80a45fa0ae
Break too long lines
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev >
2020-05-16 18:08:20 -03:00
William Desportes
9bc55b2bc9
Remove some unused variable assignements
...
Signed-off-by: William Desportes <williamdes@wdes.fr >
2020-05-15 22:44:50 +02:00