1
0
mirror of https://github.com/phpmyadmin/phpmyadmin.git synced 2026-10-29 21:24:44 +03:00
Commit Graph

362 Commits

Author SHA1 Message Date
Michal Čihař
f86aca5b80 Merge branch 'QA_4_6' 2016-12-06 10:48:16 +01:00
Michal Čihař
ec9139edef Do not try to run gd based tests if gd extension is not there
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-12-06 10:44:06 +01:00
Michal Čihař
dad93483c1 Merge branch 'QA_4_6' 2016-11-10 11:08:36 +01:00
Deven Bansod
06e9b62a25 Remove tests against unsupported versions
Remove duplicate test, fix other tests

Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2016-11-07 20:42:28 +05:30
Deven Bansod
67501106e0 clear some more tests
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2016-11-07 11:51:47 +05:30
Deven Bansod
28a658fda0 Fix more tests
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2016-11-07 00:18:50 +05:30
Deven Bansod
0d03c97ce6 Fix more test errors
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2016-11-06 23:47:23 +05:30
Deven Bansod
3f48d9cb5f Fixed some more test errors
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2016-11-05 09:49:55 +05:30
Deven Bansod
8b6e102cf7 Fixed small error in XML test
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2016-11-04 20:54:23 +05:30
Deven Bansod
02dcfc8198 Fix errors with TrackerTest
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2016-11-04 19:16:01 +05:30
Deven Bansod
675186ee00 Fixed tests in Designer, Insert edit for, UserGroups, User preferences
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2016-11-04 18:17:31 +05:30
Deven Bansod
6a79e7c0c0 Fixed some tests in Export, Import and Node
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2016-11-04 14:21:02 +05:30
Deven Bansod
956f3179cb Fix Navigation tests and Export tests
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2016-11-04 11:55:46 +05:30
Deven Bansod
f14cffdbe7 Properly escape strings in MySQL statement values
Use *_real_escape string functions provided by connectors to escape strings while exporting

Fix #12453

Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>

Conflicts:
	libraries/server_privileges.lib.php
2016-10-29 10:45:12 +05:30
Deven Bansod
201ba095ce Adjust tests
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2016-10-14 10:01:04 +05:30
Deven Bansod
6ed1da5a45 Merge branch 'QA_4_6' 2016-10-14 09:59:32 +05:30
Deven Bansod
3accab1764 Adjust tests
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2016-10-14 09:55:50 +05:30
Michal Čihař
1d09172f14 Turn OpenDocument wrapper to a class
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-09-16 11:49:53 +02:00
Michal Čihař
23e01d306a Merge branch 'QA_4_6' 2016-08-17 15:38:22 +02:00
Michal Čihař
83476322ba Use PmaAbsolueUri for cookie path
Issue #12374

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-08-17 15:35:15 +02:00
Michal Čihař
7ef6fecb87 Merge branch 'master' into master-security 2016-08-01 11:07:33 +02:00
Michal Čihař
ea73fded71 Adjust tests to token removal from GET
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-07-28 11:22:45 +02:00
Michal Čihař
360b8e8a11 Merge branch 'master' into master-security 2016-07-28 09:44:08 +02:00
Michal Čihař
d31ff5a1e7 Merge branch 'QA_4_6' into QA_4_6-security 2016-07-28 09:43:26 +02:00
Michal Čihař
6d8e1d7935 Merge branch 'QA_4_6' 2016-07-28 09:38:08 +02:00
Michal Čihař
4072c1d29a Use example.com for sample test urls
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-07-28 09:12:01 +02:00
Michal Čihař
d15490088c Merge branch 'QA_4_6' 2016-07-27 16:30:47 +02:00
Michal Čihař
af337d2054 Use https to access phpmyadmin.net
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-07-27 16:29:08 +02:00
Michal Čihař
f5015c2ea3 Merge branch 'QA_4_6-security' into master-security 2016-07-26 16:31:21 +02:00
Michal Čihař
99492bf42a Merge branch 'QA_4_6' into QA_4_6-security 2016-07-26 16:29:07 +02:00
Michal Čihař
22c4ede46d Merge branch 'QA_4_6' 2016-07-26 16:26:57 +02:00
Michal Čihař
6c95b73f90 Do not append session IDs to all URLs in redirect
There is no need to do that as we rely on session cookies anyway. Also
appending sesson ID to external URLs is not a good idea.

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-07-26 16:20:04 +02:00
Michal Čihař
45aedabbe6 Fix test errors
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-07-22 14:47:28 +02:00
Michal Čihař
f72572708f Merge branch 'QA_4_6-security' into master-security 2016-07-22 14:42:09 +02:00
Michal Čihař
9106b33933 Improve secrets splitting
- ensure it has 16 bytes
- extends it by copying content if original is too short
- correctly handle corner cases (eg. 1 byte secret)

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-07-22 14:10:28 +02:00
Michal Čihař
643681ee68 Use consistent iv and encrypted text concatenation as other libs
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-07-22 13:46:51 +02:00
Michal Čihař
2adf1ca83e Merge branch 'QA_4_6-security' into master-security 2016-07-22 11:35:14 +02:00
Michal Čihař
3ee65fc8bf Use MAC to verify IV as well
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-07-22 10:29:46 +02:00
Michal Čihař
ef03daf658 Remove hashing of blowfish secret
New code doesn't have problems with longer secrets.

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-07-22 09:59:02 +02:00
Michal Čihař
d29df46b3a Do not generate too long session secret
We need 16+16 bytes, generating 256 is not really needed.

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-07-22 09:58:39 +02:00
Michal Čihař
e2a25d773d Merge pmaServer and pmaPass cookies
This addresses several issues:

- makes server name encrypted and authenticated, so that it can not be
  tampered
- reduces cookie usage
- reduces overhead of encryption/authentication

The pmaUser cookie is still separate to avoid different lifetime
(pmaUser has month lifetime, while pmaAuth is session only by default).

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-07-22 09:47:32 +02:00
Michal Čihař
2a2d865d50 Validate input data from cookies
We expect strings only, so not accept anything else.

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-07-22 09:47:32 +02:00
Michal Čihař
3ba8a026fc Use hash_hmac for MAC rather than plain SHA1
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-07-18 16:56:52 +02:00
Michal Čihař
3f98ad5414 Merge branch 'QA_4_6-security' into master-security 2016-07-18 16:24:12 +02:00
Michal Čihař
1543be7138 Use https to access phpmyadmin.net
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-07-18 16:22:33 +02:00
Michal Čihař
af8385dc87 Fix tests for transformations
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-07-13 12:16:45 +02:00
Michal Čihař
97ff98bc62 Fix tests for transformations
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-07-13 12:12:10 +02:00
Michal Čihař
f00b258749 Merge branch 'QA_4_6-security' into master-security 2016-07-12 14:16:11 +02:00
Michal Čihař
2ef4fe3d84 Use iframe sandbox for rendering HTML in transformation
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-07-12 14:15:30 +02:00
Michal Čihař
065b876c1a Merge branch 'QA_4_6-security' into master-security 2016-07-12 11:22:37 +02:00