1
0
mirror of https://github.com/phpmyadmin/phpmyadmin.git synced 2026-11-03 11:53:04 +03:00
Commit Graph

1222 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
b25dc2426e Merge pull request #17806 from sivadasrajan/refactoring-db-table
Refactored Bookmark::get() for DatabaseName
2022-10-20 21:57:43 -03:00
Umang Patel
fdb5528648 Use Database type instead of string (#17746)
* Refactored tryColumnCreationQuery function inside CreateAddField to use DatabaseName type instead of string
* Refactored exportDatabase and lockTables function to use DatabaseName type instead of string for database name

Signed-off-by: Umang Patel <umang.patel@healthengine.com.au>
Co-authored-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-20 21:34:10 -03:00
SIVADAS P R
12656141f6 Refactored Bookmark::get() for DatabaseName
Signed-off-by: SIVADAS P R <sivadasrajan@gmail.com>
2022-10-21 01:52:09 +05:30
Maurício Meneghini Fauth
187642560c Fix Database QbeTest
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-20 03:07:47 -03:00
Maurício Meneghini Fauth
816bec5493 Merge pull request #17816 from pistej/server-request-db-controllers-1
Use ServerRequest Object instead superglobals - MultiTableQuery
2022-10-20 02:02:19 -03:00
Luca Perna
d1b5cb6987 16276 - Reduce the usage of SuperGlobals (#17795)
Signed-off-by: Luca Perna <luca@perna.rocks>
2022-10-20 01:52:38 -03:00
Sebastian Walther
d569fe2f05 Use ServerRequestObject to access POST-vars
Signed-off-by: Sebastian Walther <swalther@complex-it.de>
2022-10-20 01:23:50 -03:00
Sebastian Walther
edfe8a5881 Replace POST-var access with Serverrequest object - pt 2 (#17787)
* Use ServerRequestObject to access POST-vars

Signed-off-by: Sebastian Walther <swalther@complex-it.de>
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Co-authored-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-19 22:06:35 -03:00
Jozef Pistej
5e23fcde36 Use ServerRequest Object instead superglobals - MultiTableQuery controllers
Signed-off-by: Jozef Pistej <pistej2@gmail.com>
2022-10-19 22:48:37 +02:00
Arpit Jain
e4652bc044 Replace $db and $table with DatabaseName and TableName (#17790)
Signed-off-by: Arpit Gulgulia <arpitgulgulia@gmail.com>
2022-10-18 14:31:27 -03:00
Maurício Meneghini Fauth
1bf0abdbb7 Merge pull request #17810 from kamil-tekiela/triggers-and-routines
Triggers and routines should be a dependency
2022-10-18 11:10:30 -03:00
Maurício Meneghini Fauth
b054d0091e Merge pull request #17807 from kamil-tekiela/table-dbi
Pass $dbi as argument to Table
2022-10-18 11:08:36 -03:00
Maurício Meneghini Fauth
c76bb77b3c Merge pull request #17805 from kamil-tekiela/Fix-phpstan-issues3
Fix static analysis issues
2022-10-18 11:05:32 -03:00
Kamil Tekiela
27fad8821e Make Routines a dependency
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-10-18 13:53:15 +01:00
Kamil Tekiela
3e5f101d6f Make Triggers a dependency
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-10-18 13:53:14 +01:00
Maurício Meneghini Fauth
0f57dfff5b Merge pull request #17800 from kamil-tekiela/Fix-phpstan-issues-2
Fix PHPStan issues 2
2022-10-17 20:32:59 -03:00
Kamil Tekiela
2c416128e5 Pass as argument to Table
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-10-17 22:30:33 +01:00
Kamil Tekiela
f2a83311ae Simplify onchange in InsertEdit.php
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-10-17 21:28:57 +01:00
Bhuvi100
9a3090ef75 Make search input field types match columns types (integer and float) (#17765)
This PR adds type attribute as well as inputmode attribute to search value input fields which makes it easier for validation as well as for using phpMyAdmin on touch devices with virtual keyboards.

Fixes #17745

Signed-off-by: Bhuvanesh T G <gbhuvanesh100@gmail.com>
Co-authored-by: William Desportes <williamdes@wdes.fr>
2022-10-17 15:41:51 -03:00
Kamil Tekiela
32d93281bb Make alias merging cleaner
No useless globals, no overwriting of the same value. The values seem to always be string|null so let's check explicitly for that.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-10-17 14:43:28 +01:00
Maurício Meneghini Fauth
3890d11dd8 Fix some coding style issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-16 17:18:54 -03:00
Maurício Meneghini Fauth
478b1c03a7 Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-16 13:52:33 -03:00
Maurício Meneghini Fauth
4d1546f7c5 Fix indentation issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-16 13:41:31 -03:00
Kamil Tekiela
0ca6b456d5 Casting to int something that's already int
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-10-15 20:15:50 +01:00
Kamil Tekiela
20ce0a8f2f Refactor $GLOBALS['display_page']
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-10-15 20:15:50 +01:00
Maurício Meneghini Fauth
d01ec6b0b9 Merge pull request #17776 from kamil-tekiela/Fix-PHPStan-issues
Fix PHPStan issues
2022-10-15 16:05:50 -03:00
Maurício Meneghini Fauth
f3e31dfdd1 Merge branch 'pokemaobr-push'
Closes https://github.com/phpmyadmin/phpmyadmin/pull/17791

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-14 23:57:29 -03:00
Rodrigo Pokemaobr
0bd4711eb5 Changing parameters to Parser
Signed-off-by: Rodrigo Pokemaobr <contato@pokemaobr.dev>
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-14 23:52:12 -03:00
Kamil Tekiela
594454eff2 Replace for loop with foreach
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-10-14 20:42:42 +01:00
Maurício Meneghini Fauth
4bda7899ab Fix coding standard issues after #17794 merge
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-14 08:44:52 -03:00
Luca Perna
40adf927c5 Move superglobals access to controllers (#17794)
Related to #16276

Signed-off-by: Luca Perna <luca@perna.rocks>
2022-10-14 08:34:42 -03:00
Arpit-Gulgulia
4302745a74 Fix:#17769 Signed-off-by: Arpit Jain <arpitgulgulia@gmail.com>
Signed-off-by: Arpit-Gulgulia <arpitgulgulia@gmail.com>
2022-10-13 17:36:20 +00:00
Maurício Meneghini Fauth
8da8d3f8c8 Add types for Config\FormDisplay::save() parameters
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-12 19:19:36 -03:00
Maurício Meneghini Fauth
46fdea0d0e Remove unneeded writing to $_POST in Database\Structure controllers
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-12 18:07:10 -03:00
Maurício Meneghini Fauth
059705f06e Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-11 19:53:54 -03:00
Maurício Meneghini Fauth
72a6045f06 Fix some errors reported by Psalm
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-11 18:19:07 -03:00
Maurício Meneghini Fauth
4cd6b23007 Add Http\ServerRequest::getQueryParam method
Similar to the Http\ServerRequest::getParsedBodyParam method, this
method retrives a single parameter from the request query, or the
default value if not available.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-10 23:00:33 -03:00
Maurício Meneghini Fauth
85f9d94f1b Add basic routing system for setup pages
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-10 06:54:45 -03:00
Maurício Meneghini Fauth
6e3fa576c6 Use ServerRequest object for setup controller
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-09 17:05:13 -03:00
Maurício Meneghini Fauth
e05c51576c Extract setup entry points into controllers
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-09 16:22:51 -03:00
Maurício Meneghini Fauth
135cd76d3b Fix exception for invalid db and table names for the privileges page
Related to #17729

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-09-30 20:49:21 -03:00
Solomon Okunuga
0f9c79ebed Issue #17727 Started refactoring uses of $db and $table (#17729)
* Issue #17727 Started refactoring uses of $db and $table to use the Objects -
DatabaseName and TableName

Changed uses related to Privileges

Signed-off-by: Solomon Okunuga <soloistic1@gmail.com>

* Apply suggestions from code review

Co-authored-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

Signed-off-by: Solomon Okunuga <soloistic1@gmail.com>
Co-authored-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-09-30 19:33:36 -03:00
Maurício Meneghini Fauth
bb97ed988f Reduce usage of the containerBuilder global variable
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-09-29 22:36:46 -03:00
Maurício Meneghini Fauth
6a9fe03ff2 Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-09-29 00:45:10 -03:00
Maurício Meneghini Fauth
5d9142674d Allow longer cookie encryption keys to be used
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-09-26 17:34:18 -03:00
Maurício Meneghini Fauth
0ed04a6c00 Remove trigger_error calls from HomeController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
(cherry picked from commit c5611531c0)
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-09-26 17:33:38 -03:00
Maurício Meneghini Fauth
a56b425a2a Extract /console/bookmark/add action from ImportController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-09-21 00:06:14 -03:00
Maurício Meneghini Fauth
c2018c4c21 Extract /console/bookmark/refresh action from ImportController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-09-20 21:55:28 -03:00
Maurício Meneghini Fauth
2076d52480 Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-09-19 23:26:15 -03:00
Maurício Meneghini Fauth
c51b5fa437 Use DatabaseName for the newname param in OperationsController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-09-13 20:36:06 -03:00